summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSolomon Peachy <pizza@shaftnet.org>2021-05-19 17:09:48 -0400
committerSolomon Peachy <pizza@shaftnet.org>2021-05-19 17:09:48 -0400
commit0c6217757528b185c3f8628c062a2a688a8adaf8 (patch)
tree958c29261292bb73f030570887b4264a49e2f3e7
parent3ed035769c53d1b8957535c6e6bd8a2e56058d80 (diff)
downloadrockbox-0c6217757528b185c3f8628c062a2a688a8adaf8.tar.gz
rockbox-0c6217757528b185c3f8628c062a2a688a8adaf8.zip
FS12845: Fix uninitialized read
Change-Id: If0e5b65a70e10b624416e2a15e0b3df29c2b4591
-rw-r--r--firmware/drivers/synaptics-mep.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/firmware/drivers/synaptics-mep.c b/firmware/drivers/synaptics-mep.c
index 01845bfe0c..bae17e08c7 100644
--- a/firmware/drivers/synaptics-mep.c
+++ b/firmware/drivers/synaptics-mep.c
@@ -560,7 +560,10 @@ int touchpad_read_device(char *data, int len)
{
/* for HDD6330 an absolute packet will follow for sensor nr 0 which we ignore */
#if defined(PHILIPS_HDD6330)
- if ((data[3]>>6) == 0) syn_read(tmp, 4);
+ if ((data[3]>>6) == 0)
+ syn_read(tmp, 4);
+ else
+ tmp[1] = 0x0; /* Initialize explicitly */
// relay tap gesture packet
if (tmp[1]==0x02) { data[1]=0x02; data[2]=0x00; data[3]=0x00; }
#endif