summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2021-07-28 11:18:51 +0100
committerWilliam Wilgus <me.theuser@yahoo.com>2021-08-05 10:26:50 +0000
commit03a6eb63f1ad6c94aa693bf7d5c766b25072c5ef (patch)
tree7f0affdf9ef081d4723703ed03c218b6da3c4267
parent429a7e2c0a83f70b0dc15c5287547fafcac80a9c (diff)
downloadrockbox-03a6eb63f1ad6c94aa693bf7d5c766b25072c5ef.tar.gz
rockbox-03a6eb63f1ad6c94aa693bf7d5c766b25072c5ef.tar.bz2
rockbox-03a6eb63f1ad6c94aa693bf7d5c766b25072c5ef.zip
Simplify clamp_component
Surprise surprise: the compiler generates shorter, branch-free code if we don't try to be clever with signed/unsigned casting tricks. Change-Id: I93d2020b6127e7d43feee394b06a52aaeddf3b79
-rw-r--r--apps/recorder/jpeg_common.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/recorder/jpeg_common.h b/apps/recorder/jpeg_common.h
index c2abce8f49..de998f1ddd 100644
--- a/apps/recorder/jpeg_common.h
+++ b/apps/recorder/jpeg_common.h
@@ -83,8 +83,8 @@ union uint8_rgbyuv {
static inline int clamp_component(int x)
{
- if ((unsigned)x > 255)
- x = x < 0 ? 0 : 255;
+ if(x > 255) return 255;
+ if(x < 0) return 0;
return x;
}
#include <debug.h>