summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSolomon Peachy <pizza@shaftnet.org>2024-05-31 10:10:45 -0400
committerSolomon Peachy <pizza@shaftnet.org>2024-07-22 09:42:05 -0400
commit2bb9323de8e4edc0a04ccf7ccf61e3026b5ef847 (patch)
tree45d77008a6dfec3a07abd17975b3ee3e9a1464e7
parentca332b547384102a44f07648a0480797dce2f012 (diff)
downloadrockbox-2bb9323de8.tar.gz
rockbox-2bb9323de8.zip
FS#13429: Add a freeform "player name" configuration setting
The idea is that a theme or whatever could use this to provide visual differentiation (eg "George's iPod") between multiple otherwise-identical players.. Defaults to an empty string. Added to the manual but there is not a way to set this through the menus yet. Change-Id: I1cff6b19d621dd6207b4b82eed67741ce2da0ef1
-rw-r--r--apps/settings.h1
-rw-r--r--apps/settings_list.c6
-rw-r--r--manual/appendix/config_file_options.tex1
3 files changed, 6 insertions, 2 deletions
diff --git a/apps/settings.h b/apps/settings.h
index 1df1e0b418..056f40df6a 100644
--- a/apps/settings.h
+++ b/apps/settings.h
@@ -803,6 +803,7 @@ struct user_settings
#ifdef HAVE_REMOTE_LCD
unsigned char remote_ui_vp_config[64]; /* viewport string for the remote lists */
#endif
+ char player_name[64]; /* Name of the local player */
struct compressor_settings compressor_settings;
diff --git a/apps/settings_list.c b/apps/settings_list.c
index 09a45f1faa..98e8dec5a8 100644
--- a/apps/settings_list.c
+++ b/apps/settings_list.c
@@ -998,7 +998,7 @@ const struct settings_list settings[] = {
play_frequency, LANG_FREQUENCY, 0, "playback frequency", "auto",
UNIT_KHZ, formatter_freq_unit_0_is_auto,
getlang_freq_unit_0_is_auto,
- playback_frequency_callback,
+ playback_frequency_callback,
#if HAVE_PLAY_FREQ >= 192
7,0,SAMPR_44,SAMPR_48,SAMPR_88,SAMPR_96,SAMPR_176,SAMPR_192),
#elif HAVE_PLAY_FREQ >= 96
@@ -1883,7 +1883,7 @@ const struct settings_list settings[] = {
#ifdef HAVE_BACKLIGHT
CHOICE_SETTING(0, backlight_on_button_hold,
LANG_BACKLIGHT_ON_BUTTON_HOLD,
-#ifdef HAS_BUTTON_HOLD
+#ifdef HAS_BUTTON_HOLD
1,
#else
0,
@@ -2217,6 +2217,8 @@ const struct settings_list settings[] = {
VIEWPORT_SETTING(remote_ui_vp_config, "remote ui viewport"),
#endif
+ TEXT_SETTING(F_THEMESETTING, player_name, "player name", "", NULL, NULL),
+
#ifdef HAVE_MORSE_INPUT
OFFON_SETTING(0, morse_input, LANG_MORSE_INPUT, false, "morse input", NULL),
#endif
diff --git a/manual/appendix/config_file_options.tex b/manual/appendix/config_file_options.tex
index c4318692c4..b3e4363815 100644
--- a/manual/appendix/config_file_options.tex
+++ b/manual/appendix/config_file_options.tex
@@ -384,6 +384,7 @@
clear settings on hold
& off, on & N/A\\
}%
+ player name & freeform text, defaults to an empty string & N/A\\
\bottomrule
\end{longtable}
\end{center}