summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJens Arnold <amiconn@rockbox.org>2008-10-31 20:06:08 +0000
committerJens Arnold <amiconn@rockbox.org>2008-10-31 20:06:08 +0000
commit3aa58328080ab9a254d9f2329696fa4309a30d50 (patch)
treed1485fc76816b30395bf231dbfd758a5a7eb6974
parentcd9b1379fff9b2c2d4bb071c470053e02f4e2dd5 (diff)
downloadrockbox-3aa58328080ab9a254d9f2329696fa4309a30d50.tar.gz
rockbox-3aa58328080ab9a254d9f2329696fa4309a30d50.zip
Revert r18947, and add a comment why the backlight functions are wanted on all targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18949 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/plugin.c2
-rw-r--r--apps/plugin.h7
2 files changed, 7 insertions, 2 deletions
diff --git a/apps/plugin.c b/apps/plugin.c
index 9a7e9b578c..13c829805f 100644
--- a/apps/plugin.c
+++ b/apps/plugin.c
@@ -147,7 +147,6 @@ static const struct plugin_api rockbox_api = {
gui_scrollbar_draw,
#endif
-#ifdef HAVE_BACKLIGHT
backlight_on,
backlight_off,
backlight_set_timeout,
@@ -159,7 +158,6 @@ static const struct plugin_api rockbox_api = {
backlight_set_timeout_plugged,
#endif
is_backlight_on,
-#endif /* HAVE_BACKLIGHT */
splash,
splashf,
diff --git a/apps/plugin.h b/apps/plugin.h
index 634bbed0d8..4f747ea2b1 100644
--- a/apps/plugin.h
+++ b/apps/plugin.h
@@ -246,6 +246,13 @@ struct plugin_api {
#endif /* HAVE_LCD_BITMAP */
/* backlight */
+ /* The backlight_* functions must be present in the API regardless whether
+ * HAVE_BACKLIGHT is defined or not. The reason is that the stock Ondio has
+ * no backlight but can be modded to have backlight (it's prepared on the
+ * PCB). This makes backlight an all-target feature API wise, and keeps API
+ * compatible between stock and modded Ondio.
+ * For OLED targets like the Sansa Clip, the backlight_* functions control
+ * the display enable, which has essentially the same effect. */
void (*backlight_on)(void);
void (*backlight_off)(void);
void (*backlight_set_timeout)(int index);