summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Soffke <christian.soffke@gmail.com>2024-12-13 20:19:37 +0100
committerChristian Soffke <christian.soffke@gmail.com>2024-12-13 20:49:18 +0100
commit4cf65ec926e9128a22a539c6eda047a53f582a9b (patch)
treeba2e3d2ac599174b537d1fc8f47fce3d363318a0
parenta23002cd5e8dc555cd9d8f5c5df46839614bbe83 (diff)
downloadrockbox-4cf65ec926.tar.gz
rockbox-4cf65ec926.zip
metadata: mp3: fix iTunSMPB info replacing comment
Data from the iTunes seamless playback data field (support for which was introduced in f3e5ced) prevents proper comments from being displayed. Change-Id: Ifb00b1229e636a79a460ba6d706191fcf28b1502
-rw-r--r--lib/rbcodec/metadata/id3tags.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/rbcodec/metadata/id3tags.c b/lib/rbcodec/metadata/id3tags.c
index 7006f5e739..26614608e9 100644
--- a/lib/rbcodec/metadata/id3tags.c
+++ b/lib/rbcodec/metadata/id3tags.c
@@ -1123,7 +1123,6 @@ retry_with_limit:
break;
tag[bytesread] = 0;
- bufferpos += bytesread + 1;
/* parse the tag if it contains iTunes gapless info */
if (itunes_gapless)
@@ -1131,8 +1130,11 @@ retry_with_limit:
itunes_gapless = false;
entry->lead_trim = get_itunes_int32(tag, 1);
entry->tail_trim = get_itunes_int32(tag, 2);
+ break;
}
+ bufferpos += bytesread + 1;
+
/* Note that parser functions sometimes set *ptag to NULL, so
* the "!*ptag" check here doesn't always have the desired
* effect. Should the parser functions (parsegenre in