summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSolomon Peachy <pizza@shaftnet.org>2020-03-29 12:42:16 -0400
committerSolomon Peachy <pizza@shaftnet.org>2020-03-29 18:44:15 +0200
commit51ad6254048c85284a287ade1a602e3432209b77 (patch)
tree84134f9986660994bab4738a20f00a574c7abd30
parentf86f7883f53d1dcd7d441a7cd9e4fce4c1318b1f (diff)
downloadrockbox-51ad6254048c85284a287ade1a602e3432209b77.tar.gz
rockbox-51ad6254048c85284a287ade1a602e3432209b77.tar.bz2
rockbox-51ad6254048c85284a287ade1a602e3432209b77.zip
FS#13186: IAP: Send periodic updates in mode 4 (Stefan Ott)
Devices in IAP mode 4 do not explicitly request specific notifications, thus they don't get *any* periodic notifications at the moment (in particular, they miss the track position updates that are supposed to be sent out every 500 ms). The attached patch fixes this by skipping an early return for devices in IST_EXTENDED state. Change-Id: I23e35247dd0494e537429d4fd9d51dc7f4653d76
-rw-r--r--apps/iap/iap-core.c2
-rw-r--r--docs/CREDITS1
2 files changed, 2 insertions, 1 deletions
diff --git a/apps/iap/iap-core.c b/apps/iap/iap-core.c
index 653396ae6a..f8373bab83 100644
--- a/apps/iap/iap-core.c
+++ b/apps/iap/iap-core.c
@@ -855,7 +855,7 @@ void iap_periodic(void)
}
if (!device.do_notify) return;
- if (device.notifications == 0) return;
+ if ((device.notifications == 0) && (interface_state != IST_EXTENDED)) return;
/* Volume change notifications are sent every 100ms */
if (device.notifications & (BIT_N(4) | BIT_N(16))) {
diff --git a/docs/CREDITS b/docs/CREDITS
index 81b2f8ccff..5cedaf01b1 100644
--- a/docs/CREDITS
+++ b/docs/CREDITS
@@ -683,6 +683,7 @@ Andy Potter
Stefan Waigand
Guo Zhong Kai
Martin Buck
+Stefan Ott
The libmad team
The wavpack team