summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmaury Pouly <amaury.pouly@gmail.com>2017-08-27 15:55:01 +0200
committerAmaury Pouly <amaury.pouly@gmail.com>2017-08-27 17:48:39 +0200
commit5d2d747247b6ff6b4a82b5674f05c47a838c499b (patch)
tree21ff0a5284732d8e6c4516008fa6bfff28102f5b
parent7ce764cdc3fc8ce40c81097ca61602cfc61885f5 (diff)
downloadrockbox-5d2d747247b6ff6b4a82b5674f05c47a838c499b.tar.gz
rockbox-5d2d747247b6ff6b4a82b5674f05c47a838c499b.tar.bz2
rockbox-5d2d747247b6ff6b4a82b5674f05c47a838c499b.zip
imx233: update comment about vbusvalid
Change-Id: Ice1ece716657fa7f78f69736e5e733e1b7f67b59
-rw-r--r--firmware/target/arm/imx233/power-imx233.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/firmware/target/arm/imx233/power-imx233.c b/firmware/target/arm/imx233/power-imx233.c
index 9b9c13573a..040b44cbf2 100644
--- a/firmware/target/arm/imx233/power-imx233.c
+++ b/firmware/target/arm/imx233/power-imx233.c
@@ -129,8 +129,9 @@ static struct current_step_bit_t g_4p2_charge_limit_bits[] =
* Since we didn't encounter this problem, we never lock VBUSVALID
*
* WARNING
- * Using VBUSVALID irq on STMP3700 seems broken, once the irq is fired,
- * it cannot be acked. Currently fallback to the VDD5V>VDDIO method.
+ * Using VBUSVALID IRQ is broken on STMP3700 (see errata). The IRQ cannot be
+ * cleared. Currently fallback to the VDD5V>VDDIO method even though it's less
+ * reliable (we could use polling too).
*/
#if IMX233_SUBTARGET >= 3780
#define USE_VBUSVALID