summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Soffke <christian.soffke@gmail.com>2021-11-21 11:34:03 +0100
committerSolomon Peachy <pizza@shaftnet.org>2021-12-02 17:37:49 -0500
commit8325b59f3b2b7eee3d4e7476371e3bd3019fe612 (patch)
tree15abfd4fed2f6d70336c3a9da4edeceb0624aa43
parent2ee4f50fa6f727f114e16e63dc9ed6e12d0720e5 (diff)
downloadrockbox-8325b59f3b.tar.gz
rockbox-8325b59f3b.zip
PictureFlow: (grayscale) invert ‘Added to Playlist’ message
Feels less interruptive this way, since the background doesn't suddenly switch from dark to light. Also moved message to separate function and added missing lcd_update() after clearing display. Change-Id: Id196554b42fa4de16a6b23136d27358159b746b6
-rw-r--r--apps/plugins/pictureflow/pictureflow.c32
1 files changed, 19 insertions, 13 deletions
diff --git a/apps/plugins/pictureflow/pictureflow.c b/apps/plugins/pictureflow/pictureflow.c
index c2fe178167..aba9443120 100644
--- a/apps/plugins/pictureflow/pictureflow.c
+++ b/apps/plugins/pictureflow/pictureflow.c
@@ -3623,6 +3623,24 @@ static void draw_album_text(void)
}
/**
+ Display an info message when items have been added to playlist
+*/
+static void rb_splash_added_to_playlist(void)
+{
+#ifdef USEGSLIB
+ grey_show(false);
+ rb->lcd_set_background(N_BRIGHT(0));
+ rb->lcd_set_foreground(N_BRIGHT(255));
+ rb->lcd_clear_display();
+ rb->lcd_update();
+#endif
+ rb->splash(HZ*2, ID2P(LANG_ADDED_TO_PLAYLIST));
+#ifdef USEGSLIB
+ grey_show(true);
+#endif
+}
+
+/**
Display an error message and wait for input.
*/
static void error_wait(const char *message)
@@ -3946,19 +3964,7 @@ static int pictureflow_main(void)
PLAYLIST_INSERT_LAST, false, true);
rb->playlist_sync(NULL);
}
-#ifdef USEGSLIB
- /*
- calling splash() without switching off the grayscale overlay
- beforehand, will lead to image corruption and a crash
- in testing on device (iPod 4G,iPod mini)
- */
- grey_show(false);
- rb->lcd_clear_display();
-#endif
- rb->splash(HZ*2, ID2P(LANG_ADDED_TO_PLAYLIST));
-#ifdef USEGSLIB
- grey_show(true);
-#endif
+ rb_splash_added_to_playlist();
}
break;
#endif