summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJens Arnold <amiconn@rockbox.org>2007-10-16 08:34:51 +0000
committerJens Arnold <amiconn@rockbox.org>2007-10-16 08:34:51 +0000
commit8b44601a7c306611b9aba29a7774708585c97539 (patch)
tree45b6926f43f77247ff5536977a7a0d6a7ebfc370
parente9feb063f58caf1c625b80eb317f8727943a28e4 (diff)
downloadrockbox-8b44601a7c306611b9aba29a7774708585c97539.tar.gz
rockbox-8b44601a7c306611b9aba29a7774708585c97539.tar.bz2
rockbox-8b44601a7c306611b9aba29a7774708585c97539.zip
Disable highperf mode in the peakmeter for swcodec targets, as it makes no sense. Improves responsiveness a lot with a peakmeter-enabled wps on targets with slow lcd updates (e.g. G5). Added a comment why highperf mode is needed for MAS targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15140 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/recorder/peakmeter.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/apps/recorder/peakmeter.c b/apps/recorder/peakmeter.c
index c4bf07146d..fe97bd83d2 100644
--- a/apps/recorder/peakmeter.c
+++ b/apps/recorder/peakmeter.c
@@ -1318,10 +1318,15 @@ int peak_meter_draw_get_btn(int x, int y[], int height, int nb_screens)
long next_refresh = current_tick;
long next_big_refresh = current_tick + HZ / 10;
int i;
-#ifndef SIMULATOR
- bool highperf = !ata_disk_is_active();
-#else
+#if (CONFIG_CODEC == SWCODEC) || defined(SIMULATOR)
bool highperf = false;
+#else
+ /* On MAS targets, we need to poll as often as possible in order to not
+ * miss a peak, as the MAS does only provide a quasi-peak. When the disk
+ * is active, it must not draw too much CPU power or a buffer overrun can
+ * happen when saving a recording. As a compromise, poll only once per tick
+ * when the disk is active, otherwise spin around as fast as possible. */
+ bool highperf = !ata_disk_is_active();
#endif
bool dopeek = true;