summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSolomon Peachy <pizza@shaftnet.org>2024-11-11 09:57:41 -0500
committerSolomon Peachy <pizza@shaftnet.org>2024-11-11 16:29:56 -0500
commitd6e2b5d3cf86814cbc670b8b3df08a3b75094543 (patch)
treec55929a4d1599ccd344a19156d2d159f78582b00
parenta4fe20a27806fe5cf40a2b62aec484a7fa3d09d1 (diff)
downloadrockbox-d6e2b5d3cf.tar.gz
rockbox-d6e2b5d3cf.zip
Enable use of ATA DMA on Philips GoGear HDD1630 and HDD6630
These are PP502x-based devices shipped with ATA drives. However, PIO is flaky when used with the various ATA/CF<->SD adapters, so turn it in across the board. Change-Id: I65384d95e2e4498eb03f43ac990b01e0c6d060c5
-rw-r--r--firmware/export/config/gogearhdd1630.h4
-rw-r--r--firmware/export/config/gogearhdd6330.h8
2 files changed, 3 insertions, 9 deletions
diff --git a/firmware/export/config/gogearhdd1630.h b/firmware/export/config/gogearhdd1630.h
index 9f611317e5..da2d2dfe23 100644
--- a/firmware/export/config/gogearhdd1630.h
+++ b/firmware/export/config/gogearhdd1630.h
@@ -200,10 +200,6 @@
#define ICODE_ATTR_TREMOR_NOT_MDCT
-
-/* DMA is used only for reading on PP502x because although reads are ~8x faster
- * writes appear to be ~25% slower.
- */
#ifndef BOOTLOADER
#define HAVE_ATA_DMA
#endif
diff --git a/firmware/export/config/gogearhdd6330.h b/firmware/export/config/gogearhdd6330.h
index 18a1e8012b..2c724c1ca4 100644
--- a/firmware/export/config/gogearhdd6330.h
+++ b/firmware/export/config/gogearhdd6330.h
@@ -205,11 +205,9 @@
#define ICODE_ATTR_TREMOR_NOT_MDCT
-/* DMA is used only for reading on PP502x because although reads are ~8x faster
- * writes appear to be ~25% slower.
- */
-/* TODO: it does not work - it hangs the player */
-/* #define HAVE_ATA_DMA */
+#ifndef BOOTLOADER
+#define HAVE_ATA_DMA
+#endif
/* Define this if a programmable hotkey is mapped */
#define HAVE_HOTKEY