summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoman Artiukhin <bahusdrive@gmail.com>2024-11-05 12:11:15 +0200
committerSolomon Peachy <pizza@shaftnet.org>2024-11-07 07:59:52 -0500
commitee365f21c45f80a1509f2642decd9a10271164e1 (patch)
tree594a2d2a03fd1dc34f1059bfad64190fb5d0f7be
parentda478aaa3237b691dfaa4676eb384fc64349e8ea (diff)
downloadrockbox-ee365f21c4.tar.gz
rockbox-ee365f21c4.zip
show track info: skip Comment and codec string copies
Comment copy was added in c647e62c as workaround for FS#11033 and no longer needed (I tested really long lines and scroll no longer throw any errors on my Sansa e200v2) Change-Id: I96a5b26096829034692dffc2abc730ff2bdd5d9c
-rw-r--r--apps/screens.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/apps/screens.c b/apps/screens.c
index e3a73f3de2..fe851ad04c 100644
--- a/apps/screens.c
+++ b/apps/screens.c
@@ -582,9 +582,8 @@ static const char * id3_get_or_speak_info(int selected_item, void* data,
if (!id3->comment)
return NULL;
- strmemccpy(buffer, id3->comment, buffer_len);
- val=buffer;
+ val = id3->comment;
if(say_it && val)
talk_spell(val, true);
break;
@@ -659,9 +658,7 @@ static const char * id3_get_or_speak_info(int selected_item, void* data,
if (id3->codectype == AFMT_UNKNOWN && info->track_ct > 1)
return NULL;
- strmemccpy(buffer, get_codec_string(id3->codectype), buffer_len);
-
- val=buffer;
+ val = (char*) get_codec_string(id3->codectype);
if(say_it)
talk_spell(val, true);
break;