diff options
| author | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-04 14:23:04 +0100 |
|---|---|---|
| committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-11-23 10:07:29 -0500 |
| commit | 3815ef805010486c091c1c38221dcbf898590a8d (patch) | |
| tree | ed7e6f9aff20660999166b193b851063e0f28693 /apps/gui/skin_engine/wps_internals.h | |
| parent | 830436a282e49caea4bd15bfa8c133b4c5d422dd (diff) | |
| download | rockbox-3815ef805010486c091c1c38221dcbf898590a8d.tar.gz rockbox-3815ef805010486c091c1c38221dcbf898590a8d.zip | |
skin engine: Remove albumart viewport field
The viewport field in albumart is unnecessary, but for a different
reason than eg. the progressbar was. The skin engine draws images
by going over a global list of images shared between all viewports.
Prior to drawing a viewport, every image is marked "not displayed."
When an image display tag is encountered during rendering this mark
is set to the index of the subimage to be displayed.
The albumart is handled similarily, by setting a handle to -1 and
then updating it when the %Cd tag is encountered. The albumart is
not drawn unless the handle is set to >= 0 by the %Cd tag. So we
don't need to track or check viewports at all, because only the
viewport that contains the %Cd tag will ever draw the albumart.
Change-Id: Ibc0233d168012759325d3c16dc317de9ad3dcf6c
Diffstat (limited to 'apps/gui/skin_engine/wps_internals.h')
| -rw-r--r-- | apps/gui/skin_engine/wps_internals.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/apps/gui/skin_engine/wps_internals.h b/apps/gui/skin_engine/wps_internals.h index f2988512d9..6a5d3c27f9 100644 --- a/apps/gui/skin_engine/wps_internals.h +++ b/apps/gui/skin_engine/wps_internals.h @@ -272,7 +272,6 @@ struct skin_albumart { unsigned char yalign; /* WPS_ALBUMART_ALIGN_TOP, _CENTER, _BOTTOM */ unsigned char state; /* WPS_ALBUMART_NONE, _CHECK, _LOAD */ - OFFSETTYPE(struct viewport *) vp; int draw_handle; }; #endif |