diff options
| author | Christian Soffke <christian.soffke@gmail.com> | 2021-11-19 05:11:13 +0100 |
|---|---|---|
| committer | William Wilgus <me.theuser@yahoo.com> | 2022-01-22 08:29:40 -0500 |
| commit | bc5a6385949c9f0a17173f3512aa9a6db9175803 (patch) | |
| tree | b7b2990a4a43d6027f19cbe32a22cd2f0774d0b1 /apps/menus | |
| parent | aafe2dd2d14e1ce88b5c9c819277ca0bc98af6e5 (diff) | |
| download | rockbox-bc5a6385949c9f0a17173f3512aa9a6db9175803.tar.gz rockbox-bc5a6385949c9f0a17173f3512aa9a6db9175803.zip | |
Option to switch off album art or to prefer file over embedded
Large embedded album art can cause pauses during
playback or when skipping between tracks, especially
on older devices, but embedded art is currently loaded
even when separately stored smaller image files would be
available.
A workaround is to remove large album art from the
metadata of files.
This now adds a setting to either turn off loading of
album art completely, or to prefer loading the album art
from a separate image file and thus ignore the embedded
versions.
Change-Id: I22fb581abf56072e35e6c29d72e553747ec1a96a
Diffstat (limited to 'apps/menus')
| -rw-r--r-- | apps/menus/playback_menu.c | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/apps/menus/playback_menu.c b/apps/menus/playback_menu.c index 5f9479fae3..fe319d6027 100644 --- a/apps/menus/playback_menu.c +++ b/apps/menus/playback_menu.c @@ -201,6 +201,28 @@ MENUITEM_SETTING(pause_rewind, &global_settings.pause_rewind, NULL); MENUITEM_SETTING(play_frequency, &global_settings.play_frequency, playback_callback); #endif +#ifdef HAVE_ALBUMART +static int albumart_callback(int action, + const struct menu_item_ex *this_item, + struct gui_synclist *this_list) +{ + (void)this_item; + (void)this_list; + static int initial_aa_setting; + switch (action) + { + case ACTION_ENTER_MENUITEM: + initial_aa_setting = global_settings.album_art; + break; + case ACTION_EXIT_MENUITEM: /* on exit */ + if (initial_aa_setting != global_settings.album_art) + set_albumart_mode(global_settings.album_art); + } + return action; +} +MENUITEM_SETTING(album_art, &global_settings.album_art, + albumart_callback); +#endif MAKE_MENU(playback_settings,ID2P(LANG_PLAYBACK),0, Icon_Playback_menu, @@ -231,6 +253,9 @@ MAKE_MENU(playback_settings,ID2P(LANG_PLAYBACK),0, #ifdef HAVE_PLAY_FREQ ,&play_frequency #endif +#ifdef HAVE_ALBUMART + ,&album_art +#endif ); static int playback_callback(int action, |