diff options
| author | Frank Gevaerts <frank@gevaerts.be> | 2016-03-13 22:51:02 +0100 |
|---|---|---|
| committer | Frank Gevaerts <frank@gevaerts.be> | 2016-03-13 22:52:45 +0100 |
| commit | b58b9c26c94a7b5581188fb091a770d0b25a7c32 (patch) | |
| tree | b94b0a5e8b6d2145161532413706ac543a4a95dd /apps/plugins/goban | |
| parent | 2c7bb67302858f01b74ab73aafa71c095383bda3 (diff) | |
| download | rockbox-b58b9c26c94a7b5581188fb091a770d0b25a7c32.tar.gz rockbox-b58b9c26c94a7b5581188fb091a770d0b25a7c32.zip | |
Remove clearly broken error checking, as pointed out by newer gcc.
Note that the error checking is probably useful if done correctly,
but I have no way to test this, so just removing the offending code
is the only way forward. Thanks to the fairly creative bug, the code
did nothing at all anyway.
Change-Id: Ifeef57202f31e842ca1befa331f8b34e1c76757c
Diffstat (limited to 'apps/plugins/goban')
| -rw-r--r-- | apps/plugins/goban/sgf.c | 18 |
1 files changed, 1 insertions, 17 deletions
diff --git a/apps/plugins/goban/sgf.c b/apps/plugins/goban/sgf.c index 42d4da3365..49dd28ff93 100644 --- a/apps/plugins/goban/sgf.c +++ b/apps/plugins/goban/sgf.c @@ -1261,13 +1261,6 @@ read_comment_sgf (char *buffer, size_t buffer_size) return -1; } - if (!read_char_no_whitespace (unhandled_fd) == 'C' || - !read_char_no_whitespace (unhandled_fd) == '[') - { - DEBUGF ("comment prop points to incorrect place in unhandled_fd!!\n"); - return -1; - } - /* make output a string, the lazy way */ rb->memset (buffer, 0, buffer_size); ++bytes_read; @@ -1358,16 +1351,7 @@ write_comment_sgf (char *string) start_of_write_wcs: - if (overwriting) - { - if (!read_char_no_whitespace (unhandled_fd) == 'C' || - !read_char_no_whitespace (unhandled_fd) == '[') - { - DEBUGF ("non-comment while overwriting!!\n"); - return -1; - } - } - else + if (!overwriting) { start_of_comment = rb->lseek (unhandled_fd, 0, SEEK_END); |