diff options
| author | Amaury Pouly <amaury.pouly@gmail.com> | 2017-01-16 00:10:38 +0100 |
|---|---|---|
| committer | Gerrit Rockbox <gerrit@rockbox.org> | 2017-02-04 17:24:47 +0100 |
| commit | d7871914acd2ed77f43344e36e08944524a67d9e (patch) | |
| tree | 7bcef243d9b53c3703c305b8a5f9f8a8488eabfb /apps/plugins/goban | |
| parent | 1245c5fe61f6ca8e1980a33a8b8f7ea4322829fd (diff) | |
| download | rockbox-d7871914acd2ed77f43344e36e08944524a67d9e.tar.gz rockbox-d7871914acd2ed77f43344e36e08944524a67d9e.zip | |
Fix dangerous casts
On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is
not valid. In any case, one should use intptr_t and ptrdiff_t when casting
to integers. This commit attempts to fix all instances reported by GCC.
When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h
Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc
Diffstat (limited to 'apps/plugins/goban')
| -rw-r--r-- | apps/plugins/goban/util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/plugins/goban/util.c b/apps/plugins/goban/util.c index bb78316346..206606a4bb 100644 --- a/apps/plugins/goban/util.c +++ b/apps/plugins/goban/util.c @@ -73,7 +73,7 @@ void metadata_summary (void) void * align_buffer (void *buffer, size_t * buffer_size) { - unsigned int wasted = (-(long) buffer) & 3; + unsigned int wasted = (-(intptr_t) buffer) & 3; if (!buffer || !buffer_size) { @@ -88,7 +88,7 @@ align_buffer (void *buffer, size_t * buffer_size) *buffer_size -= wasted; - return (void *) (((char *) buffer) + wasted); + return PTR_ADD(buffer, wasted); } |