summaryrefslogtreecommitdiffstats
path: root/apps/plugins/mikmod
diff options
context:
space:
mode:
authorThomas Jarosch <tomj@simonv.com>2014-12-20 13:37:40 +0100
committerThomas Jarosch <tomj@simonv.com>2014-12-20 13:37:40 +0100
commitc54537a6639bc9ea495fac5e9ecb3ee7a699b484 (patch)
treea8955bdb176f46a043423e946964fabb0c9e4d7f /apps/plugins/mikmod
parentf8d9e9cb6c4cbec8a611f871de006608ad7a1dbd (diff)
downloadrockbox-c54537a6639bc9ea495fac5e9ecb3ee7a699b484.tar.gz
rockbox-c54537a6639bc9ea495fac5e9ecb3ee7a699b484.tar.bz2
rockbox-c54537a6639bc9ea495fac5e9ecb3ee7a699b484.zip
Prevent theoretical out-of-bounds access in STM_Load()
We should be safe since STM_Load() should never be called if STM_Test() fails. Still it's better safe than sorry. cppcheck reported: [rockbox/apps/plugins/mikmod/load_stm.c:302]: (error) Array 'STM_Version[3]' accessed at index 3, which is out of bounds. Change-Id: I914935fd108c492d013de24d17dcb9c227af6cd8
Diffstat (limited to 'apps/plugins/mikmod')
-rw-r--r--apps/plugins/mikmod/load_stm.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/apps/plugins/mikmod/load_stm.c b/apps/plugins/mikmod/load_stm.c
index b2537ab68f..994b0e5355 100644
--- a/apps/plugins/mikmod/load_stm.c
+++ b/apps/plugins/mikmod/load_stm.c
@@ -299,6 +299,8 @@ static int STM_Load(int curious)
/* set module variables */
for(t=0;t<STM_NTRACKERS;t++)
if(!memcmp(mh->trackername,STM_Signatures[t],8)) break;
+ if(t == STM_NTRACKERS)
+ return 0;
of.modtype = StrDup(STM_Version[t]);
of.songname = DupStr(mh->songname,20,1); /* make a cstr of songname */
of.numpat = mh->numpat;