summaryrefslogtreecommitdiffstats
path: root/apps/plugins/pictureflow
diff options
context:
space:
mode:
authorThomas Martitz <kugel@rockbox.org>2011-06-13 16:50:10 +0000
committerThomas Martitz <kugel@rockbox.org>2011-06-13 16:50:10 +0000
commit3b18158688415e311b2d5333cb4262912fb2a424 (patch)
tree7ccf0ea8f567cb8d882a3d2a94bfecc675192897 /apps/plugins/pictureflow
parentb843abef86dc44a5803299cf53c96864874185c2 (diff)
downloadrockbox-3b18158688415e311b2d5333cb4262912fb2a424.tar.gz
rockbox-3b18158688415e311b2d5333cb4262912fb2a424.tar.bz2
rockbox-3b18158688415e311b2d5333cb4262912fb2a424.zip
Fix FS#11387 - PictureFlow runs jerkily while playing music on Nano2G after the recent feature addition
The problem r26713 addressed was not caused by missing yields but by too high priority of the background loader thread. Undoing the yield() change and decreasing the priority fixes the audio drop as well but doesn't cause jerkiness. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30000 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins/pictureflow')
-rw-r--r--apps/plugins/pictureflow/pictureflow.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/apps/plugins/pictureflow/pictureflow.c b/apps/plugins/pictureflow/pictureflow.c
index d26e6ead60..e93f2d2951 100644
--- a/apps/plugins/pictureflow/pictureflow.c
+++ b/apps/plugins/pictureflow/pictureflow.c
@@ -1330,8 +1330,7 @@ bool create_pf_thread(void)
sizeof(thread_stack),
0,
"Picture load thread"
- IF_PRIO(, MAX(PRIORITY_USER_INTERFACE / 2,
- PRIORITY_REALTIME + 1))
+ IF_PRIO(, PRIORITY_BUFFERING)
IF_COP(, CPU)
)
) == 0) {
@@ -1928,10 +1927,6 @@ void render_slide(struct slide_data *slide, const int alpha)
pixel -= PIXELSTEP_Y;
}
}
- rb->yield(); /* allow audio to play when fast scrolling */
- bmp = surface(slide->slide_index); /* resync surface due to yield */
- src = (pix_t*)(sizeof(struct dim) + (char *)bmp);
- ptr = &src[column * bmp->height];
p = (bmp->height-DISPLAY_OFFS) * PFREAL_ONE;
plim = MIN(sh * PFREAL_ONE, p + (LCD_HEIGHT/2) * dy);
int plim2 = MIN(MIN(sh + REFLECT_HEIGHT, sh * 2) * PFREAL_ONE,