diff options
author | Thom Johansen <thomj@rockbox.org> | 2007-09-19 10:40:55 +0000 |
---|---|---|
committer | Thom Johansen <thomj@rockbox.org> | 2007-09-19 10:40:55 +0000 |
commit | 294ec1d110178f30894721d5cda14c246333954d (patch) | |
tree | 2e31dc287557007939b3b5abf4493fa02946b6c5 /apps/plugins | |
parent | 547cffb90bffacc7f22e6661c61ccad830ce2c91 (diff) | |
download | rockbox-294ec1d110178f30894721d5cda14c246333954d.tar.gz rockbox-294ec1d110178f30894721d5cda14c246333954d.zip |
Remove the ID3 tag version priority setting on the grounds of it being pretty pointless. ID3v2 tags are superior to ID3v1 tags, and needs less seeking around to find.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14750 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins')
-rw-r--r-- | apps/plugins/properties.c | 4 | ||||
-rw-r--r-- | apps/plugins/test_codec.c | 3 | ||||
-rw-r--r-- | apps/plugins/vbrfix.c | 2 |
3 files changed, 4 insertions, 5 deletions
diff --git a/apps/plugins/properties.c b/apps/plugins/properties.c index ca18d49f50..0811b00ed3 100644 --- a/apps/plugins/properties.c +++ b/apps/plugins/properties.c @@ -100,9 +100,9 @@ static bool file_properties(char* selected_file) #if (CONFIG_CODEC == SWCODEC) int fd = rb->open(selected_file, O_RDONLY); if (fd >= 0 && - rb->get_metadata(&id3, fd, selected_file, false)) + rb->get_metadata(&id3, fd, selected_file)) #else - if (!rb->mp3info(&id3, selected_file, false)) + if (!rb->mp3info(&id3, selected_file)) #endif { rb->snprintf(str_artist, sizeof str_artist, diff --git a/apps/plugins/test_codec.c b/apps/plugins/test_codec.c index 4346a23304..94be6b7397 100644 --- a/apps/plugins/test_codec.c +++ b/apps/plugins/test_codec.c @@ -537,8 +537,7 @@ static enum plugin_status test_track(char* filename) /* Clear the id3 struct */ rb->memset(&track.id3, 0, sizeof(struct mp3entry)); - if (!rb->get_metadata(&(track.id3), fd, filename, - rb->global_settings->id3_v1_first)) + if (!rb->get_metadata(&(track.id3), fd, filename)) { log_text("Cannot read metadata",true); return PLUGIN_ERROR; diff --git a/apps/plugins/vbrfix.c b/apps/plugins/vbrfix.c index 42353981a2..823e166b39 100644 --- a/apps/plugins/vbrfix.c +++ b/apps/plugins/vbrfix.c @@ -143,7 +143,7 @@ static bool vbr_fix(char *selected_file) xingupdate(0); - rc = rb->mp3info(&entry, selected_file, false); + rc = rb->mp3info(&entry, selected_file); if(rc < 0) { fileerror(rc); return true; |