summaryrefslogtreecommitdiffstats
path: root/apps/settings_list.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2022-09-19 11:38:09 +0100
committerAidan MacDonald <amachronic@protonmail.com>2022-10-05 10:22:55 -0400
commitead172c05d57568d201709c5fac77cbb8982bbd0 (patch)
tree10ab4de5bafb8092d1b1a3cd27ca8680cf650def /apps/settings_list.c
parentfe6aa21e9eb88f49005863efd2003d0982920048 (diff)
downloadrockbox-ead172c05d.tar.gz
rockbox-ead172c05d.zip
gui: Remove redundant copies of list scrolling settings
gui_list_screen_scroll_step() and gui_list_screen_scroll_out_of_view() just copy the global setting into a local static variable. Since they don't do anything special when the setting changes it's simpler to use the global setting directly. Change-Id: Ib6a7bf4e09b6dabbc1597cf28ddbafc0bc857526
Diffstat (limited to 'apps/settings_list.c')
-rw-r--r--apps/settings_list.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/apps/settings_list.c b/apps/settings_list.c
index 699afb92fd..6d01f5c6fc 100644
--- a/apps/settings_list.c
+++ b/apps/settings_list.c
@@ -1227,13 +1227,11 @@ const struct settings_list settings[] = {
lcd_remote_bidir_scroll),
#endif
OFFON_SETTING(0, offset_out_of_view, LANG_SCREEN_SCROLL_VIEW,
- false, "Screen Scrolls Out Of View",
- gui_list_screen_scroll_out_of_view),
+ false, "Screen Scrolls Out Of View", NULL),
INT_SETTING(F_PADTITLE, scroll_step, LANG_SCROLL_STEP, 6, "scroll step",
UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, lcd_scroll_step),
INT_SETTING(F_PADTITLE, screen_scroll_step, LANG_SCREEN_SCROLL_STEP, 16,
- "screen scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL,
- gui_list_screen_scroll_step),
+ "screen scroll step", UNIT_PIXEL, 1, LCD_WIDTH, 1, NULL, NULL, NULL),
OFFON_SETTING(0,scroll_paginated,LANG_SCROLL_PAGINATED,
false,"scroll paginated",NULL),
OFFON_SETTING(0,list_wraparound,LANG_LIST_WRAPAROUND,