summaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorMagnus Holmgren <magnushol@gmail.com>2009-06-30 21:32:38 +0000
committerMagnus Holmgren <magnushol@gmail.com>2009-06-30 21:32:38 +0000
commita538b89060bee76d5c6a078883748cac0a720ea7 (patch)
tree56592283fe938c61bbeed1f30493426568de0c6d /apps
parent02bbf55d9d08fcb91803ee246486c5661e372aec (diff)
downloadrockbox-a538b89060bee76d5c6a078883748cac0a720ea7.tar.gz
rockbox-a538b89060bee76d5c6a078883748cac0a720ea7.zip
Second attempt at fixing FS#10396. Turns out that gcc for coldfire choose to inline a function with a big appetite for stack. The previous fix improved things a bit, but not nearly enough.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21580 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps')
-rw-r--r--apps/tagcache.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/apps/tagcache.c b/apps/tagcache.c
index 8448c02db1..391d8c6f81 100644
--- a/apps/tagcache.c
+++ b/apps/tagcache.c
@@ -1653,12 +1653,16 @@ static int check_if_empty(char **tag)
entry.tag_offset[tag] = offset; \
entry.tag_length[tag] = check_if_empty(data); \
offset += entry.tag_length[tag]
-
-static void add_tagcache(char *path, unsigned long mtime
+/* GCC 3.4.6 for Coldfire can choose to inline this function. Not a good
+ * idea, as it uses lots of stack and is called from a recursive function
+ * (check_dir).
+ */
+static void __attribute__ ((noinline)) add_tagcache(char *path,
+ unsigned long mtime
#if defined(HAVE_TC_RAMCACHE) && defined(HAVE_DIRCACHE)
- ,const struct dirent *dc
+ ,const struct dirent *dc
#endif
- )
+ )
{
struct mp3entry id3;
struct temp_file_entry entry;