diff options
author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
---|---|---|
committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
tree | 550830e9af67f47e3eb87587770b25d22110f57a /firmware/export/si4700.h | |
parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
download | rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.tar.gz rockbox-fc9695eb47732e1c189e2f033dbd55e5c346e8c4.zip |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'firmware/export/si4700.h')
-rw-r--r-- | firmware/export/si4700.h | 28 |
1 files changed, 13 insertions, 15 deletions
diff --git a/firmware/export/si4700.h b/firmware/export/si4700.h index 6b7992c025..bd75bf0817 100644 --- a/firmware/export/si4700.h +++ b/firmware/export/si4700.h @@ -35,36 +35,34 @@ struct si4700_dbg_info }; bool si4700_detect(void); -void si4700_init(void); +void si4700_init(void) INIT_ATTR; int si4700_set(int setting, int value); int si4700_get(int setting); void si4700_dbg_info(struct si4700_dbg_info *nfo); /* For interrupt-based mono/stereo indicator */ bool si4700_st(void); +#ifdef HAVE_RDS_CAP /** RDS support **/ -void si4700_rds_init(void); + +void si4700_rds_init(void) INIT_ATTR; /* Radio is fully powered up or about to be powered down */ void si4700_rds_powerup(bool on); -#ifdef RDS_ISR_PROCESSING + +#if (CONFIG_RDS & RDS_CFG_ISR) /* Read raw RDS info for processing - asynchronously */ -void si4700_read_raw_async(int count); /* implemented by target */ -void si4700_rds_read_raw_async(void); -void si4700_rds_read_raw_async_complete(unsigned char *regbuf, - uint16_t data[4]); -#else /* ndef RDS_ISR_PROCESSING */ +void si4700_rds_read_raw_async(unsigned char *buf, int count); /* implemented by target */ +void si4700_rds_interrupt(void); +#endif /* (CONFIG_RDS & RDS_CFG_ISR) */ + /* Read raw RDS info for processing */ -bool si4700_rds_read_raw(uint16_t data[4]); -#endif /* RDS_ISR_PROCESSING */ -/* Obtain specified string */ -char* si4700_get_rds_info(int setting); -/* Set the event flag */ -void si4700_rds_set_event(void); +void si4700_rds_process(void); + +#endif /* HAVE_RDS_CAP */ #ifndef CONFIG_TUNER_MULTI #define tuner_set si4700_set #define tuner_get si4700_get -#define tuner_get_rds_info si4700_get_rds_info #endif #endif /* _SI4700_H_ */ |