summaryrefslogtreecommitdiffstats
path: root/firmware/target/arm/imx233/creative-zen
diff options
context:
space:
mode:
authorAmaury Pouly <amaury.pouly@gmail.com>2013-11-11 02:01:05 +0000
committerAmaury Pouly <amaury.pouly@gmail.com>2013-11-11 02:01:05 +0000
commita54c4ab7d42c9ef90a5cf10581d072f33968a6c5 (patch)
tree87814a0a7efcbd79698f1a4ca8dfd85cb7b85b90 /firmware/target/arm/imx233/creative-zen
parent7bbdcc1c3bf87c24a5b52716471a7b6c97305813 (diff)
downloadrockbox-a54c4ab7d42c9ef90a5cf10581d072f33968a6c5.tar.gz
rockbox-a54c4ab7d42c9ef90a5cf10581d072f33968a6c5.zip
zen/zenxfi: correctly implement partial redraw
Although there is no difference in the cost of a full or partial update, it is preferable that the semantic of lcd_update_rect() be correct. Change-Id: I8a168388b98e0dbd7237729b7fd8a62fa1885be1
Diffstat (limited to 'firmware/target/arm/imx233/creative-zen')
-rw-r--r--firmware/target/arm/imx233/creative-zen/lcd-zen.c16
1 files changed, 9 insertions, 7 deletions
diff --git a/firmware/target/arm/imx233/creative-zen/lcd-zen.c b/firmware/target/arm/imx233/creative-zen/lcd-zen.c
index fd7d3e0205..22d643c778 100644
--- a/firmware/target/arm/imx233/creative-zen/lcd-zen.c
+++ b/firmware/target/arm/imx233/creative-zen/lcd-zen.c
@@ -339,13 +339,15 @@ void lcd_update_rect(int x, int y, int w, int h)
if(!lcd_on)
return;
#endif
- uint8_t *p = FRAME;
- for(int y = 0; y < LCD_HEIGHT; y++)
- for(int x = 0; x < LCD_WIDTH; x++)
+ for(int yy = y; yy < y + h; yy++)
+ {
+ uint16_t *pix = FBADDR(x, yy);
+ uint8_t *p = 3 * (yy * LCD_WIDTH + x) + (uint8_t *)FRAME;
+ for(int xx = 0; xx < w; xx++, pix++)
{
- uint16_t pix = *FBADDR(x,y);
- *p++ = RGB_UNPACK_RED(pix);
- *p++ = RGB_UNPACK_GREEN(pix);
- *p++ = RGB_UNPACK_BLUE(pix);
+ *p++ = RGB_UNPACK_RED(*pix);
+ *p++ = RGB_UNPACK_GREEN(*pix);
+ *p++ = RGB_UNPACK_BLUE(*pix);
}
+ }
}