path: root/firmware/target/arm/imx233/pcm-imx233.c
diff options
authorMichael Sevakis <>2012-02-23 08:14:46 -0500
committerMichael Sevakis <>2012-03-03 07:23:38 +0100
commit286a4c5caa1945c8d1cb365a3d90fb09d5700cb2 (patch)
tree4835f46d16ec78d035ec9f49333079fe618384c1 /firmware/target/arm/imx233/pcm-imx233.c
parent3f82f3aca14eb954e55f761721ffdd2684f0e812 (diff)
Revise the PCM callback system after adding multichannel audio.
Additional status callback is added to pcm_play/rec_data instead of using a special function to set it. Status includes DMA error reporting to the status callback. Playback and recording callback become more alike except playback uses "const void **addr" (because the data should not be altered) and recording uses "void **addr". "const" is put in place throughout where appropriate. Most changes are fairly trivial. One that should be checked in particular because it isn't so much is telechips, if anyone cares to bother. PP5002 is not so trivial either but that tested as working. Change-Id: I4928d69b3b3be7fb93e259f81635232df9bd1df2 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested-by: Michael Sevakis <>
Diffstat (limited to 'firmware/target/arm/imx233/pcm-imx233.c')
1 files changed, 4 insertions, 5 deletions
diff --git a/firmware/target/arm/imx233/pcm-imx233.c b/firmware/target/arm/imx233/pcm-imx233.c
index c8b79b3875..c4c512eed6 100644
--- a/firmware/target/arm/imx233/pcm-imx233.c
+++ b/firmware/target/arm/imx233/pcm-imx233.c
@@ -49,15 +49,13 @@ static void play(const void *addr, size_t size)
void INT_DAC_DMA(void)
- void *start;
+ const void *start;
size_t size;
- pcm_play_get_more_callback(&start, &size);
- if(size != 0)
+ if (pcm_play_dma_complete_callback(PCM_DMAST_OK, &start, &size))
play(start, size);
- pcm_play_dma_started_callback();
+ pcm_play_dma_status_callback(PCM_DMAST_STARTED);
@@ -65,6 +63,7 @@ void INT_DAC_DMA(void)
void INT_DAC_ERROR(void)
+ /* TODO: Inform of error through pcm_play_dma_complete_callback */
void pcm_play_lock(void)