summaryrefslogtreecommitdiffstats
path: root/firmware
diff options
context:
space:
mode:
authorRafaël Carré <rafael.carre@gmail.com>2009-09-30 18:54:42 +0000
committerRafaël Carré <rafael.carre@gmail.com>2009-09-30 18:54:42 +0000
commit6bd92a74d358632155bd7cb05ee3ae44973bbc49 (patch)
tree5bddacac01751f9779ea8df0cbd37cc9beaed137 /firmware
parent619ffcb0e60a21aaed3500f0ef0cd606c47225f1 (diff)
downloadrockbox-6bd92a74d358632155bd7cb05ee3ae44973bbc49.tar.gz
rockbox-6bd92a74d358632155bd7cb05ee3ae44973bbc49.tar.bz2
rockbox-6bd92a74d358632155bd7cb05ee3ae44973bbc49.zip
Fix "lcd driver speed up" on e200v2
Flyspray: FS#10272 Author: Michael Chicoine git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22859 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware')
-rw-r--r--firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c20
1 files changed, 11 insertions, 9 deletions
diff --git a/firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c b/firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c
index 35f06eae12..a063ae4db8 100644
--- a/firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c
+++ b/firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c
@@ -98,12 +98,11 @@ static unsigned short r_entry_mode = R_ENTRY_MODE_HORZ_NORMAL;
#define R_DISP_CONTROL_REV 0x0000
static unsigned short r_disp_control_rev = R_DISP_CONTROL_NORMAL;
-/* TODO: Implement this function */
-static void lcd_delay(int x)
+static inline void lcd_delay(int x)
{
- /* This is just arbitrary - the OF does something more complex */
- x *= 1024;
- while (x--);
+ do {
+ asm volatile ("nop\n");
+ } while (x--);
}
/* DBOP initialisation, do what OF does */
@@ -130,10 +129,13 @@ static void ams3525_dbop_init(void)
/* TODO: The OF calls some other functions here, but maybe not important */
}
-#define lcd_write_single_data16(value) do {\
- DBOP_CTRL &= ~(1<<14|1<<13); \
- DBOP_DOUT16 = (fb_data)(value); \
- } while(0)
+static void lcd_write_single_data16(unsigned short value)
+{
+ DBOP_CTRL &= ~(1<<14|1<<13);
+ lcd_delay(10);
+ DBOP_DOUT16 = value;
+ while ((DBOP_STAT & (1<<10)) == 0);
+}
static void lcd_write_cmd(int cmd)
{