summaryrefslogtreecommitdiffstats
path: root/lib/unwarminder
diff options
context:
space:
mode:
authorThomas Jarosch <tomj@simonv.com>2012-02-29 19:08:43 +0100
committerThomas Jarosch <tomj@simonv.com>2012-03-02 18:29:09 +0100
commit9476883d2d7e89d81719daf81664f565cbbc883c (patch)
tree437365c261acc715cd638867a081847e3ff303e5 /lib/unwarminder
parent5bfbc641512690cad402ebd354cd303bb77e7c46 (diff)
downloadrockbox-9476883d2d7e89d81719daf81664f565cbbc883c.tar.gz
rockbox-9476883d2d7e89d81719daf81664f565cbbc883c.tar.bz2
rockbox-9476883d2d7e89d81719daf81664f565cbbc883c.zip
Fix sanity check in UnwStartThumb() using the wrong register
cppcheck reported: [lib/unwarminder/unwarm_thumb.c:399] -> [lib/unwarminder/unwarm_thumb.c:399]: (style) Same expression on both sides of '&&'. Patch will also be sent to the upstream project. Change-Id: I57033f290135f4dc09ac7e9b07c31461bc5b471a Reviewed-on: http://gerrit.rockbox.org/157 Reviewed-by: Thomas Jarosch <tomj@simonv.com>
Diffstat (limited to 'lib/unwarminder')
-rw-r--r--lib/unwarminder/unwarm_thumb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/unwarminder/unwarm_thumb.c b/lib/unwarminder/unwarm_thumb.c
index 09b3c9e54b..027d951f33 100644
--- a/lib/unwarminder/unwarm_thumb.c
+++ b/lib/unwarminder/unwarm_thumb.c
@@ -396,7 +396,7 @@ UnwResult UnwStartThumb(UnwState * const state)
case 12: /* ORR */
case 13: /* MUL */
case 14: /* BIC */
- if(M_IsOriginValid(state->regData[rs].o) && M_IsOriginValid(state->regData[rs].o))
+ if(M_IsOriginValid(state->regData[rd].o) && M_IsOriginValid(state->regData[rs].o))
{
state->regData[rd].o = state->regData[rs].o;
state->regData[rd].o |= REG_VAL_ARITHMETIC;