summaryrefslogtreecommitdiffstats
path: root/firmware/export/eros_qn_codec.h
diff options
context:
space:
mode:
Diffstat (limited to 'firmware/export/eros_qn_codec.h')
-rw-r--r--firmware/export/eros_qn_codec.h10
1 files changed, 8 insertions, 2 deletions
diff --git a/firmware/export/eros_qn_codec.h b/firmware/export/eros_qn_codec.h
index ae04c66799..851ab63362 100644
--- a/firmware/export/eros_qn_codec.h
+++ b/firmware/export/eros_qn_codec.h
@@ -23,10 +23,16 @@
#ifndef _EROS_QN_CODEC_H
#define _EROS_QN_CODEC_H
+/*
+ * Note: Maximum volume is set one step below unity in order to
+ * avoid overflowing pcm samples due to our DC Offset.
+ *
+ * The DAC's output is hot enough this should not be an issue.
+ */
#define PCM5102A_VOLUME_MIN -740
-#define PCM5102A_VOLUME_MAX 0
+#define PCM5102A_VOLUME_MAX -20
-/* a small DC offset appears to prevent play/pause clicking */
+/* a small DC offset prevents play/pause clicking due to the DAC auto-muting */
#define PCM_DC_OFFSET_VALUE -1
AUDIOHW_SETTING(VOLUME, "dB", 0, 2, PCM5102A_VOLUME_MIN/10, PCM5102A_VOLUME_MAX/10, 0)