summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-07-25mpegplayer: Fix aliasing rules violation on multi-core targetsSolomon Peachy1-3/+5
As the PP series has no sense of cache coherency between its multiple cores, we need to ensure the vo_data structure does not share cachelines with anything else. This was previously done by defining a uint8_t array and trying to access it via typecasting hell, triggering a large pile of aliasing violation warnings on newer toolchains and/or higher optimization levels. Instead of violating the C spec in an undefined-behaviour-sort-of-way, create a union of the right size and alignment, and make one of its members the structure we care about. Voila, everyone is happy. Change-Id: Iad78f8132225437cd4aa10e6e5f6ae58ba996c19
2020-07-25More fixes for English(US)Solomon Peachy1-4/+4
(The translate website screwed up a bit) Change-Id: I293c939b858121f6d82dde037bb5ff1cbcff5d6c
2020-07-24Update French translation (Stéphane Moutard-Martin)Solomon Peachy3-468/+2970
Change-Id: Ibe247553965024a000749386a95e73dcc18c493e
2020-07-25Update English(US) translationSolomon Peachy1-479/+10
Change-Id: Ifb078fa52368b4fb2bff2f00b28ae462a098a881
2020-07-24Plugin Api update with added functionsWilliam Wilgus3-1/+11
Change-Id: I3c48c999da240f68f4960d2e137c613b224beb5c
2020-07-24plugins: HAVE_BACKLIGHT in the test pluginsSolomon Peachy5-8/+22
Change-Id: I97d17805ac7d37f10da6a29684102db97448e653
2020-07-24plugins: More HAVE_BACKLIGHT cleanupSolomon Peachy30-44/+149
Change-Id: I70cf700f5bc3d4375c025efa62ef40fd2bd70293
2020-07-24peakmeter: Fix warning on some hosted targetsSolomon Peachy1-3/+8
Change-Id: Ieae0b08a2f747955ad3e392fbff90884dc4265ef
2020-07-24plugins: Fix the builds for targets lacking HAVE_BACKLIGHTSolomon Peachy7-10/+40
Change-Id: Ifdb1501834b7ea63ca6f731bbd6414305d7e0001
2020-07-24peakmeter: Fix simulator build breakage introduced in 8cb55546Solomon Peachy1-2/+0
Change-Id: I86c327cf7053e71df7550b6d0673262035f95978
2020-07-24plugins: Remove six API functions with no usersSolomon Peachy2-19/+2
statusbars, gui_syncstatusbar_draw(), and set_time() mp3_play_data(), mp3_play_pause(), mp3_play_stop() [mp3_is_playing() is still used by imageviewer] (followup to the sh/archos exorcism..) Change-Id: I06a1d981ffc86b8073fcfa2380a393a07347ab3b
2020-07-24[4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice.Solomon Peachy240-1761/+290
Note: I left behind lcd_bitmap in features.txt, because removing it would require considerable work in the manual and the translations. Change-Id: Ia8ca7761f610d9332a0d22a7d189775fb15ec88a
2020-07-24[3/4] Completely remove HWCODEC supportSolomon Peachy207-5594/+322
'swcodec' is now always set (and recording_swcodec for recording-capable units) in feature.txt so the manual and language strings don't need to all be fixed up. Change-Id: Ib2c9d5d157af8d33653e2d4b4a12881b9aa6ddb0
2020-07-24[2/4] get rid of HAVE_LCD_CHARCELLSSolomon Peachy77-6008/+121
HAVE_LCD_BITMAP is now redundant. lcd_bitmap is always-on in features.txt so manual and lang strings don't have to change Change-Id: I08eeb20de48099ffc2dc23782711af368c2ec794
2020-07-24[1/4] Remove SH support and all archos targetsSolomon Peachy384-43226/+649
This removes all code specific to SH targets Change-Id: I7980523785d2596e65c06430f4638eec74a06061
2020-07-24Slovak language update (From Peter Lecký)archos_retiredSolomon Peachy1-0/+99
Change-Id: Icf80eb628cdc0a4ab6644c05104c0893b45d217f
2020-07-24talk: Force-shutdown the voice system before loading a new voiceSolomon Peachy1-0/+3
Otherwise we might actually be talking when we try to switch, or otherwise trash the state of the running talk thread, leading to memory corruption or an outright crash (This fixes a panic observed on the xDuoo X3) Change-Id: I78e4232085c5c160c9ee4f18167dad8dad2b9287
2020-07-22bootloader: Consolidate xDuoo X3ii/X20 and AGPTek Rocker bootloadersSolomon Peachy3-581/+50
Bonus changes: * boot mode selection stored on SD card Change-Id: I225a06d149ae71c1882f632c30d0fe4ab5308a74
2020-07-22keyboard add ability to specify temporary custom layoutsWilliam Wilgus37-69/+173
rb core allows you to load custom keyboard layouts this patch adds the ability to load a keyboard layout in a buffer the custom layout is temporary and does not overwrite the current layout use like so: unsigned short kbd[64]; unsigned short *kbd_p = kbd; if (!kbd_create_layout("ABCD1234\n", kbd, sizeof(kbd))) kbd_p = NULL; rb->kbd_input(buf,sizeof(buf), kbd_p); Change-Id: I7be2bd4a1b4797a147fa70228a9749dc56ac052a
2020-07-21build: Tweaks to better support non-English as primary languageSolomon Peachy3-7/+6
* get rid of $(LANGUAGE) in top-level makefile (and configure script) * un-hardcode English-as-primary-language in a couple more places * allow DEFAULT_VOICE_LANG to be overriden To actually change the primary from English, one must change: * $english in voice.pl * hardcoded 'english' in rbutil * $ENGLISH in apps/lang/lang.make * DEFAULT_VOICE_LANG in apps/talk.c * configure script (default prompt) Of course, if one wants to change the default UI language, it's simpler to change the default language setting variable at compile time, or perhaps by adding a configuration file with the desired value into the .rockbox directory when the .zip is assembled. Change-Id: If5cf76019d416e838628a2eccd4ec7d6cbaeeb74
2020-07-21genlang: More voice-related fixes.Solomon Peachy3-50/+22
* Use consistent ID numbering * Use consistent logic for voicelist and voicebin files * Fix situations where English <-> English would fail in strange ways * Delete leftover tmpfile. * Off-by-one error in voice validation code * Off-by-one error in voicelist generation Change-Id: Ib3cea2c6612138b1cbe614dacbe51000199cc9ad
2020-07-20Fix the sea of red introduced in bf546fbSolomon Peachy1-1/+2
Change-Id: Ic158771d8dae6b587e0f567e7a6bb005b5e2ac50
2020-07-21Run-time validation of INT settings.Solomon Peachy1-1/+7
Check against min/max/step parameters Many places this value is used as an index into an array; this will help prevent array overflows and undefined/undesireable behavior. Some fields accept arbitary values, continue to accept those. Change-Id: Idbb5a17b7ceae5500660987703e2d6c16e920c92
2020-07-20rbutil: Fix the X3ii's USB VID/PIDSolomon Peachy1-1/+1
Change-Id: I009b19b922874b9cce04da3d2cdd7bd142510dc2
2020-07-20rbutil: Add support for the xDuoo X3, X3ii, X20, and AGPTek Rocker.Solomon Peachy5-2/+296
* All include full bootloader installation! * X20 lack USB VID/PIDs so cannot be autodetected. * Benjie T6 (variant/OEM of the Rocker) USB VID/PID unknown. Change-Id: Ia823de072c83506d36410ec436be15a0caf97151
2020-07-20bspatch: Fix compiling on macOS.Dominik Riebeling1-0/+1
u_char is a nonstandard type. On macOS this requires to explicitly include sys/types.h. Change-Id: I929ceafc12c7cbdcc96e85cdd05cce27d8aa6795
2020-07-20menu.c fix redraw bugWilliam Wilgus1-5/+5
fix redraw bug added with c39f95465 Change-Id: I9ce232d4b760f20edb6f8274e090d2fd67c8bd78
2020-07-19Fix the yellow in the player build from c39f95465Solomon Peachy1-1/+4
Change-Id: Iae3a8f4eccd3708b41d43da6e12a3199b1d657c6
2020-07-19Fix more of the red from c39f95465Solomon Peachy1-2/+2
Change-Id: I8c9510774803f7164f7a003575711f3dd980223c
2020-07-19menus: Fix some of the red from c39f95465Solomon Peachy1-1/+1
Change-Id: Ic22123a83bf119605c8ddf686b6a8e21f9555c6a
2020-07-19do_menu pass internal synclist reference to callbackWilliam Wilgus39-110/+343
keep running into the rigid nature of do_menu it isn't too bad when you don't need voice but once you do the fun awaits do_menu likes to talk on menu enter which is in a loop when you use do_menu I would like to move the processing to the callback TOO BAD you only get an action and the menu_item_ex struct you sent it when calling the function Change-Id: Iaefd0cc133435d675b7dd27a558c504d6ccb327a
2020-07-19gitignore: We don't care about files ending in '~'Solomon Peachy1-0/+1
Change-Id: I0ed8ae6caaba0b2f04f55b08cb54abc358e9ce0d
2020-07-19rbutil: Add in missing voicefile languagesSolomon Peachy1-4/+8
Change-Id: I6b38bc7ba1c9dc6f399297142d007fcd7736eb36
2020-07-19rbutil: Support 'espeak-ng' and 'mimic' TTS enginesSolomon Peachy4-0/+92
Change-Id: Ibf6e46254f42b28800351fdb303539b2ec13d422
2020-07-19voice: Allow use of an existing (textual) voiceids fileSolomon Peachy1-31/+57
If it's present, we don't need to generate one, which means we don't need to know the target name and features list. The next step is to accept the binary variant that rbutil uses so we can generate a complete voice file on the cmdline. Change-Id: I1a355f985e6af46b11610de781996000110ae9de
2020-07-16storage: Clean up storage_xxxx macros when STORAGE_MULTI is not setSolomon Peachy3-19/+20
Change-Id: I1652eac1743f4b8b84da08ea5a6d04ac7e17e21d
2020-07-16statusbar: explicitly #include <button.h>Solomon Peachy1-0/+1
This header relies on stuff that might get defined in button.h, and was reliant upon being implicitly included. The last thing we want is a struct to change layout underneath us! Change-Id: If96451bc5e2219031a592ab82c56045188dbe645
2020-07-15Add support for ID3 tags embedded in AIFF filesMoshe Piekarski3-5/+43
Change-Id: I15eb50b6ba1c26052f08e01861f47faede3b9b3b
2020-07-15imx233: rtc: Explicitly clear the soft reset bit when initializingSolomon Peachy1-0/+2
If we come up and the RTC is in a reset state, we need to release that before trying to initialze anything else. (See IMX23RM 23.8.1 and 39.3.10) Change-Id: I1820ab771ba81f7d428d07040b7d188d9f688127
2020-07-15rk27xx: rename 'start' to '__start'Solomon Peachy3-5/+5
Change-Id: I3c5bbbc952222e840e82171431ba996a6a5d298b
2020-07-15mkinfo: Make memory size computation more accurateSolomon Peachy1-0/+6
* imx233 had disjoint memory map * hosted binaries not computing start address properly Change-Id: Ia45571e0c41f07f1d4f34f6e1a0067dcac530148
2020-07-15xduoox3: Add HID mappings for multimedia and presentation modesSolomon Peachy1-1/+55
Change-Id: I7264fed77c448db4b54104d81a10e118923c361d
2020-07-15mips: Adjust stack sizesSolomon Peachy2-4/+4
Main/IRQ from: 7.5/0.75 to: 7.25/1.0 With the reduction of the opus codec stack usage, giving the IRQ stack some additional breathing room is now possible. Change-Id: Id0cd3747fcaab70e2360667ac8c1a97ba7234ccf
2020-07-15opus: shrink stack usage by nearly 700 bytesSolomon Peachy1-28/+33
By moving three structures to the heap. None are in the hot decode loop, instead having to do with file sync / header state. Has neglible impact on performance (within measurement noise) on Clip+, Rocker, and Xduoo X3. On PP5022 (ipodmini2g) performance drops from 138.66% to 138.22% realtime. (0.3%) Unknown effect on Coldfire which lacks D$. Stack savings are pretty significant especially on lowmem devices. Change-Id: Ic8a1e93062ff5a46230e824134032053c4e1986d
2020-07-15Buflib_init Bugfix MinsizeWilliam Wilgus1-0/+6
when buflib_init is called with a buffer smaller than sizeof(union buflib_data); size will be zero Later when the alloc fails buflib will keep try to free items in order to satisify the request this crashes in the sim I suspect this behavior holds true on device as well but I havent verified this as of yet. patch adds minimal overhead to the buflib and panics when the size is too small Change-Id: I46e510367fc1cac19ce01ee6f92d8cf0d65ef914
2020-07-14puzzles: always reset input state before pause menuFranklin Wei1-3/+3
We were improperly conditioning the state reset with `do_pausemenu'. We should reset the input state no matter what. Change-Id: Iaafc59b95e9f1f053b57a34f0f28f7c672c0e327
2020-07-14puzzles: more verbose debug output in font loadingFranklin Wei1-3/+38
No functional changes. Change-Id: I7baa7bf37b3bdd57064c654a72d0e4e0d5600245
2020-07-15talk: only show the "failed reading .voice" splash if talking is enabledSolomon Peachy1-1/+2
Change-Id: I4046294e39c621ddeeceeb6f21eab05a1e687cb5
2020-07-15debug ata: Distinguish between Advanced power management and basic PMSolomon Peachy1-1/+4
The old debug menu item covered APM, which is optional in the ATA spec However, despite basic power management being mandatory, several popular ATA/CF->SD adapters do not advertise PM support and have problems when it is used. An earlier patch (g#2500 / 5462907) disabled sleep when the PM capability bit was not set; this makes it visible in the debug menu. Change-Id: I2f3dd1244798d7bbb8239ac159c6470774b0c05e
2020-07-14FS#13215: Russian translation update (Alexander Levin)Solomon Peachy1-147/+99
Change-Id: I0c53ef10b7cd3488176ffd670ab273ba4638e8de