AgeCommit message (Collapse)AuthorFilesLines
2018-12-08Fix overlapping string region ape.c->read_ape_tagsWilliam Wilgus1-9/+16
Switch to strrchr to find the extension Change-Id: Id7ea01ecc2e0553f560308f8b0fc53bd33b023e5
2018-12-08Pdbox hide cast-function-type fix overlapping memcpyWilliam Wilgus2-3/+3
dsoundfile.c used memcpy for overlapping memory regions switched to memmove Suppress the 160+ warnings for cast-function-type This plugin would require major work to fix these warnings Change-Id: I309d914839c1e70126a05b387863fd21613497a9
2018-12-08Fix Truncation warning in cuesheet.c->browse_cuesheetWilliam Wilgus1-1/+2
give user concrete indication that track title has been truncated by adding '~' at end of string Change-Id: I53034f4a09c103eb98ae1e0ef0a8a843fd2a2c6e
2018-12-08Fix Sim & checkwps for newer distrosWilliam Wilgus2-2/+7
__builtin found fix for rbendian.h tools/configure defines SIM_USE_BYTESWAP_H if byteswap.h is found in /usr/include/ maybe there is a better mechanism for this Change-Id: I4d004e68313e8b32aa5587582be36bc459fdaf6b
2018-12-08Fix speex warning lsp.c->lsp_to_lpcWilliam Wilgus1-1/+1
I'm pretty sure this was a false positive Change-Id: I0ab375d1d844b3d468c24888c371f588052e1ce9
2018-12-07Fix Sim for newer distrosWilliam Wilgus3-0/+52
__builtin found fix for rbendian.h tools/configure defines SIM_USE_BYTESWAP_H if byteswap.h is found in /usr/include/ maybe there is a better mechanism for this is a simple script to make .desktop shortcut files several newer distros don't allow you to run the simulator from the file manager, this or perhaps a different method can probably be included while building a sim at a later date. for now it can be run manually like so: similar to ../tools/configure run from your simulator folder ../tools/ exepath shortname icon ex. ../tools/ ./rockboxui clip+sim music-app Change-Id: Ia05d3a9349b27c5968a4a7a68b2eb480e60faec3
2018-12-06More keymap refinementsMarcin Bukat2-20/+24
Change-Id: If3ae6ece7848b143088d5f9ec8c00ed593d59ed2
2018-12-03Tweak keymapsMarcin Bukat1-120/+115
Taken partly from:,51653.msg243214/topicseen.html#msg243214 Change-Id: I7a565df0d6bd5a14cab541498e02ab64f25fa45f
2018-11-30sonynwz: add NW-ZX300G nvp infoAmaury Pouly1-0/+93
There is something weird going on: the Sony website has two different entries: - NW-ZX300/NW-ZX300A/NW-A45/NW-A47/NW-A45HN/NW-A46HN - NW-ZX300,NW-ZX300A update(20181004)/NW-ZX300G with slightly different nvp entries, but it is impossible to tell whether an NW-ZX300(A) belong to one or the other. Since the diff is very small, I am adding this as nw-zx300g but treat all devices as nz-zx300 since the destination node is the same and that is the main usage of the tool anyway. Change-Id: I3dc2fdec52650f938d568bed578184f6bc43d130
2018-11-30sonynwz: add NW-A57 and NW-ZX300G to the databaseAmaury Pouly4-7/+11
Change-Id: I9bbfa56c5b2d79568de5443f1098d724c4beda6a
2018-11-30nwzstools/scsitool: try to guess series if possibleAmaury Pouly1-0/+19
If the model is not known (ie model ID in the database) but another device from the same series is known, then the database information probably applies and one can use the "force" option -s to tell the tool to ignore the model ID. Automatically print such advice when the series can be guessed. Change-Id: I6bcc7aa29693df8c3d7d8e709ece7cea650be717
2018-11-30nwztools/scsitool: add experimental command to list Sony devicesAmaury Pouly1-3/+51
Change-Id: Ic4f382667c5c84514be661d36032c47fb8f92e75
2018-11-30rbscsi: add experimental API to list connected SCSI devicesAmaury Pouly2-1/+236
For now it is only implemented on linux using /sys scanning Change-Id: Ifdfe7564e6e8d0307ae6ddc53e49bb9aaf5a8268
2018-11-30Indentation fixAmaury Pouly1-2/+2
Change-Id: Ia0f96dd27c520cf2bfec4765619f53eaffee3e20
2018-11-30Add the NWZ-A844 to the databaseAmaury Pouly4-5/+7
For some reason even Sony didn't have it in its list... Change-Id: I26de6071e5887cc7c6ebb695ea333c7b3d1b50db
2018-11-26mpegplayer fix warningsWilliam Wilgus4-11/+13
this should fix 'warning: cast between incompatible function types' Change-Id: I7d192b8953fd14511431cb50254900f566eb0574
2018-11-24lua add LCD_DEFAULT_FG, fix 2-bit screen fg/bg inversionWilliam Wilgus2-2/+6
Change-Id: Ibe2bc6602ff27524a3b96d9523780acbfbf03c76
2018-11-17Lua fix crash on arm devicesWilliam Wilgus1-1/+1
This is a seemingly random bug that only affects (as far as I can tell) arm devices it isn't actually random as code changes cause it to appear/disappear based on alignment Change-Id: I4cbc4370677959319f8589fe454e854c45623468
2018-11-15Lua fix reader bug in lzioWilliam Wilgus1-1/+6
When loading a file, Lua may call the reader function again after it returned end of input Change-Id: Ic2f4d727705a0b8f48ce792f6a9f7af25a503037
2018-11-11lua update to 5.1.5William Wilgus15-105/+124
Modify Rocklua towards upstream 5.1.5 Clean up some of the Rocklua implementation Change-Id: Iac722e827899cf84f5ca004ef7ae7ddce5f7fbbe
2018-11-10Fix vuprintf fix possible %s buffer over-readWilliam Wilgus1-7/+12
when precision is not specified memchr recieved -1 for count count is unsigned so it looks in a potentially very large area for a terminator and returns this whole area if \0 is not found Instead we should use memchr when precision is specified and if precision is not specified use strlen Fixes 60+Mb Config.cfg files Change-Id: Ic4d1439334588f999c9071235430c42df2af5cc4
2018-11-10speech: additional correction rules for acronyms etc.Solomon Peachy1-0/+16
Taken from Igor Poretsky's tree. Change-Id: I339c3524916aebb71b6f81727c60ea1c7324e5eb
2018-11-09debug: Wrap rb_backtrace with HAVE_RB_BACKTRACE instead of CPU_ARMSolomon Peachy2-1/+6
Basically, preparation for a non-ARM backtrace support. Change-Id: Icfd09fbc65a98f859e2a19f8d1111827a262a969
2018-11-05Lua fix pixel-painter score saveWilliam Wilgus1-5/+5
pixel-painter was depending on the old readline code that returned nil for empty lines however empty lines should have returned an empty string Change-Id: Ic06ce920a7ab38e1fb8f7197d637e74ed9e35653
2018-11-05Lua Boomshine Update with circles + levelsWilliam Wilgus1-85/+193
added a few more levels and increased difficulty based on level Rliimage allows us to use circles in boomshine Optimized some of the code to exceed the speed of the original Change-Id: I68eb74f8b68fcdc8a9d022cd172374744425f15d
2018-11-02Lua fix failure to read lines longer than LUAL_BUFFERSIZEWilliam Wilgus1-13/+10
Readline didn't handle lines longer than LUAL_BUFFERSIZE it now reads these in chunks. Change-Id: Iffe12447e5441ff6b479ce3de1d36df64c276183
2018-11-02Lua optimize combine and rework similar functionsWilliam Wilgus4-67/+221
rb.strncasecmp strcasecmp just exclude count -> rb.strncasecmp(s1, s2) rb.backlight_brightness_set backlight_set_brightness -- redundant rb.backlight_brightness_use_setting -> rb.backlight_brightness_set() rb.buttonlight_brightness_set buttonlight_set_brightness -- redundant rb.buttonlight_brightness_use_setting -> rb.buttonlight_brightness_set() rb.mixer_frequency rb.mixer_set_frequency -> mixer_frequency(freq) rb.mixer_get_frequency -> mixer_frequency rb.backlight_onoff rb.backlight_on -> rb.backlight_onoff(true) rb.backlight_off -> rb.backlight_onoff(false) rb.touchscreen_mode rb.touchscreen_set_mode -> rb.touchscreen_mode(mode) rb.touchscreen_get_mode -> rb.touchscreen_mode() rb.schedule_cpu_boost rb.trigger_cpu_boost -> rb.schedule_cpu_boost(true) rb.cancel_cpu_boost -> rb.schedule_cpu_boost(false) Includes rbcompat.lua for backwards compatibility if your script is broken by this change you simply add `require("rbcompat")` to the top for the old functionality Change-Id: Ibffd79a0d9be6d7d6a65cc4af5c0a1c6a0f3f94d
2018-11-02lua fix rlimage FB_SCALARPACK()William Wilgus1-8/+14
FB_SCALARPACK(lua_tointeger()) was calling lua_tointeger 3x on color targets Change-Id: I7b3d73bba5dbc0aa4388b123de11410572fe67c5
2018-11-01Lua fix dir string constants and pcm_play_pause & pcm_set_frequencyWilliam Wilgus2-3/+3
String constants were already expanded in the first macro pcm functions were looking for stack position #1 when they needed stack pos #2 Change-Id: I7b4fb90953ab2395b77cbd550fdd257fafca6aae
2018-11-01Lua Fix utf8encode, remove utf16 functionsWilliam Wilgus2-0/+16
The auto generated utf8/16 encode/decode functions did not work. Upon implementing them correctly I found that lua handles the utf-8 form properly but I could not get utf-16 to work without crashing maybe someone can come along later and implement utf-16 safe string functions but for now utf-16 is removed. Change-Id: I97a044e200dc27f683a45487cd93fce667c670c4
2018-10-31Lua Add underscores in audio, pcm, playlist functionsWilliam Wilgus4-28/+25
Lessen confusion for end users looking for the underlying function names in plugin.h Change-Id: I6662dc7bd9f22d83af372b3d3c5af53d9a1eac9a
2018-10-30lua consolidate pcm_ functionsWilliam Wilgus4-2/+108
The way to call the pcm functions has changed rb.pcm("option", var) rb.pcm_set_frequency(freq) = becomes rb.pcm("pcmsetfrequency", freq) added pcm.lua to the includes for conversion to old functions if your script is broken by this change you simply add `require("pcm")` to the top for the old functionality added rb.pcm("calculatepeaks") Change-Id: I092057b0c0b5575e567862661f122da1ca2680e8
2018-10-30Lua restore audio_set_recording_gain, audio_set_output,inputWilliam Wilgus1-2/+5
Did not mean to wipe out these function when I consolidated audio Made the regex for audio_ and playlist_ exact matches instead of fuzzy Change-Id: I7537d1b494afb114c8b6333ea177b1e482f6b672
2018-10-30Lua update strftime.c from dietlibc sourceWilliam Wilgus1-36/+38
Adds %F -- %Y-%m-%d Fixes possible buffer overflow when writing final \0 Frees a bit of code on NON-RTC targets Change-Id: I1c2600a68ee88c6c99f411ae6646861578683f90
2018-10-29Lua replace fscanfWilliam Wilgus6-295/+66
Rocklua was using the full fscanf implementation to simply read %ld for the file:read("*n") function wasting 1k on unneeded/unused functionality Instead, I've implemented a filetol function to duplicate it without the extra overhead using strtol which as an added bonus ERANGE errors now resolve to LONG_MIN and LONGMAX instead of integer overflow filetol() reads long int from an open file, skips preceding whitespaces returns -1 if error, 1 on success. *num set to LONG_MAX or LONG_MIN on overflow. If number of digits is > than LUAI_MAXNUMBER2STR filepointer will continue till the next non digit but buffer will stop being filled with characters. Preceding zero is ignored. Change-Id: Ia42d0f73c63a894625bca4581e9b7e1cc7387fd2
2018-10-30Lua remove strncat.c & strcspn.cWilliam Wilgus5-85/+39
Change-Id: I08256f31e733d2674054e8e589d539d1396a0ee6
2018-10-30Lua expand multiple screen supportWilliam Wilgus3-101/+303
Some of the lcd functions had support for multiple screens but this wasn't very safe since the screen number wasn't bounded within the screens[] array This adds support for all the lcd functions along with checking that screen# is bounded properly, adds around 600 bytes to devices with a remote screen devices without a remote screen lock to SCREEN_MAIN Change-Id: I618bbc7b3919c7b0ff375fb2d71949d7cab43c87
2018-10-30Lua rliimage optimize rli_marshal, rli_copy, lcd_xxx_bitmapWilliam Wilgus1-71/+59
rli_marshal and rli_copy allow the use of a custom lua function instead of the built-ins, this custom function can signal to stop before the whole image is iterated. Originally it was checking for a return of 0 which was additional overhead for the built-in functions (which never stop early) as well. Now custom_transform sets the x & y deltas to 0 to indicate early exit removing an extra 'if' per cycle and return from all of the rli_transform functions The lcd_xxx_bitmap functions all require x, y, w, h, screen these calls have been consolidated into a single function get_bmp_bounds() Change-Id: I88de3149c58d1bfb40e9d1a91341fb86cbd63b51
2018-10-29codecs: Fix elapsed time calculation for large filesSolomon Peachy7-17/+15
In particular, this solves seeking glitches seen in ~6 hr mp3 files. (Patch taken from Igor Poretsky's tree) Change-Id: Id65b6726146b6d2d1a223e90b88e401d1b2d597a
2018-10-29sonynwz: add nvp map for NW-A50 seriesAmaury Pouly3-1/+284
Change-Id: I49f3399552721e515cc01021c2e0aa28c781ec28
2018-10-29sonynwz: add NW-A55 to databaseAmaury Pouly4-2/+8
Change-Id: I59861119c59490f586b3c6ed32a1c41df8b3d365
2018-10-28Lua remove gmtime.c use rb_plugin version insteadWilliam Wilgus3-59/+6
Change-Id: Ia6d47a13ec8ae407661a78c56513ac0c164216da
2018-10-25Lua Rlimage metatableWilliam Wilgus1-1/+2
Put rliimage functions into the rb.image metatable instead of the rb. table Change-Id: Iecdc564c2ea9739656e2025b51bb5d5c62e3dbc1
2018-10-25Lua Fix kbd_inputWilliam Wilgus1-1/+1
While luaL_addstring() works perfectly fine for the final buffer once Lual_pushresult() is called kbd_input doesn't display a previous input properly since the buffer hasn't been finalized yet Change-Id: Ic50acaa8b7b17077dec8750dd2b6382624e8a549
2018-10-25Lua cleanup kbd_input, gui_syncyesno_run, do_menuWilliam Wilgus1-24/+25
Removes unneeded functions from kbd_input Consolidates message filling function for gui_syncyesno_run & do_menu Change-Id: If3c3cea3cbf37a8dc52983c0db174de6d54b35f8
2018-10-25lua consolidate playlist_ functionsWilliam Wilgus4-52/+160
The way to call the playlist functions has changed rb.playlist("option", var) rb.playlist_add(filename) = becomes rb.playlist("add", filename) added playlist.lua to the includes for conversion to old functions if your script is broken by this change you simply add `require("playlist")` to the top for the old functionality added rb.playlist_tracks(dir, filename) to playlist.lua this will allow you to add all tracks in a playlist.m3u8 to a lua table Change-Id: I87fcc56be365d8495d214f069331b6ddbfbef1db
2018-10-24lua add audio_play consolidate audio_ functionsWilliam Wilgus4-2/+103
audio_play was removed from the rocklib I assume due to inconsistent behavior I've readded it with a check for audio paused which instead uses rewind/ff and then resumes audio the way to call the audio functions has changed as well"option", var) so rb.audio_play(0, 0) becomes"play", 0, 0) audio_audio_flush_and_reload_tracks becomes"flushandreloadtracks") all functions except audio("getfilepos") return the previous (or still current) status added audio.lua to the includes for conversion to old functions if your script is broken by this change you simply add `require("audio")` to the top for the old functionality Change-Id: I364adf0c85d9c12b98cde29c26fbe5ee05b9d331
2018-10-24Lua fix create_numbered_filenameWilliam Wilgus1-2/+5
I didn't realize that some devices used the *num variable this fixes that oversight Change-Id: I2ecd6f475bebdd6ce745b360be3762a069bfc2b1
2018-10-24Lua fix strip_extension and create_numbered_filenameWilliam Wilgus2-0/+38
Both of these functions modified the string in the lua stack per lua manual: 'When a C function receives a string argument from Lua, there are only two rules that it must observe: Not to pop the string from the stack while accessing it and never to modify the string' strip_extension will still work with old parameters and is thus backwards compatible strip_extension("filename") create_numbered_filename has changed slightly and IS NOT backwards compatible create_numbered_filename(path, prefix, suffix, [number]) (number defaults to -1) Change-Id: I34cf7e2f6f691f33d5ac2b2e995855a171fb99b3
2018-10-22lua move rocklib_img to its own separate loadable moduleWilliam Wilgus5-25/+23
allows rocklib_img to be excluded if needed stops rocklib_aux from generating redundant prototypes for lcd_mono_bitmap[_part] Change-Id: Ie208ad71ab5f9a7deb026dc01a5b0a0631a0d29c