summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-08-07metadata/asap.c consolidate read char function and check return valuesWilliam Wilgus1-23/+27
and a bit of cleanup using macros to make the code easier to follow Change-Id: I2c5953a68a9f415453e508c14a9c1a5a1e84e6b5
2021-08-07metadata/asap.c WS cleanupWilliam Wilgus1-26/+26
Change-Id: Id3bc053a45eeea107a54dd47640fa3ceb4b04498
2021-08-07tagcache: Don't treat tag_virt_basename as a numeric tagAidan MacDonald1-4/+3
Change-Id: I88fe17466b606a1f60a4c823214edd9766deb260
2021-08-07Remove unhelpful unsigned casting trickAidan MacDonald1-8/+3
Change-Id: Ice86f060974c51bbaf051ed8c5a369ce80ecfe15
2021-08-07move PCM_NATIVE_BITDEPTH definiton into global config codeSolomon Peachy3-10/+5
Change-Id: I391bcffca670916c2c88426e2ba2603351326cee
2021-08-07fiiom3k: Add bookmark screen keymappingAidan MacDonald1-1/+7
Forgot to commit this back around the time I did the manual Change-Id: I8fafeec5105b4bee3380779f4cc86d3e73459cf2
2021-08-07Fix warnings from 56b0dde545Dana Conrad1-0/+5
Need a default bit depth in pcm-x1000.c Change-Id: I2c6af227975d2f47609b51090638012d8406ec1e
2021-08-07Higher bitdepth software volume scalingDana Conrad5-32/+118
Operates between 0 and -74 dB (mute) without issue Change-Id: I497e002bd8db43833a09ebbc29212fbb6cc8ebfd
2021-08-07ErosQ Native: Add DC Offset to PCM dataDana Conrad3-0/+31
A small negative offset seems to silence all play/pause clicking on the PCM5102A. Also adding PCM soft muting, and muting the headphone amp when the headphones are detected as removed. This has been tested to not cause any unintended side effects on the line out. Also confirmed the numerical dB values are (approx.) correct. Change-Id: I689d68887c86add9cc5e0ccb0c7de01aaa69b4d9
2021-08-07metadata/vfx.c cleanup string and character handlingWilliam Wilgus1-17/+19
Change-Id: I7550d6db05b0d31a1433d0af9b2233f9dc3f5ee2
2021-08-07inflate: import initial module for deflate decompressionJames Buren3-0/+806
This will eventually be used by the ZIP module and other things that support DEFLATE based streams. Change-Id: I4acc9561eb56c9c368d1defab9c14e0454d105e1
2021-08-07metadata/smaf.c handle read errorsWilliam Wilgus1-26/+27
Change-Id: I450f1fc8e1b69ce09f9888f5384c3e23a93822a1
2021-08-06metadata/mp3data.c set data to 0 in case of read errorWilliam Wilgus1-3/+2
Change-Id: I15d4e3d3be4bf4531c892f4351355b0b2e8e0ca9
2021-08-06Fix yellow from d541a72aAidan MacDonald1-0/+1
Change-Id: I9c539035544d285da1941d2c1954cf2aa4d00087
2021-08-06Fix possible negative fd in playlist.cAidan MacDonald1-1/+1
Change-Id: I59d88609ec3f20ec9f482a777396cd72be23a35b
2021-08-06Be sure to wipe id3 tag after failed parse in playback.cAidan MacDonald1-1/+2
Change-Id: I000c78e913ab80afa9b82cae937afb5255831b79
2021-08-06Bugfixes in eq_menu.cAidan MacDonald1-10/+15
Change-Id: Ibf754554f685d13ac00a49694fcecee459ff838f
2021-08-06Fix wrong printf format in system-hosted.cAidan MacDonald1-1/+1
Change-Id: I73722f0711a295152a98ab784cd6cf76379ef52e
2021-08-06Fix hosted glibc backtraceAidan MacDonald1-1/+1
According to backtrace(3) man page, the string returned from backtrace_symbols() contains the return address so we shouldn't need to print it ourselves. Change-Id: Ia779207285c9ea0052b9aee3d84ee8380bf46d82
2021-08-06Fix use of uninitialized variable in mp4 metadata parserAidan MacDonald1-1/+1
Change-Id: Idca69e7429af13609785755d4e152d87f471c462
2021-08-06Fix path buffer overflow in screendumpAidan MacDonald1-2/+2
Overflow is due to a hidden assumption in create_datetime_filename() and create_numbered_filename() where buffer must be >= MAX_PATH bytes. Change-Id: I9d36517d861b6925352380d551afc5439edbb340
2021-08-06logf: Fix two issues with logf_panic_dump()Solomon Peachy2-4/+9
* It had a (read) buffer overflow when dumping the stuff on the back half of the buffer * a highly questionable code construct was nuked Change-Id: I7f6f119524fc2095f788fc9b3d356459955d3ace
2021-08-06tools/iriver: fix resource management in encode/decode functionsJames Buren1-45/+44
Change-Id: Ib0b38378c66d5902694d9af9fd0271d616101660
2021-08-05test_disk: Minor fix in an error pathSolomon Peachy1-1/+1
...Log the variable containing the actual error Change-Id: If22e6b684f2e213bc45c8ca95295936ba8e09895
2021-08-05metadata: Fix sign extension in get_uint64_le() routineSolomon Peachy1-1/+1
Change-Id: Ibd85cf72ac1babd1fa636c341b90b76bdfc0491b
2021-08-05mikmod: Uninitialized variable used in a control flow decisionSolomon Peachy1-1/+3
Change-Id: I6df903399361f1df7ca0f766fff4062a984e2ba8
2021-08-05hosted: Fix rtc_write_datetime() error handlingSolomon Peachy1-0/+3
(if mktime() fails, don't attempt to write its result to the RTC) Change-Id: Ib09b8dccafdef032119db76f10af74dfc220cc21
2021-08-05disk.c ensure a valid volume is returned from get_free_volume()William Wilgus1-0/+7
volume is used for element math and indexing into buffers -1 volume is bad Change-Id: I1ec75ef3a848c154ea80905224ea9a3a14bf8151
2021-08-05misc.c format_sound_value guard division by zeroWilliam Wilgus1-0/+5
Change-Id: I7085cb34d2258aa5fc7e04fc0e73d6f733810038
2021-08-05lib/skin_parser check that malloc succeededWilliam Wilgus1-0/+5
Change-Id: I32db233a53b0f693f815cf96bcbe6711c366e5b3
2021-08-05Simplify clamp_componentAidan MacDonald1-2/+2
Surprise surprise: the compiler generates shorter, branch-free code if we don't try to be clever with signed/unsigned casting tricks. Change-Id: I93d2020b6127e7d43feee394b06a52aaeddf3b79
2021-08-04Avoid buffer overflow when generating bookmark file nameAidan MacDonald1-7/+14
Change-Id: I14f3d83a8089d33f4e900a1d5f965e67082a07ea
2021-08-04plugins: Fix issues in 2048Aidan MacDonald1-6/+5
One of these was an unintentional fallthrough -- if you said no to 'quit without saving' it would save and quit. Change-Id: I33828b58962a05adab65ac5f71dd0e2b1e07001b
2021-08-04Document intentional fallthroughs + fix harmless unintended onesAidan MacDonald24-2/+36
Change-Id: I1ca5b1027ec30cbf61093bab35b980196ed14e6b
2021-08-04Revert "rbutil: Remove done() signal from Themes Install window."Dominik Riebeling2-0/+4
The done() signal is acutally needed to indicate the installation being finished. Fixes installation being stuck after themes install. This reverts commit fb6840e57260b1da35924914d47731e06597afea. Change-Id: I9c1791e3ecfec992da40ff72b6969d80bbb0cd7f
2021-08-04plugins/resistor: Fix incorrect check for a valid 4th band valueSolomon Peachy1-3/+3
Change-Id: I499bcd6d2d6fd5dd92c184cc1ec014e62f0441fa
2021-08-04powermgmt: Clean up some convoluted #ifdefsSolomon Peachy1-2/+5
Makes it more explicit what code is used under which circumstances. Change-Id: I0a482dd48e1eb4b119ca6d8dca2b8aa450445fd1
2021-08-03menu.c guard against NULL menu, list, setting pointersWilliam Wilgus1-1/+14
Change-Id: Id45d9ac3b88571cb3927ca29314f997d5cbfd598
2021-08-03lua fix potential null warningWilliam Wilgus1-2/+4
I'm not sure this would happen but I suspect its possible to get malformed data back from lineinfo as this is how the error system tracks code flow and this is a hacked add-on to allow RLE (run length encoding) of said code flow data Change-Id: I4b914c632935f8b1a9fa960212c58e810b2db738
2021-08-03mask_select guard against null pointersWilliam Wilgus1-27/+35
Change-Id: I83d246c13d22c1e76a55cbfdd20dcc955eb556ec
2021-08-02icon.c guard against negative error values bytesread is copied to an ↵William Wilgus1-1/+1
unsigned int for core_shrink Change-Id: Iff93397e7d6fae8936ef0fdbb1e71df63bcf6531
2021-08-03folder_select prevent directory handle leak on errorWilliam Wilgus1-0/+3
Change-Id: If1617dc92683d7de3d7709b363a593e40fbc5bc8
2021-08-03list-skinned.c check label pointer for validityWilliam Wilgus1-0/+3
Change-Id: I993ff4a2d5d1c46bad46aae7f46fa4996e67481a
2021-08-02filetypes.c filesize() guard against negative error valuesWilliam Wilgus1-4/+12
buffer size is copied to an unsigned int for core_alloc Change-Id: I7b9ccab79554e55b22d39501ccb779036913258a
2021-08-03language.c fix possible buffer overrunWilliam Wilgus1-2/+2
ensure zero termination regardless of data read from lang file Change-Id: I0da0e787ffb10c9268557812b061cc3c452fbd0a
2021-08-03open_plugins bugfix failure to saveWilliam Wilgus2-9/+12
if you added a plugin through the core settings and then used the shortcut immediately the entry would never get flushed to disk Change-Id: I62e876bbf0a8fa96acba1cc2582e2563401547f1
2021-08-02metadata/flac.c fix potential buffer overrunWilliam Wilgus1-0/+12
Change-Id: Iee12f251455c4fda9d91d10e466d17e5e02046b9
2021-08-01id3tags.c check for buffer overrunWilliam Wilgus1-0/+3
Change-Id: I74fde8e234fe85abfabefddcea7f10038167c715
2021-08-02playlist_catalog fix strcpy overlap, potential buffer overrunWilliam Wilgus1-4/+8
Change-Id: I7cd1302d2c905992078351a531a5d67fdb465809
2021-08-02tagcache.c clean upWilliam Wilgus1-149/+187
Change-Id: I658ee345461eeda77cbe856cec46c21dcce7715b