summaryrefslogtreecommitdiffstats
path: root/apps/menu.c
AgeCommit message (Collapse)AuthorFilesLines
2009-02-01Accept a quick patch from Alexander Levin to neaten up the #defines and ↵Jonathan Gordon1-1/+2
comments from my earlier commit git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19897 a1c6a512-1295-4272-9138-f99709370657
2009-02-01Statusbar handling fixes. Jonathan Gordon1-1/+1
Fixes FS#9845 - %we/%wd wasnt working WPS no longer resets the viewportmanger more than needed (was doing it twice/draw before) screens can now enable/disable the statusbar easily ignoring the setting instead of needing special handling (fix for the radio screen coming soon) minor glitch introduced in this commit... the statusbar in the WPS might disappear for a fraction of a second when it is entered, I need to track this down... git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19894 a1c6a512-1295-4272-9138-f99709370657
2009-01-03a few more button/statusbar fixes...Jonathan Gordon1-0/+2
* hopefully fix the last of the plugins which dont handle the enw SYS event. * fix FS#9750 - WPS's which dont specify (or force the wps on) wernt showing the statusbar at all * lamp, battery_bench, *_flash button handling fixes * plugins using the core menu code will again show the statusbar git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19656 a1c6a512-1295-4272-9138-f99709370657
2008-12-31Decouple the statusbar drawing from the rest of the screen drawing. it is ↵Jonathan Gordon1-51/+10
not drawn roughly 4x per second automatically. viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.) All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false). This commit also includes some menu/list viewport cleanups from kugel in FS#9603 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-03revert part of r18933 which fixes FS#9600. Jonathan Gordon1-0/+2
This fix is a bit wasteful, but fine untill the menu starts being called with a parent viewport. The real fix should be using a callback to notify the menu to reinit its viewports when the theme changes git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19310 a1c6a512-1295-4272-9138-f99709370657
2008-12-01FS#9173 - move all time/clock related settings in the menus into system > ↵Jonathan Gordon1-0/+3
"time & date" (this includes sleep timer, alarm settings) The time/date dispaly has been moved out of the "rockbox info" screen and into this screen also (only displayed if there is at least 3 lines of text on the screen though) The time/date is talked in this screen by pressing the usual context-menu button (usually long-select) Targets without a RTC are not changed (i.e sleep timer isnt moved) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19282 a1c6a512-1295-4272-9138-f99709370657
2008-11-05FS#9525 - The list for the quickscreen items chooser turned out to not ↵Jonathan Gordon1-5/+59
really be usable so try this instead. Settings in the menus will now have a context menu where you can reset the setting and if its OK to put it on the quickscreen there will be options there to put it on it. Also, ban last.fm and cuesheet support settings from the QS git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19013 a1c6a512-1295-4272-9138-f99709370657
2008-10-30fix some problems with the menu code:Jonathan Gordon1-5/+6
- MENU_FUNC_CHECK_RETVAL has been loosened to return if the function returns non-zero (and passes that return value on as the return value for do_menu(). This is fine for now because only 2 places uses this flag and both return 1. - when the option screen or a function is called from a menu which doesn't use the full screen viewport the wrong viewport was used (option screen crashed, and returning from the funciton ignored the origional viewport.) This is now changed so (for now) the option screen always gets the full screen viewport and returning from functions shows the menu correctly. Some time in the future menu items which are functions should be changed to accept a viewport (if they end up drawing). When that happens both option screen and the called function should use the menu's parent viewport git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18933 a1c6a512-1295-4272-9138-f99709370657
2008-10-13Stop scrolling lines when entering or leaving a menu list item. Fixes FS ↵Peter D'Hoye1-1/+11
#9478 (Scrolling lines from (menu) lists are drawn over other screens) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18802 a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg1-2/+4
later. We still need to hunt down snippets used that are not. 1324 modified files... http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-05-29Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR ↵Peter D'Hoye1-5/+5
into HAVE_BUTTONBAR to bring it in line with the other defines git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
2008-05-03Viewported quickscreen (take 2 :D) (FS#8553)Jonathan Gordon1-0/+1
- no customization support - no top item - much better use of the screen - deprecates 20 odd lang strings (the QS can now use the regular lang strings and user font) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17315 a1c6a512-1295-4272-9138-f99709370657
2008-05-03Made source files #include the header file that they implement to make sure ↵Bertrik Sikken1-1/+1
they are in sync. Made some local functions static. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
2008-04-30found (and fixed) by Stephane Doyon...Jonathan Gordon1-4/+5
"A glitch was recently introduced when backing out of context menu functions. When exiting for example the playlist viewer, or the id3 viewer, it will speak the name of the menu entry used to access that function. That's pretty confusing because it sounds like you dropped back into the menu system while we have in fact exited the context menu completely." git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17293 a1c6a512-1295-4272-9138-f99709370657
2008-04-23option_screen() now accepts a viewportJonathan Gordon1-3/+4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17223 a1c6a512-1295-4272-9138-f99709370657
2008-04-23enable the quickscreen in menus and neaten up the else if-ingJonathan Gordon1-4/+9
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17222 a1c6a512-1295-4272-9138-f99709370657
2008-04-09Pass the buffer length to the list_get_name callback functions instead of ↵Nils Wallménius1-2/+5
using hardcoded MAX_PATH git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-03-26fix themes not being fully applied to the menu on load (Hopefully fixes FS#8808)Jonathan Gordon1-10/+3
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16819 a1c6a512-1295-4272-9138-f99709370657
2008-03-26fix the buttonbar in the browser and menus. Jonathan Gordon1-3/+22
fix a problem where the menus wouldnt redraw when they should have when settings change git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
2008-03-26the menu and list now accepts a parent viewport to draw in (and the menu can ↵Jonathan Gordon1-26/+88
be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-25Code police raid on the settings code, consting and putting headers ↵Steve Bavin1-1/+1
alongside their implementation. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16798 a1c6a512-1295-4272-9138-f99709370657
2007-11-16Fix buffer overflow in the title padding code (FS#8163)Linus Nielsen Feltzing1-6/+8
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15633 a1c6a512-1295-4272-9138-f99709370657
2007-11-09git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15546 ↵Jonathan Gordon1-0/+10
a1c6a512-1295-4272-9138-f99709370657
2007-11-07fix redJonathan Gordon1-1/+4
fix Björn's name in the (c) fix FS#8105 - backing out of the submenus in the context menus shuoldnt leave the context menu completly (expect playlist which possibly makes sense?) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15513 a1c6a512-1295-4272-9138-f99709370657
2007-11-05fix FS#7288 - pad the title of the scrolling settings so they actually scrollJonathan Gordon1-0/+24
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15469 a1c6a512-1295-4272-9138-f99709370657
2007-11-04revert my previous commit and do it in a much less hacky way (both of these ↵Jonathan Gordon1-11/+0
were for FS#8084) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
2007-11-04return to the main menu if stop is pressed in the wps context menu, (blame ↵Jonathan Gordon1-0/+12
pondlife for the hack :D ) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15457 a1c6a512-1295-4272-9138-f99709370657
2007-10-21From FS#7774: use list voice callback in menus.Stéphane Doyon1-29/+17
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15234 a1c6a512-1295-4272-9138-f99709370657
2007-10-19FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not ↵Steve Bavin1-1/+1
just menus), hopefully save some space. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
2007-10-09Add a voice callback to dynamic menus, along side the text_callback.Stéphane Doyon1-6/+16
From FS#7563. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-09-17minor update to gui_synclist_do_button() which will hopefully simplify ↵Jonathan Gordon1-1/+1
things later. Now returns true if the action was handled in that function instead of returning the handled action. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
2007-08-20Make MENUITEM_STRINGLIST() menus talk (if ID2P() is used for the string)Jonathan Gordon1-0/+11
Makes the plugin browser talk (FS#7612), as well as the paylist viewer menu and the bookmark menu. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14399 a1c6a512-1295-4272-9138-f99709370657
2007-08-05Redraw the menu when stopping playback, in case the bookmarking code left ↵Magnus Holmgren1-1/+1
something on screen. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14196 a1c6a512-1295-4272-9138-f99709370657
2007-08-04dont redraw the menu if we are about to quit anyway (noticable when backing ↵Jonathan Gordon1-1/+2
out of the playlist menu from the wps context menu) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14180 a1c6a512-1295-4272-9138-f99709370657
2007-08-02Finally use the rec button to get to the rec screen on sansa and iriver ↵Jonathan Gordon1-0/+8
hxxx. hold rec to get there... short press still is unused git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14141 a1c6a512-1295-4272-9138-f99709370657
2007-07-23Fix the text for settings which have a different title than what is shown in ↵Jonathan Gordon1-2/+6
the menu (i.e scroll options) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13962 a1c6a512-1295-4272-9138-f99709370657
2007-07-22remove the need for action_signalscreenchange().Jonathan Gordon1-5/+0
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-11Rearrange and cleanup settings codeJonathan Gordon1-114/+4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13851 a1c6a512-1295-4272-9138-f99709370657
2007-07-11same as previous commit, but more forgotten casesJonathan Gordon1-2/+8
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13850 a1c6a512-1295-4272-9138-f99709370657
2007-07-11woops, menus stopped getting redrawn when the setting screen exitedJonathan Gordon1-2/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13849 a1c6a512-1295-4272-9138-f99709370657
2007-07-11If the action handler for the menu returns ACTION_REDRAW the list will be ↵Jonathan Gordon1-0/+10
redrawn. Fixes the Now Playing/Resume Playback text not updating git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13848 a1c6a512-1295-4272-9138-f99709370657
2007-07-11Redraw the menus once every action, not 3 timesJonathan Gordon1-4/+4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13847 a1c6a512-1295-4272-9138-f99709370657
2007-06-21Accept FS#7313 - make the menus talk more oftenJonathan Gordon1-3/+10
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13679 a1c6a512-1295-4272-9138-f99709370657
2007-06-11When recording, disable voice menus without actually modifying user ↵Steve Bavin1-1/+1
settings. Patch FS#7272, fixes bug FS #6163 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13615 a1c6a512-1295-4272-9138-f99709370657
2007-05-20Fix FS#7176 - wps context menu doesnt set the correct selection.Jonathan Gordon1-0/+9
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13445 a1c6a512-1295-4272-9138-f99709370657
2007-05-19Remove unused function and unused headerNils Wallménius1-6/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-08Move the old api out of the core and into the plugin lib.Jonathan Gordon1-201/+1
ew plugins shuold use the new api and not this one. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13358 a1c6a512-1295-4272-9138-f99709370657
2007-05-08fix the menus again, this time it stopped redrawing after coming out of ↵Jonathan Gordon1-0/+1
setting screens git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13353 a1c6a512-1295-4272-9138-f99709370657
2007-05-07Fix my previous commit... menus will redraw correctly againJonathan Gordon1-0/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13338 a1c6a512-1295-4272-9138-f99709370657
2007-05-07Fix the menus so lines scroll againJonathan Gordon1-3/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13337 a1c6a512-1295-4272-9138-f99709370657