path: root/apps/menus/display_menu.c
AgeCommit message (Collapse)AuthorFilesLines
2021-03-23Add disable setting for all softlock notificationsDana Conrad1-1/+1
Tested on erosq Added ability to disable all softlock notifications. Setting is "Disable All Lock Notifications" under Advanced Key Lock Settings. Tested to make sure it doesn't interfere with backlight exemptions, keylock exemptions, or first press enables backlight only. When enabled, this overrules the existing Disable Notify setting, which only disables the reminders when a button is pressed while the device is already locked. Also changed phrases in the Advanced Key Lock settings menu to make it more obvious what the options do. Changed LANG_ACTION_PLAY, LANG_ACTION_SEEK, and LANG_ACTION_SKIP from "[button]" to "Exempt [button]". These language changes will also affect the Backlight Exemptions list, but the wording should be appropriate there as well. Added LANG_SOFTLOCK_DISABLE_ALL_NOTIFY and LANG_ACTION_VOLUME, changed LANG_VOLUME to LANG_ACTION_VOLUME in display_menu.c for consistency. Change-Id: I914fe154ba5d508a842165aea7c7755e4e6b9c57
2020-07-24[4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice.Solomon Peachy1-20/+0
Note: I left behind lcd_bitmap in features.txt, because removing it would require considerable work in the manual and the translations. Change-Id: Ia8ca7761f610d9332a0d22a7d189775fb15ec88a
2020-07-19Fix more of the red from c39f95465Solomon Peachy1-2/+2
Change-Id: I8c9510774803f7164f7a003575711f3dd980223c
2020-07-19menus: Fix some of the red from c39f95465Solomon Peachy1-1/+1
Change-Id: Ic22123a83bf119605c8ddf686b6a8e21f9555c6a
2020-07-19do_menu pass internal synclist reference to callbackWilliam Wilgus1-14/+37
keep running into the rigid nature of do_menu it isn't too bad when you don't need voice but once you do the fun awaits do_menu likes to talk on menu enter which is in a loop when you use do_menu I would like to move the processing to the callback TOO BAD you only get an action and the menu_item_ex struct you sent it when calling the function Change-Id: Iaefd0cc133435d675b7dd27a558c504d6ccb327a
2017-01-17Selective Backlight/Advanced Softlock - Selective actions based on contextWilliam Wilgus1-27/+96
Selective backlight allows the user to choose actions that will not enable the backlight when pressed. Advanced softlock allows user to choose actions that will not be blocked by screenlock on devices without a hold button. Both only occur in FM and WPS Contexts. Update: Back from the dead -Cleaned up code, removed unnecessary calls, re-arranged last filter action timeout conditional to work in case last_filtered_action_tick was never set -Added entries to the manual -Fixed back button on some menus not activating backlight -Made menus more intuitive, no actions selected now changes menu item to off. -Added talk fuctionality. -Added option to disable selective backlight while on external power. -Rewrote backlight and softlock handling code to fix issue with scrollwheels -Menu changed to have toggle(yes/no) and settings -Optimized selective actions lookup -Added option to disable notification of 'buttons locked' while softlocked -Removed uneeded code, consolidated action lookup to single function -Fixed incorrect name on selective softlock menu -Added option to disable touch on touchscreen devices -Fixed backlight on original screenlock without selective screenlock active -Added text selection in mask_select for when show_icons is off -Fixed voice in mask_select to speak if voice is defined instead of spelling -Added more lang defines (play skip seek) -Added option to disable unknown keys turning on backlight -Fixed Conditional argument In wrong place causing players without backlight to fail to build -Fixed Disable Unknown blocking detection of context change -Fixed canceling menu didn't update new settings -Added Autolock on backlight off -Removed backlight_on_force from backlight.c, Now sets ignore next to false and uses backlight_on -Cleaned up autolock code added strings to lang file -Fixed issue where rapid presses would bypass softlock -Removed old softlock code, Cleaned selective actions code -Changed menu to match existing RB menus -Fixed Backlight_on_Hold blocked by backlight_ignore_next -Fixed ignore_next for ipod -Fixed bug allowing context with softlock to bypass selective backlight -Changed mask_select to no longer prompt for changes to be saved -Changed menu names -Added ignore timeout to allow ipod scroll wheel to work properly and other players to still work properly, removed some previous code including ignore_event -Increased ignore timeout to prevent sd card accesses from interrupting action code and turning on backlight -Changed Unknown action to unmapped action in menu, changed handling code -Removed unneeded logic and variables for handling unfiltered actions -Reverted unmapped action code to previous functionality -Added manual entries (thanks JohnB) -Removed elusive unhandled unicode character from manual, changed formatting slightly Actions: Volume,Play,Seek,Skip Extras: Disable unmapped actions Disable selective backlight on external power Disable touch during softlock on touchscreen devices Disable softlock notifications (power button still notifies) Autolock on backlight off Method: Adds a function to ignore backlight on next call If selected action occurs backlight is forced on, Filter_first_keypress stays intact. Selective softlock allows selected actions through, bypasses the normal softlock routine. ToDo: DONE previous commit (#1) has attribution for folder_select.c which mask_select is based from. Change-Id: I08132ddcfd64c81751ef23b720f3ec6d68695fe4
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis1-1/+19
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested: Michael Sevakis <>
2012-01-07apps: lcd-remote.h is not needed if HAVE_REMOTE_LCD is not definedRafaël Carré1-0/+2
Fix a comment git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-10-17Commit FS#12321 - Touchscreen: List line padding, to more easily select linesThomas Martitz1-1/+12
This adds line padding to lists on touchscreens, in order to make lists reasonably useful without huge fonts. It's configurable: * Automatic (default, line height calculated using a lcd dpi aware function) * Off (status quo, line height = font height) * X pixels (from 2 to 50 in even steps) The automatic setting should/aims to Just Work Out Of The Box on all targets git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-06-05Make the histogram code usable for playback as well. Move the recording ↵Peter D'Hoye1-0/+27
histogram code to peakmeter, rename it to remove the recording reference, and rename anything referring to it as well. Change the drawing code so there are more options to position them. This may change your histogram settings, so check after upgrading. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-06-05Remove the jump scroll settings since they don't do anything, drop the ↵Nils Wallménius1-7/+1
relevant lang ids too git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-10-05Fix red: Invert buttons in RTL modeTomer Shalev1-1/+1
- Revert renaming of button_set_flip() - Moved rtl flipping logic to apps/actions.c as a static function - Joined rtl_button_flip_needed() and button_flip_horizontally() git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-10-05Invert buttons in RTL modeTomer Shalev1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-24Move the "Status/Scrollbar" menu to Theme Settings, and add the ↵Thomas Martitz1-62/+1
F_THEMESETTING flag to the settings it was missing. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-24Slightly change parts of the previous commit to reuse existing code, and ↵Thomas Martitz1-7/+1
enforce enum statusbar_values instead of just int, git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-23Fix redraw issues when the statusbar setting was changed with an UI ↵Thomas Martitz1-3/+31
viewport. Now the old statusbar area is cleared upon changing the setting. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-19Combine the settings for scrollbar on/off and its position into one with ↵Alexander Levin1-2/+1
three possible values git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-17Add setting to position the scrollbar on the left or rightMaurus Cuelenaere1-2/+3
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-17FS#10534: Make scrollbar width variable through a setting (useful for ↵Maurus Cuelenaere1-1/+2
touchscreen targets) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-16User definable UI viewport, to be able to restrict the UI into a viewport ↵Thomas Martitz1-2/+2
for all bitmap displays. Flyspray: FS#8799 This will allow for pretty themes, for example those with nice glass effects on their backdrops (some might argue they're wasting screen space but it's upto them), as well as allowing for future background WPS updates in the main UI. Plugins are not converted yet, they simply use the full screen. Ideally, any plugin that does *not* want the UI viewport, should take care of that itself (i.e. plugins should normally use the UI viewport). git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-05FS#10406 - split the statusbar setting into one for each display, and allow ↵Jonathan Gordon1-0/+6
the bar to be at the top or bottom of the display git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-06-16Touchscreen targets: add calibration screen + rewrite calibration driver ↵Maurus Cuelenaere1-0/+29
(FS#10295) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-05-09Remove unneeded #include "backdrop.h"Bertrik Sikken1-1/+0
Remove unneeded #include "statusbar.h" git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-04-11M:Robe 500: Start of proper remote support, touchscreen works without remote ↵Karl Kurbjun1-2/+8
now. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-03-08Clean up some #includesBertrik Sikken1-2/+0
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-03-04Cosmetic fix: remove duplicate semicolonsBertrik Sikken1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
where the latter now activates the wheel acceleration code. HAVE_SCROLLWHEEL plainly indicates the existence of a scrollwheel, thus all ipods define it now (in addition to the ones and some sansas which did before). Same applies to the manual. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-01-26Commit FS#9724, which reworks the preprocessor defines related to backlight ↵Thomas Martitz1-6/+4
fading to a CONFIG_BACKLIGHT_FADING style. The apps/ code will only see which setting is supposed to be used, specific backlight fading handling is kept in firmware, slightly reword the manual text about software fading too with regards to the Gigabeat S git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-11-26Add hardware backlight fading on Gigabeat S with fade up and down options in ↵Michael Sevakis1-2/+4
LCD Settings. USE_BACKLIGHT_CUSTOM_FADING_BOOL is used to specify the setting type needed but leave the fading code itself implementation-defined. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-11-26Add software backlight fading for E100/H300/X5/D2, by Thomas Martitz and ↵Steve Bavin1-3/+5
others - see FS#6800 for credits. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-10-16Accept FS#9480 - centralise and organise the events in the apps/ layer. Jonathan Gordon1-2/+2
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-09-18Make local function ticking_callback static in apps/menus/display_menu.cBertrik Sikken1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg1-2/+4
later. We still need to hunt down snippets used that are not. 1324 modified files... git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-06-23FS#9051 - remove LCD margins... use viewports if you need them...Jonathan Gordon1-0/+3
NOTE to WPS people.... %m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored. Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected. Please report problem screens in git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-14Straigten-out lcd sleeping on Gigabeat F/X. Add a service function to ↵Michael Sevakis1-2/+2
backlight.c to handle lcd sleep timer. Make HAVE_LCD_SLEEP useable without a setting and use HAVE_LCD_SLEEP_SETTING when a setting is available in addition to HCD_HAVE_SLEEP. If a setting isn't used, the target must define the timeout to be used in the config. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-03Fixed warning about unused flipdisplay_callback function for targets that ↵Bertrik Sikken1-1/+1
cannot flip the display. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-03Made source files #include the header file that they implement to make sure ↵Bertrik Sikken1-5/+5
they are in sync. Made some local functions static. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-03-29Remove unnecessary (and incorrect) #ifdefs surrounding #include ↵Dave Chapman1-4/+0
"backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-03-28Update the LCD after setting flip status as required by the LCD drivers. ↵Jens Arnold1-0/+1
Fixes garbled display after flipping before the first list update. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-03-06there is no need to load the filename settings unless reading from a .cfg, ↵Jonathan Gordon1-1/+1
so stop them being read every time settings_apply() is called git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-03-05FS#8457 - convert the list drawing code to use viewports. This does not ↵Jonathan Gordon1-1/+13
include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-10-06Accept FS#7864 - minor menu cleanup to move theme settings into a new themes ↵Jonathan Gordon1-158/+1
menu. patch to update the manual would be welcome :p git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-09-27FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier.Nicolas Pennequin1-2/+53
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting. The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable. These new settings are a bit controversial so they may be removed later. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-08-26only build the clipcounter for targets with recordingPeter D'Hoye1-2/+7
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-08-25Implement FS #2976: Clip Counter for recording screen. If enabled in peak ↵Peter D'Hoye1-2/+3
meter settings, it shows the number of times clipping occurred (clip indicator going on). Count is reset on recording start and only counts during actual recording. Stays on screen when stopping or pauzing. Also fix a drawing bug when peakmeters start at a non-zero x offset. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-07-22Wheel acceleration for e200. A general acceleration interface intended for ↵Michael Sevakis1-0/+4
use on any scroll target and by any code. A general interface to obtain data associated with most recently dequeued button presses and actions. Use #define HAVE_SCROLLWHEEL and set appropriate constants, values in the scroller driver that feel right. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-06-24Limit minimum db scale value when switching from linear to logaritmic ↵Peter D'Hoye1-0/+4
peakmeter scale. Fixes FS #7325 git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-05-27Accept FS#6798 - scan acceleration for the lists.Jonathan Gordon1-1/+7
Settings are in display > scrolling git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-05-19More header and dead code cleanup.Nils Wallménius1-1/+0
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-04-25Change some ifdefs for the recent backdrop changes (fixes the yellow builds) ↵Nicolas Pennequin1-1/+4
and move the backdrop files. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657