path: root/apps/playlist_catalog.c
AgeCommit message (Collapse)AuthorFilesLines
2020-07-22keyboard add ability to specify temporary custom layoutsWilliam Wilgus1-1/+1
rb core allows you to load custom keyboard layouts this patch adds the ability to load a keyboard layout in a buffer the custom layout is temporary and does not overwrite the current layout use like so: unsigned short kbd[64]; unsigned short *kbd_p = kbd; if (!kbd_create_layout("ABCD1234\n", kbd, sizeof(kbd))) kbd_p = NULL; rb->kbd_input(buf,sizeof(buf), kbd_p); Change-Id: I7be2bd4a1b4797a147fa70228a9749dc56ac052a
2019-08-18Playlist reworkWilliam Wilgus1-11/+19
consolidate some of the playlist create functions remove extensions from playlist naming (you can still add it if you desire) switch to strlcpy, strlcpy functions Change-Id: Ibd62912da4d1f68ed5366baa887d92d4c6b1f933
2019-08-17Playlist Fix failure to append default file nameWilliam Wilgus1-0/+4
FS#12992 - Can't create playlist with all tracks on device (regression) references this issue empty_playlist() only sets filename[0] = '\0' the code was checking filename[1].. bug ensued strip extra leading '/' from default path Change-Id: Ibd8973666ee45583b9e11e3ba317c0e247f085c1
2019-07-10Fix possible truncation playlist_catalog.c->catalog_add_to_a_playlistWilliam Wilgus1-3/+3
Change-Id: Ib142b07916ccca044674e5cabec379316c07e9d9
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis1-1/+1
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested: Michael Sevakis <>
2011-07-20FS#11808 - Major playlist handling changes (on disk playlists)Jonathan Gordon1-6/+35
* Playlists are treated similar to directories in the browser, they now open in the viewer when selected instead of automatically starting the playlist. * Make the "Playlists" main menu item useful, it now displays the playlist catalog (and has been renamed accordingly) * Default to storing playlists in the catalog * Add a UI to move the catalog directory (other minor stuff too) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-07-17Prefill the playlist filename with .m3u8 when creating a new playlist in the ↵Jonathan Gordon1-1/+1
catalog git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-05-15Prefill the playlist name when creating a new playlist from the file ↵Frank Gevaerts1-1/+5
browser. FS#12104 by Ophir Lojkine git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-12-15Rename the NO_CONTEXT flag to NO_CONTEXT_MENU so that the name more clearly ↵Alexander Levin1-1/+1
conveys what the flag does git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-12-15remaining of FS#11777. Use rockbox_browse() to display playlists in Playlist ↵Teruaki Kawashima1-189/+33
Catalog. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-12-06Get rid of get_user_file_path and do the path handling in wrappers for ↵Thomas Martitz1-5/+3
open() and friends. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-10-22simplify rockbox_browse a bit and reuse buffer.Teruaki Kawashima1-1/+3
use const for argument of set_current_file. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-08-27Fix bug adding a playlist to another playlist doesn't finish if it has UTF-8 ↵Teruaki Kawashima1-2/+2
BOM introduced by r24718. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-08-01Rockbox as an application: add get_user_file_path().Thomas Martitz1-2/+8
For RaaA it evaluates user paths at runtime. For everything but codecs/plugins it will give the path under $HOME/.config/ if write access is needed or if the file/folder in question exists there (otherwise it gives /usr/local/share/rockbox). This allows for installing themes under $HOME as well as having config.cfg and other important files there while installing the application (and default themes) under /usr/local. On the DAPs it's a no-op, returing /.rockbox directly. Not converted to use get_user_file_path() are plugins themselves, because RaaA doesn't build plugins yet. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-05-06Move c/h files implementing/defining standard library stuff into a new libc ↵Thomas Martitz1-2/+1
directory, also standard'ify some parts of the code base (almost entirely #include fixes). This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-05-06Make open() posix compliant api-wise. A few calls (those with O_CREAT) need ↵Thomas Martitz1-1/+1
the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-04-01FS#11081 - Hotkey patch. Many targets supported, but some keymaps need work ↵Jeffrey Goode1-1/+1
before they can be switched on git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-02-17playlist catalog: improve UTF-8 BOM handling. correct length of array passed ↵Teruaki Kawashima1-25/+23
to create_playlist_list. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-12-22Fix FS#10368 - add some recursion protection in the "view playlist ↵Jonathan Gordon1-6/+9
catalogue" context menu options. Its not exactly pretty, but this shouldnt happen often. It would be nicer to actually hide the menu item, but slightly difficult to do git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-08-20Make the formatter functions used by the settings return a pointer to avoid ↵Nils Wallménius1-2/+2
usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-14FS#10080Nils Wallménius1-3/+3
* Move strncpy() from core to the pluginlib * Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins * Drop strncpy() from the codec api as no codec used it * Bump codec and plugin api versions git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-05-09Remove unneeded #include "backdrop.h"Bertrik Sikken1-1/+0
Remove unneeded #include "statusbar.h" git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-12-31Decouple the statusbar drawing from the rest of the screen drawing. it is ↵Jonathan Gordon1-4/+0
not drawn roughly 4x per second automatically. viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.) All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false). This commit also includes some menu/list viewport cleanups from kugel in FS#9603 git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-10-12Minor clean up, move common define to a header file and use TIME_AFTER macroNils Wallménius1-1/+0
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-08-15FS#9281 Rename of splash functions.Nils Wallménius1-7/+4
* Remove gui_splash() * Rename gui_syncsplash() to splashf() and remove its voice capabilities. * Rename the internal splash() to splash_internal() and introduce an externally visible splash() that handles simple splashing without printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, "foo"); if a LANG_* id is passed it will be voiced. * Adjust all places that called gui_syncsplash() to use the correct variant from above. * Export both new functions to plugins and adjust places calling rb->splash() to use the correct variant so that we now have naming consistency between the core and plugins. * Fix one latent bug that would cause my sim to crash with the above changes and correct P2STR and P2ID macros, thanks to pondlife. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-07-29Only voice track insertion splash if voice menus enabled - fix for FS#9223Steve Bavin1-2/+2
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-07-15Voice the playlist catalog.Stéphane Doyon1-8/+31
See FS#6323. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg1-2/+4
later. We still need to hunt down snippets used that are not. 1324 modified files... git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-29total removal of gui_textarea. The only thing using the text_message struct ↵Jonathan Gordon1-0/+1
is the yesno screen so move its definition to yesno.h git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-25Fix part of FS#9032 - "create playlist" appends the playlist instead of ↵Jonathan Gordon1-3/+10
overwriting it... not sure about the speed issue. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-12Const police raid.Steve Bavin1-2/+2
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-05-04use the playlist catalog code to generate the playlists under Playlist > ↵Jonathan Gordon1-4/+10
Create playlist git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-04-28Update source files to include the header file for the functions they ↵Bertrik Sikken1-0/+1
implement, to make sure the header and the implementation is consistent (and fix it for a case where it wasn't). git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-04-26Const police raid, making a lot of pointers to lang strings const and ↵Nils Wallménius1-5/+3
removing some ugly casting git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-04-16Use file_exists and dir_exists functions where appropriate, fix one wrong ↵Nils Wallménius1-5/+1
file descriptor check and one possible dir descriptor leak git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-04-09Pass the buffer length to the list_get_name callback functions instead of ↵Nils Wallménius1-2/+2
using hardcoded MAX_PATH git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-03-26the menu and list now accepts a parent viewport to draw in (and the menu can ↵Jonathan Gordon1-1/+1
be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-01-29Move the playlist catalog config into the standard config files. 1 less disk ↵Jonathan Gordon1-25/+6
spinup when the playlist cataloge is used the first time. The manual doesnt currently mention this setting (or ever did). use "playlist catalog directory:/path/to/Playlists" in the .cfg git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-10-30Make the playlist catalog use the following settings as appropriate: show ↵Magnus Holmgren1-12/+16
filename extensions, load last bookmark, party mode and warn when erasing dynamic playlist. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-09-17minor update to gui_synclist_do_button() which will hopefully simplify ↵Jonathan Gordon1-1/+1
things later. Now returns true if the action was handled in that function instead of returning the handled action. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-08-05*** Lang v2 cleanup (FS#6574) ***Nils Wallménius1-6/+1
1) Introduces apps/features.txt that controls which strings are included for each target based on defines. 2) .lng and .voice files are now target specific and the format versions of both these file types have been bumped, which means that new voice files are needed. 3) Use the 'features' mechanism to exclude strings for targets that didn't use them. 4) Delete unused and deprecated and duplicated strings, sort strings in english.lang Some string IDs were changed so translations will be slightly worse than before. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-07-22remove the need for action_signalscreenchange().Jonathan Gordon1-1/+0
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-04-18Move the inbuilt filetype info into filetypes.c and rename the defines. Jonathan Gordon1-4/+5
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-03-16Get rid of the 'center' parameter for splashes. There were only 2 of almost ↵Jens Arnold1-4/+4
500 splashes which were not centered. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2007-02-03Removed unused 'mode' parameter from mkdir() for consistency with creat().Jens Arnold1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2006-12-03Make playlist catalog and playlist save screen handle .m3u/.m3u8 better. ↵Magnus Holmgren1-3/+7
Also fix a possible null-pointer case in the playlist save screen. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2006-11-06dont allow the volume setting to wrapJonathan Gordon1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2006-08-18create the playlist directory instead of warning it doesnt exist when ↵Jonathan Gordon1-4/+10
entering the playlist cataloge git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2006-08-15Finally, the new button action system is here, thanks to Jonathan Gordon. ↵Linus Nielsen Feltzing1-38/+6
Some button mappings have changed and other things may break. Comments should go to the forum, or the mailing list. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2006-07-18Patch #5179 by Sebastian Henriksen and Hardeep Sidhu - Playlist catalogLinus Nielsen Feltzing1-0/+504
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657