summaryrefslogtreecommitdiffstats
path: root/apps
AgeCommit message (Collapse)AuthorFilesLines
2020-07-25mpegplayer: Fix aliasing rules violation on multi-core targetsSolomon Peachy1-3/+5
As the PP series has no sense of cache coherency between its multiple cores, we need to ensure the vo_data structure does not share cachelines with anything else. This was previously done by defining a uint8_t array and trying to access it via typecasting hell, triggering a large pile of aliasing violation warnings on newer toolchains and/or higher optimization levels. Instead of violating the C spec in an undefined-behaviour-sort-of-way, create a union of the right size and alignment, and make one of its members the structure we care about. Voila, everyone is happy. Change-Id: Iad78f8132225437cd4aa10e6e5f6ae58ba996c19
2020-07-25More fixes for English(US)Solomon Peachy1-4/+4
(The translate website screwed up a bit) Change-Id: I293c939b858121f6d82dde037bb5ff1cbcff5d6c
2020-07-24Update French translation (Stéphane Moutard-Martin)Solomon Peachy1-468/+2958
Change-Id: Ibe247553965024a000749386a95e73dcc18c493e
2020-07-25Update English(US) translationSolomon Peachy1-479/+10
Change-Id: Ifb078fa52368b4fb2bff2f00b28ae462a098a881
2020-07-24Plugin Api update with added functionsWilliam Wilgus2-0/+4
Change-Id: I3c48c999da240f68f4960d2e137c613b224beb5c
2020-07-24plugins: HAVE_BACKLIGHT in the test pluginsSolomon Peachy5-8/+22
Change-Id: I97d17805ac7d37f10da6a29684102db97448e653
2020-07-24plugins: More HAVE_BACKLIGHT cleanupSolomon Peachy30-44/+149
Change-Id: I70cf700f5bc3d4375c025efa62ef40fd2bd70293
2020-07-24peakmeter: Fix warning on some hosted targetsSolomon Peachy1-3/+8
Change-Id: Ieae0b08a2f747955ad3e392fbff90884dc4265ef
2020-07-24plugins: Fix the builds for targets lacking HAVE_BACKLIGHTSolomon Peachy7-10/+40
Change-Id: Ifdb1501834b7ea63ca6f731bbd6414305d7e0001
2020-07-24peakmeter: Fix simulator build breakage introduced in 8cb55546Solomon Peachy1-2/+0
Change-Id: I86c327cf7053e71df7550b6d0673262035f95978
2020-07-24plugins: Remove six API functions with no usersSolomon Peachy2-19/+2
statusbars, gui_syncstatusbar_draw(), and set_time() mp3_play_data(), mp3_play_pause(), mp3_play_stop() [mp3_is_playing() is still used by imageviewer] (followup to the sh/archos exorcism..) Change-Id: I06a1d981ffc86b8073fcfa2380a393a07347ab3b
2020-07-24[4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice.Solomon Peachy117-1376/+67
Note: I left behind lcd_bitmap in features.txt, because removing it would require considerable work in the manual and the translations. Change-Id: Ia8ca7761f610d9332a0d22a7d189775fb15ec88a
2020-07-24[3/4] Completely remove HWCODEC supportSolomon Peachy74-4788/+62
'swcodec' is now always set (and recording_swcodec for recording-capable units) in feature.txt so the manual and language strings don't need to all be fixed up. Change-Id: Ib2c9d5d157af8d33653e2d4b4a12881b9aa6ddb0
2020-07-24[2/4] get rid of HAVE_LCD_CHARCELLSSolomon Peachy50-1681/+9
HAVE_LCD_BITMAP is now redundant. lcd_bitmap is always-on in features.txt so manual and lang strings don't have to change Change-Id: I08eeb20de48099ffc2dc23782711af368c2ec794
2020-07-24[1/4] Remove SH support and all archos targetsSolomon Peachy117-18279/+125
This removes all code specific to SH targets Change-Id: I7980523785d2596e65c06430f4638eec74a06061
2020-07-24Slovak language update (From Peter Lecký)archos_retiredSolomon Peachy1-0/+99
Change-Id: Icf80eb628cdc0a4ab6644c05104c0893b45d217f
2020-07-24talk: Force-shutdown the voice system before loading a new voiceSolomon Peachy1-0/+3
Otherwise we might actually be talking when we try to switch, or otherwise trash the state of the running talk thread, leading to memory corruption or an outright crash (This fixes a panic observed on the xDuoo X3) Change-Id: I78e4232085c5c160c9ee4f18167dad8dad2b9287
2020-07-22keyboard add ability to specify temporary custom layoutsWilliam Wilgus37-69/+173
rb core allows you to load custom keyboard layouts this patch adds the ability to load a keyboard layout in a buffer the custom layout is temporary and does not overwrite the current layout use like so: unsigned short kbd[64]; unsigned short *kbd_p = kbd; if (!kbd_create_layout("ABCD1234\n", kbd, sizeof(kbd))) kbd_p = NULL; rb->kbd_input(buf,sizeof(buf), kbd_p); Change-Id: I7be2bd4a1b4797a147fa70228a9749dc56ac052a
2020-07-21build: Tweaks to better support non-English as primary languageSolomon Peachy2-3/+6
* get rid of $(LANGUAGE) in top-level makefile (and configure script) * un-hardcode English-as-primary-language in a couple more places * allow DEFAULT_VOICE_LANG to be overriden To actually change the primary from English, one must change: * $english in voice.pl * hardcoded 'english' in rbutil * $ENGLISH in apps/lang/lang.make * DEFAULT_VOICE_LANG in apps/talk.c * configure script (default prompt) Of course, if one wants to change the default UI language, it's simpler to change the default language setting variable at compile time, or perhaps by adding a configuration file with the desired value into the .rockbox directory when the .zip is assembled. Change-Id: If5cf76019d416e838628a2eccd4ec7d6cbaeeb74
2020-07-21genlang: More voice-related fixes.Solomon Peachy2-2/+2
* Use consistent ID numbering * Use consistent logic for voicelist and voicebin files * Fix situations where English <-> English would fail in strange ways * Delete leftover tmpfile. * Off-by-one error in voice validation code * Off-by-one error in voicelist generation Change-Id: Ib3cea2c6612138b1cbe614dacbe51000199cc9ad
2020-07-20Fix the sea of red introduced in bf546fbSolomon Peachy1-1/+2
Change-Id: Ic158771d8dae6b587e0f567e7a6bb005b5e2ac50
2020-07-21Run-time validation of INT settings.Solomon Peachy1-1/+7
Check against min/max/step parameters Many places this value is used as an index into an array; this will help prevent array overflows and undefined/undesireable behavior. Some fields accept arbitary values, continue to accept those. Change-Id: Idbb5a17b7ceae5500660987703e2d6c16e920c92
2020-07-20menu.c fix redraw bugWilliam Wilgus1-5/+5
fix redraw bug added with c39f95465 Change-Id: I9ce232d4b760f20edb6f8274e090d2fd67c8bd78
2020-07-19Fix the yellow in the player build from c39f95465Solomon Peachy1-1/+4
Change-Id: Iae3a8f4eccd3708b41d43da6e12a3199b1d657c6
2020-07-19Fix more of the red from c39f95465Solomon Peachy1-2/+2
Change-Id: I8c9510774803f7164f7a003575711f3dd980223c
2020-07-19menus: Fix some of the red from c39f95465Solomon Peachy1-1/+1
Change-Id: Ic22123a83bf119605c8ddf686b6a8e21f9555c6a
2020-07-19do_menu pass internal synclist reference to callbackWilliam Wilgus39-110/+343
keep running into the rigid nature of do_menu it isn't too bad when you don't need voice but once you do the fun awaits do_menu likes to talk on menu enter which is in a loop when you use do_menu I would like to move the processing to the callback TOO BAD you only get an action and the menu_item_ex struct you sent it when calling the function Change-Id: Iaefd0cc133435d675b7dd27a558c504d6ccb327a
2020-07-16storage: Clean up storage_xxxx macros when STORAGE_MULTI is not setSolomon Peachy2-3/+3
Change-Id: I1652eac1743f4b8b84da08ea5a6d04ac7e17e21d
2020-07-16statusbar: explicitly #include <button.h>Solomon Peachy1-0/+1
This header relies on stuff that might get defined in button.h, and was reliant upon being implicitly included. The last thing we want is a struct to change layout underneath us! Change-Id: If96451bc5e2219031a592ab82c56045188dbe645
2020-07-15xduoox3: Add HID mappings for multimedia and presentation modesSolomon Peachy1-1/+55
Change-Id: I7264fed77c448db4b54104d81a10e118923c361d
2020-07-14puzzles: always reset input state before pause menuFranklin Wei1-3/+3
We were improperly conditioning the state reset with `do_pausemenu'. We should reset the input state no matter what. Change-Id: Iaafc59b95e9f1f053b57a34f0f28f7c672c0e327
2020-07-14puzzles: more verbose debug output in font loadingFranklin Wei1-3/+38
No functional changes. Change-Id: I7baa7bf37b3bdd57064c654a72d0e4e0d5600245
2020-07-15talk: only show the "failed reading .voice" splash if talking is enabledSolomon Peachy1-1/+2
Change-Id: I4046294e39c621ddeeceeb6f21eab05a1e687cb5
2020-07-15debug ata: Distinguish between Advanced power management and basic PMSolomon Peachy1-1/+4
The old debug menu item covered APM, which is optional in the ATA spec However, despite basic power management being mandatory, several popular ATA/CF->SD adapters do not advertise PM support and have problems when it is used. An earlier patch (g#2500 / 5462907) disabled sleep when the PM capability bit was not set; this makes it visible in the debug menu. Change-Id: I2f3dd1244798d7bbb8239ac159c6470774b0c05e
2020-07-14FS#13215: Russian translation update (Alexander Levin)Solomon Peachy1-147/+99
Change-Id: I0c53ef10b7cd3488176ffd670ab273ba4638e8de
2020-07-14FS#13214: Update Italian translation (Alessio Lenzi)Solomon Peachy1-0/+99
Enable the Italian voice nightly build too. Change-Id: I34f36202714c51ec65d6b5ce288a3e10a2b32f37
2020-07-14Enabled hotkey for Sansa Clip playersIgor B. Poretsky1-4/+3
Change-Id: Ic0fb331415bf0cc0fce5916befce64f4a41c46ee
2020-07-14Pictureflow Bugfixes & Usability fixesWilliam Wilgus1-531/+1208
First I discovered a bug in the code to display the currently playing album from the WPS --on a NULL id3->albumartist field PF would crash now checks for a match in id3->albumartist and then id3->artist if neither exists then the search uses <untagged> ditto for album The album index feature (recently added) did not check for enough room in the buffer on restore --save and restore code cleaned up a bit moved all buffers to their own struct tracks with no title now show filename rather than <UNTAGGED> Reworked album search function album search was going quadriatic resulting in some outrageous index build times [40mins+ for 4000 albums] building now done in stages and duplicates removed at end *MUCH FASTER* Album art empty album art is no longer stored in the art cache PF will now allow you to cancel building album art without forcing a rebuild next run, it will continue searching for album art in the background album art is now updated in the background on each start as well tracklist now rolls over at the end artist_index is now discarded after album_index is created Cleaned up some of the myriad of global variables Added quit prompt for index building Added sanity checking for album_index loaded from disk Change-Id: I8494cb7abcb1ae8645c223fc3c11dc0ee749883a
2020-07-13Fix warnings in Estonian languageSolomon Peachy1-0/+2
Change-Id: I2ec07665a5d09703a67fa13852ed99bfb13d9f6e
2020-07-13lang: Fix boneheaded mistake in ca31bad8Solomon Peachy1-2/+2
Change-Id: Iee3842ab7b5d4660855b683141a45a09c187b29f
2020-07-13voice: Ensure all voicelist files in voicefiles.zip are completeSolomon Peachy1-1/+3
Backfill all missing strings from the English master translation. Change-Id: Ie28f4cf804c22141a2c62f82ed8b2d71c822c74a
2020-07-09Update to allow the Apple Radio Remote to function on iPod Video 5G.LiveboxAndy10-179/+837
This was broken when the major update to iap was comitted. ia-lingo7.c created and various iap related files modified. On 4G, 6G and Nano 1/2Gen iPods the remote will function even though the radio won't. Tested on 4G Greyscale, 4G Color, 4G Photo, 4G Mini 1st Gen, 4G Mini 2Gen, Nano 1G, Nano 2G, Video 5G, Video 5.5G Change-Id: Ia74e3d07d9ab5edc6da8eafa96801ede722be331
2020-07-09voice file not loadingPeter Sealy1-1/+1
> > I ran into an issue where my voice file would only load if I changed language while playing music. It seems to happen because when no other file is open, file.c alloc_filestr returns the first free handle which is 0. In talk.c this is treated as an invalid handle, so the voice file is not loaded. Change-Id: I42db40b10cc7a900bdd72012d99265300e783e44
2020-07-08FS#13211: Updated Serbian Translation (Boris Kovačević)Solomon Peachy1-0/+99
Change-Id: I4c893e3c6394c12067e07b1f3ed00f96b2deee9e
2020-07-08Fix build errors introduced in a2fbccfSolomon Peachy1-1/+1
Change-Id: I413989858432cd206e09d6d71dec07b4f7e06836
2020-07-08playback: Nothing should call ata_spinup_time() directlySolomon Peachy1-1/+1
Change-Id: I9d20b8bfd0f1e47f33ca402f80a9e08bd00fbcd8
2020-07-07puzzles: load cached fonts unconditionallyFranklin Wei1-4/+5
This works around an odd issue in Mines involving the zoom feature. The chain of events leading to it is rather convoluted: 1. No save game is found, so no fonts are loaded from disk. 2. A new game is started. 3. The user selects the "Zoom" option. 4. The allocation of the zoom framebuffer causes the malloc code to grab the audiobuffer. This causes all further font_load() calls to FAIL, due to buflib allocations no longer working. 5. The user goes back to the normal view and uncovers a square. 6. Font loading fails, causing the drawing code to fall back to the system font. 7. An unrelated bug (not yet tracked down) causes font_get(FONT_UI) to return a different font. 8. font_getstringsize() returns the right size of the "wrong" font, leading to centering issues upon rb_draw_text(). The real solution to this would be to fix font_get(), but this fix should prevent the issue from happening if Mines has been run and saved at least once before. Change-Id: Ib9ad51376eeb3ca1113a1f3786124b612db88cd7
2020-07-07FS#9788: Include timestamp in logf filename (Yoshihisa Uchida)Solomon Peachy1-0/+12
For example, logf_202007071157.txt Change-Id: Ia50c0ca67772e3d26b49dd8e1a3519816e5211c6
2020-07-06puzzles: Follow cursor in zoom mode and general code cleanup.Franklin Wei48-25/+834
Frontends now have a way to retrieve the backend cursor position with some changes I've submitted upstream. With this information, we can now follow the cursor around in "interaction mode" while zoomed in, eliminating (most) need for mode switching. Also does some cleanup of the frontend code. Change-Id: I1ba118f67564a3baed95435f5619b73cfa3ae87a
2020-07-07plugin windows_lnk: fix missing return-on-errorSebastian Leonhardt1-0/+1
(found by peachy & clang's static analyzer) Change-Id: Idcc9b3bd0c3c1164892002b8f814d74b4a6b2a2d