summaryrefslogtreecommitdiffstats
path: root/apps
AgeCommit message (Collapse)AuthorFilesLines
2020-07-21build: Tweaks to better support non-English as primary languageSolomon Peachy2-3/+6
* get rid of $(LANGUAGE) in top-level makefile (and configure script) * un-hardcode English-as-primary-language in a couple more places * allow DEFAULT_VOICE_LANG to be overriden To actually change the primary from English, one must change: * $english in voice.pl * hardcoded 'english' in rbutil * $ENGLISH in apps/lang/lang.make * DEFAULT_VOICE_LANG in apps/talk.c * configure script (default prompt) Of course, if one wants to change the default UI language, it's simpler to change the default language setting variable at compile time, or perhaps by adding a configuration file with the desired value into the .rockbox directory when the .zip is assembled. Change-Id: If5cf76019d416e838628a2eccd4ec7d6cbaeeb74
2020-07-21genlang: More voice-related fixes.Solomon Peachy2-2/+2
* Use consistent ID numbering * Use consistent logic for voicelist and voicebin files * Fix situations where English <-> English would fail in strange ways * Delete leftover tmpfile. * Off-by-one error in voice validation code * Off-by-one error in voicelist generation Change-Id: Ib3cea2c6612138b1cbe614dacbe51000199cc9ad
2020-07-20Fix the sea of red introduced in bf546fbSolomon Peachy1-1/+2
Change-Id: Ic158771d8dae6b587e0f567e7a6bb005b5e2ac50
2020-07-21Run-time validation of INT settings.Solomon Peachy1-1/+7
Check against min/max/step parameters Many places this value is used as an index into an array; this will help prevent array overflows and undefined/undesireable behavior. Some fields accept arbitary values, continue to accept those. Change-Id: Idbb5a17b7ceae5500660987703e2d6c16e920c92
2020-07-20menu.c fix redraw bugWilliam Wilgus1-5/+5
fix redraw bug added with c39f95465 Change-Id: I9ce232d4b760f20edb6f8274e090d2fd67c8bd78
2020-07-19Fix the yellow in the player build from c39f95465Solomon Peachy1-1/+4
Change-Id: Iae3a8f4eccd3708b41d43da6e12a3199b1d657c6
2020-07-19Fix more of the red from c39f95465Solomon Peachy1-2/+2
Change-Id: I8c9510774803f7164f7a003575711f3dd980223c
2020-07-19menus: Fix some of the red from c39f95465Solomon Peachy1-1/+1
Change-Id: Ic22123a83bf119605c8ddf686b6a8e21f9555c6a
2020-07-19do_menu pass internal synclist reference to callbackWilliam Wilgus39-110/+343
keep running into the rigid nature of do_menu it isn't too bad when you don't need voice but once you do the fun awaits do_menu likes to talk on menu enter which is in a loop when you use do_menu I would like to move the processing to the callback TOO BAD you only get an action and the menu_item_ex struct you sent it when calling the function Change-Id: Iaefd0cc133435d675b7dd27a558c504d6ccb327a
2020-07-16storage: Clean up storage_xxxx macros when STORAGE_MULTI is not setSolomon Peachy2-3/+3
Change-Id: I1652eac1743f4b8b84da08ea5a6d04ac7e17e21d
2020-07-16statusbar: explicitly #include <button.h>Solomon Peachy1-0/+1
This header relies on stuff that might get defined in button.h, and was reliant upon being implicitly included. The last thing we want is a struct to change layout underneath us! Change-Id: If96451bc5e2219031a592ab82c56045188dbe645
2020-07-15xduoox3: Add HID mappings for multimedia and presentation modesSolomon Peachy1-1/+55
Change-Id: I7264fed77c448db4b54104d81a10e118923c361d
2020-07-14puzzles: always reset input state before pause menuFranklin Wei1-3/+3
We were improperly conditioning the state reset with `do_pausemenu'. We should reset the input state no matter what. Change-Id: Iaafc59b95e9f1f053b57a34f0f28f7c672c0e327
2020-07-14puzzles: more verbose debug output in font loadingFranklin Wei1-3/+38
No functional changes. Change-Id: I7baa7bf37b3bdd57064c654a72d0e4e0d5600245
2020-07-15talk: only show the "failed reading .voice" splash if talking is enabledSolomon Peachy1-1/+2
Change-Id: I4046294e39c621ddeeceeb6f21eab05a1e687cb5
2020-07-15debug ata: Distinguish between Advanced power management and basic PMSolomon Peachy1-1/+4
The old debug menu item covered APM, which is optional in the ATA spec However, despite basic power management being mandatory, several popular ATA/CF->SD adapters do not advertise PM support and have problems when it is used. An earlier patch (g#2500 / 5462907) disabled sleep when the PM capability bit was not set; this makes it visible in the debug menu. Change-Id: I2f3dd1244798d7bbb8239ac159c6470774b0c05e
2020-07-14FS#13215: Russian translation update (Alexander Levin)Solomon Peachy1-147/+99
Change-Id: I0c53ef10b7cd3488176ffd670ab273ba4638e8de
2020-07-14FS#13214: Update Italian translation (Alessio Lenzi)Solomon Peachy1-0/+99
Enable the Italian voice nightly build too. Change-Id: I34f36202714c51ec65d6b5ce288a3e10a2b32f37
2020-07-14Enabled hotkey for Sansa Clip playersIgor B. Poretsky1-4/+3
Change-Id: Ic0fb331415bf0cc0fce5916befce64f4a41c46ee
2020-07-14Pictureflow Bugfixes & Usability fixesWilliam Wilgus1-531/+1208
First I discovered a bug in the code to display the currently playing album from the WPS --on a NULL id3->albumartist field PF would crash now checks for a match in id3->albumartist and then id3->artist if neither exists then the search uses <untagged> ditto for album The album index feature (recently added) did not check for enough room in the buffer on restore --save and restore code cleaned up a bit moved all buffers to their own struct tracks with no title now show filename rather than <UNTAGGED> Reworked album search function album search was going quadriatic resulting in some outrageous index build times [40mins+ for 4000 albums] building now done in stages and duplicates removed at end *MUCH FASTER* Album art empty album art is no longer stored in the art cache PF will now allow you to cancel building album art without forcing a rebuild next run, it will continue searching for album art in the background album art is now updated in the background on each start as well tracklist now rolls over at the end artist_index is now discarded after album_index is created Cleaned up some of the myriad of global variables Added quit prompt for index building Added sanity checking for album_index loaded from disk Change-Id: I8494cb7abcb1ae8645c223fc3c11dc0ee749883a
2020-07-13Fix warnings in Estonian languageSolomon Peachy1-0/+2
Change-Id: I2ec07665a5d09703a67fa13852ed99bfb13d9f6e
2020-07-13lang: Fix boneheaded mistake in ca31bad8Solomon Peachy1-2/+2
Change-Id: Iee3842ab7b5d4660855b683141a45a09c187b29f
2020-07-13voice: Ensure all voicelist files in voicefiles.zip are completeSolomon Peachy1-1/+3
Backfill all missing strings from the English master translation. Change-Id: Ie28f4cf804c22141a2c62f82ed8b2d71c822c74a
2020-07-09Update to allow the Apple Radio Remote to function on iPod Video 5G.LiveboxAndy10-179/+837
This was broken when the major update to iap was comitted. ia-lingo7.c created and various iap related files modified. On 4G, 6G and Nano 1/2Gen iPods the remote will function even though the radio won't. Tested on 4G Greyscale, 4G Color, 4G Photo, 4G Mini 1st Gen, 4G Mini 2Gen, Nano 1G, Nano 2G, Video 5G, Video 5.5G Change-Id: Ia74e3d07d9ab5edc6da8eafa96801ede722be331
2020-07-09voice file not loadingPeter Sealy1-1/+1
> > I ran into an issue where my voice file would only load if I changed language while playing music. It seems to happen because when no other file is open, file.c alloc_filestr returns the first free handle which is 0. In talk.c this is treated as an invalid handle, so the voice file is not loaded. Change-Id: I42db40b10cc7a900bdd72012d99265300e783e44
2020-07-08FS#13211: Updated Serbian Translation (Boris Kovačević)Solomon Peachy1-0/+99
Change-Id: I4c893e3c6394c12067e07b1f3ed00f96b2deee9e
2020-07-08Fix build errors introduced in a2fbccfSolomon Peachy1-1/+1
Change-Id: I413989858432cd206e09d6d71dec07b4f7e06836
2020-07-08playback: Nothing should call ata_spinup_time() directlySolomon Peachy1-1/+1
Change-Id: I9d20b8bfd0f1e47f33ca402f80a9e08bd00fbcd8
2020-07-07puzzles: load cached fonts unconditionallyFranklin Wei1-4/+5
This works around an odd issue in Mines involving the zoom feature. The chain of events leading to it is rather convoluted: 1. No save game is found, so no fonts are loaded from disk. 2. A new game is started. 3. The user selects the "Zoom" option. 4. The allocation of the zoom framebuffer causes the malloc code to grab the audiobuffer. This causes all further font_load() calls to FAIL, due to buflib allocations no longer working. 5. The user goes back to the normal view and uncovers a square. 6. Font loading fails, causing the drawing code to fall back to the system font. 7. An unrelated bug (not yet tracked down) causes font_get(FONT_UI) to return a different font. 8. font_getstringsize() returns the right size of the "wrong" font, leading to centering issues upon rb_draw_text(). The real solution to this would be to fix font_get(), but this fix should prevent the issue from happening if Mines has been run and saved at least once before. Change-Id: Ib9ad51376eeb3ca1113a1f3786124b612db88cd7
2020-07-07FS#9788: Include timestamp in logf filename (Yoshihisa Uchida)Solomon Peachy1-0/+12
For example, logf_202007071157.txt Change-Id: Ia50c0ca67772e3d26b49dd8e1a3519816e5211c6
2020-07-06puzzles: Follow cursor in zoom mode and general code cleanup.Franklin Wei48-25/+834
Frontends now have a way to retrieve the backend cursor position with some changes I've submitted upstream. With this information, we can now follow the cursor around in "interaction mode" while zoomed in, eliminating (most) need for mode switching. Also does some cleanup of the frontend code. Change-Id: I1ba118f67564a3baed95435f5619b73cfa3ae87a
2020-07-07plugin windows_lnk: fix missing return-on-errorSebastian Leonhardt1-0/+1
(found by peachy & clang's static analyzer) Change-Id: Idcc9b3bd0c3c1164892002b8f814d74b4a6b2a2d
2020-07-062048: use larger bitmaps on 96x96 screens (e.g. Clip Zip)Franklin Wei1-1/+1
Apparently the smallest bitmaps are hard to see. Change-Id: I0265ce4da15677f9c4c64457b1a1f849a0f3a7f8
2020-07-05portalplayer: Fix three set-but-not-used warnings.Solomon Peachy1-0/+1
(They show up when building with gcc494) Change-Id: Id5e2bccf18114ed78a557ac1b369f46b4f07d042
2020-07-02puzzles: enhancements to mouse mode, zoom featureFranklin Wei1-65/+94
- zoom now remembers position between activations (but not when exiting the plugin) - key repeat enabled when panning - moving mouse out of frame while zoomed will pan - mouse can be moved diagonally Change-Id: I39380ef7f36238700b6baa54cac036832933df67
2020-07-02FS#13208: More Polish language improvements (Adam Rak)Solomon Peachy1-98/+98
Change-Id: I7938375711703a545c8c555232db37e34b893e64
2020-06-30imageviewer: Fix potential null pointer dereferenceSolomon Peachy1-4/+6
(caught by clang-analyzer) Change-Id: Ie24b7cd75c5e9814007674925f33b1a321f1d06d
2020-06-30fractals: Clean up ARM asmSolomon Peachy1-4/+4
No functional change, just using modern syntax. Change-Id: I211bbcebd11da168c81dff4c409112d7a535b6ed
2020-06-30Fixed system state information loss when it is saved in fileIgor B. Poretsky1-1/+5
Change-Id: If2aca712af4152e144ec919cfc4b4d9cb23bf4f2
2020-06-28Update American English translationSolomon Peachy1-0/+99
Change-Id: If25a242a3d4d47eff577547dea03325d6d3e135c
2020-06-28FS#13207: Update Polish Translation (Adam Rak)Solomon Peachy1-0/+99
Change-Id: I0168eef494670ce9329a8eb9efc296f84187ac0d
2020-06-27puzzles: clean up and document some voodooFranklin Wei1-17/+55
Change-Id: I13d987cc148f053778474e99c719cc8439ec53c0
2020-06-27puzzles: fix crash when loading a corrupt saveFranklin Wei1-2/+1
I misread the documentation here, thinking that the pointer would be set to *point to* a null byte, not to a null pointer itself. [1] [1]: https://www.chiark.greenend.org.uk/~sgtatham/puzzles/devel/midend.html#identify-game Change-Id: I9b76bba9b1611dfd8e05d076a69f7554b5b74c53
2020-06-27puzzles: refuse to draw non-ASCII charactersFranklin Wei1-3/+34
We had some issues in Keen with the arithmetic operators not being rendered properly. This is still a kludge (we should intelligently search the font) but is still less ugly than the garbage it was drawing before. Change-Id: I5b957c7371b659ea6d64847145f9913b2a892e48
2020-06-27puzzles: replace menu title kludge with more elegant solutionFranklin Wei1-19/+8
This hack has survived for far too long. Change-Id: Idca0b647bd6e77f2afcd9a538513a6b9aa970fc7
2020-06-27puzzles: disable software poweroff in all puzzlesFranklin Wei1-1/+8
We have a couple games like Untangle and mouse-mode games in which the software poweroff is very annoying. Change-Id: I554b89aecf8c7cc20c6c7f305be1b8807dc9283b
2020-06-27button: allow disabling software poweroffFranklin Wei4-2/+35
On some devices, the button driver allows a "software poweroff" by long- pressing a certain key. This behavior is inconvnient when that button needs to be held down for other purposes, such as moving the cursor in rockpaint or sgt-untangle. This patch allows selectively disabling the software poweroff (enabled by default) from both core and plugin code. Change-Id: I7580752888ae5c7c7c5eb1be5966e3d67f17d4b4
2020-06-27puzzles: allow secondary select in Rectangles and MapFranklin Wei1-3/+11
Change-Id: Ia32d41cd872140481e73b7565904fc196b7c5b01
2020-06-26Pictureflow Whitespace CleanupWilliam Wilgus1-11/+8
Change-Id: I7cda111a8d7a24cae31e3eeca1454480e27ebaaa
2020-06-26Pictureflow Fixes UniqBufWilliam Wilgus1-18/+22
rework of the unique name buffer shares 1/4 of the total buffer Change-Id: I17e46292ac880a082cb3f035e3c21abc318d8a31