Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I6b35bcdc4e676e81faf5353ca01ba4bd728ffb14
|
|
Change-Id: I6e3bae2a893c932b67b4b5a7c4bf46060e5dc32a
|
|
We don't need two names for the same 1-bit field.
Change-Id: I71ed61198da8d6e4bf4d449d8704982918099f7d
|
|
in some calls to generate_bookmark_file_name()
len gets specified in order to not NULL terminate the buffer string
unfortunately, I missed the root_dir case in g#4839
Change-Id: I24d1360bbe72e6a1b2ed3332ff5854d039d58ca5
|
|
Still having problems with determining the type of track change
lets try just watching the audio_next/prev functions
Change-Id: Ie4233ff4d4bf49792a6549d7bcd169ff4b1afd20
|
|
Change-Id: I7d70b4f0d6fd574575298b0709e78b9096801c07
|
|
Change-Id: I20e98d1e7cf13a59194f62935a8f46e96f83a1f9
|
|
....Because INT and BOOL are already defined in mingw32.
Change-Id: I28ab8189c00002c8f68bc9d0c23d2ae78d9e33d0
|
|
Since this function already requires hitting the
disk, it may make sense to turn it into a plugin.
A minor advantage (apart from cleaning up onplay.c
and saving RAM) is that you can now access the menu
not just from the WPS context menu, but also from
the Shortcuts Menu or using the WPS plugin shortcut.
On the other hand, TSR plugins would have to be
terminated when Playing Time is launched, as is
already the case for other plugins such as PictureFlow.
Change-Id: Iea85229486887463ffc52f05e33e2340437f69a4
|
|
The suggested name was identical to the complete path
of the played folder, with a slash at the end, which,
if accepted, resulted in a file called only ".m3u8"
being saved there.
In case the path contained one or more dots, the string
was also stripped of the last dot and all chars following it.
Use Playlist Catalogue as the destination folder instead,
and pick last path component as the file name.
Change-Id: Ia2b7f7ebca746613d650bbab6d7a62ca1106efc6
|
|
After saving a playlist to an existing file with
a different name, any saved bookmarks for the old
playlist were still displayed for the new one.
Change-Id: Ic2666bdaf7ec6e25456283fc15760c568dd7ac38
|
|
Long button presses to create a new file
were in conflict with button presses to
play/pause.
Pressing SELECT is now used to create a new file
(and start recording, if stopped),
pressing PLAY/PAUSE will start or pause recording.
Change-Id: If2e568b9b05500d73fd54b691262a64d1a0ff487
|
|
Fixes FS#13372
Change-Id: Ia50f5252cb8375a97c093abeda89d830bf003ff3
|
|
I recently added track skipping while REPEAT_ONE was set
currently by registering a track skip callback
I'm not entirely happy with the additional constant overhead
of the event callback
Instead I went looking for a way to distinguish
a pending track skip from some limited testing
it appears to work just as well to compare
playback's skip_pending == TRACK_SKIP_AUTO
but the lack of lifetime control worries me slightly
Change-Id: Ic71b4c3925e991f5a1216d16ecd3af6cc777ef1e
|
|
repeat one till manually skipped
https://forums.rockbox.org/index.php/topic,54218.0.html
Change-Id: If2ea1cd892531c735c30c428dea3678806283a3b
|
|
cheap insurance
Change-Id: I8b1fccfda55350a2197cbc261b06a8c8c9dd9c65
|
|
No functional changes
Change-Id: I0409b76258ce8af5aa9c2e68a2070b6e25927d1c
|
|
the flag I chose was already used for nvram settings
moved both CB flags to unused flags
Change-Id: I9fdbc88460b08654a06b4d5950712947eab04b79
|
|
open an insert context
add tracks using the opened context
release opened context and sync the playlist
Change-Id: Idea700ffcf42a38dc23e131c92a6c5d325833170
|
|
A frequency change didn't go into effect immediately
when a user picked "Auto" for the sample rate, while
playback was paused
Change-Id: I254853b664c5b6812264fdaf81dfb8fbfff43dbf
|
|
See Settings -> General Settings -> Display -> LCD Settings -> Backlight on Lock
Change-Id: I201cb1c2907bb6842bf5d0b7a657e9db27aa905a
|
|
Change-Id: Ia9a3ded95b0e50cda3497310472564f3ee3563fb
|
|
Change-Id: Ie2397de29e87dfb1d2fb73cb6eb42c94fdfbf356
|
|
moves the callback to settings_list
audio_set_playback_frequency now accepts an actual frequency
44100 192000 etc rather than an index
Change-Id: Ieb3fc79a7fe3f1ff050465c8cd8061027e4572ff
|
|
Recently I added F_CB_ON_SELECT_ONLY_IF_CHANGED in conjunction
with the shuffle and repeat settings
instead it makes more sense to make F_CB_ONLY_IF_CHANGED
and apply to all callbacks (F_CB_ON_SELECT_ONLY or on_exit)
Change-Id: I4376557d479aceb419f7b4b4e0998afc249c87ec
|
|
Change-Id: If7b03220c466ccf3f27cdf13d2e0b50d6a312bdc
|
|
shuffle and sort were called on startup before playlist_init
and also on setting switch even without select
repeat is also now handled in settings_list as well
after moving the callbacks to settings_list.c
there was then a problem of unintended callbacks on exit of the menus
fixed that with F_CB_ON_SELECT_ONLY
since the callback was called regardless of the setting being changed
on F_CB_ON_SELECT_ONLY which is preferable in some circumstances
I co-opted F_TEMPVAR to allow the callback only when the setting was changed
with the flag F_CB_ON_SELECT_ONLY_IF_CHANGED
Change-Id: I5265233bbb556dc06c45273e742be5d78510a806
|
|
Setting in shortcut was not being handled as it had no callback.
In the settings menu it looks like the event is handled separately.
Added a shuffle callback to the setting so it is called when changed
from the shortcut.
Edit: move callback to within settings_list so playlist interface is
unchanged.
Change-Id: I3691acac1c73a80bf67c0b8b334009ef1655fdb0
|
|
Rockbox doesn't support HW codec anymore
Change-Id: Ia20d3f02f0d9db88b23cf9074e4d76aa21fd53b0
|
|
Change-Id: Ia258f1d111cedf9698538a38a1b949a43199b92c
|
|
add_indices_to_playlist() wrongly assumes playlist->utf8 means
the playlist has a UTF-8 BOM. It only means the file is UTF-8
encoded, and says nothing about the presence of a BOM.
Trying to seek past a BOM when there is none mangles the first
filename in the playlist. Avoid this by closing & reopening the
playlist, which ensures the BOM (or lack of it) gets detected
properly.
Change-Id: I222fa6fc31e941d0252f1895b393a51694b93b7c
|
|
Have get_track_filename() read track seek offset & insert type
itself to avoid duplicating code. Most callers are not interested
in that information, and only use it to call get_track_filename().
Change-Id: I46d50fda10e515f74e27eebdded8e281bbf4456f
|
|
It was only used in filetree.c. It's still implemented in Lua so
scripts using rb.playlist_add() won't break, but has been removed
from the Lua API "backend".
Change-Id: I5625a47f0692456008c6b10dee14755151d22f29
|
|
The file name for a track in the database has been
retrieved already, before its context menu is displayed,
or a hotkey is executed, see:
https://github.com/Rockbox/rockbox/blob/8a22d2678a9fff97fd159a4b2eb45e637f08c79f/apps/tree.c#L811
So, skip over tagtree_current_playlist_insert and instead
use playlist_insert_track() directly, when user selects
something from the "Playing Next" menu or uses a hotkey.
Change-Id: Ie0789d8314949e9872bf261634d81b96432ccda3
|
|
Change-Id: I44cd89f4a4dca1ab9c6134b6a1bf16328d233c0e
|
|
Change-Id: I785d1dd05ac8ef81d817cdd1f7d1867c158bfadf
|
|
Change-Id: Ife0f1be20c681c153163233569933348b06d5c32
|
|
Playlist Viewer, when quitting, should not ask
you to save a playlist that hasn't been modified
since it was last saved.
Change-Id: Ia401239392ba5f2d66562a991ba49b01c6c2d452
|
|
When saving a playlist to an existing file on disk,
warn user, unless the playlist's file name remains
unchanged.
Change-Id: I10d82667de5fadb5323be4f981bea9263849f07a
|
|
Just for good measure
Change-Id: I9dc25b2fd687da2b1fddf31ce1c1ea8895e4399c
|
|
Properly update displayed playlist index and all available
metadata for the currently playing track. Also exit screen
when playlist has finished to prevent nonsense data from
being displayed.
Change-Id: Iecc53c0eda5cbd374b51827a25916ee4e2c6456f
|
|
Backdrop images loaded using %X(filename) already had
dithering enabled, but images loaded using the %x tag
in viewports annotated with %VB did not.
Change-Id: I9c6d11d8e7ab41a53eb9e453d78ae0dc58cb947b
|
|
Change-Id: I56b905e6ae776eb34af7a44caf61e1839bcfbfa7
|
|
Change-Id: Ifad2ecb526c1f2ba5c554601003049915877fcdd
|
|
The "Playing Next..." menu couldn't display any
options for shuffling tracks of an album before
Change-Id: I54f4497394fb29877bf8bce0ef95a27c82eb2279
|
|
If "Show Queue Options" was set to "in Submenu",
the queue options would incorrectly appear at
the top level after you had queued a track, at
least until you entered and exited the submenu
again without selecting an option.
Change-Id: I59abd73de7e3634bc8701aa2288b56bde7552513
|
|
On all players, it should be possible to return from the Main Menu
by pressing the Back or Menu key. Unless I'm missing something...
"Clear Playlist" has hopefully become superfluous after the "Playing Next"
context menu was added, which offers similar functionality.
Change-Id: I741544978fb7936b8d5a34dfc656472e20c1737e
|
|
Change-Id: I6a703265398db14ac9c83a51091184492123e1fb
|
|
After launch, PictureFlow always goes to the currently playing
album, or to a selected album, if applicable. Which is probably
a useful default, but not always wanted. You can now get back
to the album you were looking at when PictureFlow was last
closed, or when the sorting was last changed.
Change-Id: Iba3e0d5388f6b49534d09fe0224b0dbfa65d5f1d
|
|
This lets players that can't spare any keys scroll through
albums without leaving the track listing first, which was
only possible on the M3K before.
Enter mode from Main Menu. While active, the gradient
highlighting an album's selected track will not appear,
and context menu options apply to the whole album
instead of to a single track.
Exit mode by pressing buttons for Select/Back, or by
quitting PictureFlow.
NB: Be sure to enable "Database in RAM" for a good
experience, as the loading time for each album can
become quite annoying otherwise.
Change-Id: Id6c9a8cc49e4cfb2aea958610b95a19887f496b6
|