path: root/firmware/common
AgeCommit message (Collapse)AuthorFilesLines
2014-09-02Clean up a bit and get switch statement out of loop in walk_path()Michael Sevakis1-38/+31
It's nicer to look at and it obfuscated a bug where it should have exited the loop instead of the case (you probably wouldn't observe the effect very often). Change-Id: I33f3c72c8bb7e11b9d418f66cf84efc3082a37b4
2014-09-01Fix a small late creep-in goof in path parsing on native targetsMichael Sevakis1-3/+6
Anything of one dot and one character (e.g. ".a") would get treated as "." because I left out a condition when converting to recursionless parsing of relative components. Git 'er fixed up. Change-Id: Id5603ce0858b419dc08b1d496b4b187a573595f9
2014-08-29Hopefully fix most of the errors and warnings from the last pushMichael Sevakis2-6/+25
Change-Id: I1a466b2d55f120796910039a0296ca324c58e891
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis12-2983/+6732
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested: Michael Sevakis <>
2014-08-28Prevent spurious recompiles on account of changed version.Michael Sevakis1-1/+1
After a local commit, any file that included version.h would have to be recompiled on account of the changed version string. This changes version.h in the build directory to rbversion.h and includes the preprocessor macro from rbversion.h in firmware/common/version.c so that only that one file needs to be recompiled after a local commit rather than a whole slew of them. Change-Id: I900d97e3a24a0610698283416d97b4fa3a3a2cf6 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested: Michael Sevakis <>
2014-08-16Add common linked list functionsMichael Sevakis1-0/+312
Forms implemented to a greater or lesser degree at the moment: ll_* = singly-linked list lld_* = doubly-linked list lldc_* = doubly-linked circular list Change-Id: Ieed5af50fc59165c8b14c3513b3b5d0e6f7de9fa
2014-07-07crc-mi4: use const lookup table for crcMarcin Bukat1-30/+45
This doesn't touch external tools as I see no need for. Change-Id: Ia69248c4b6a033c3772916525257e3540bddcffa Reviewed-on: Tested: Sebastian Leonhardt <> Reviewed-by: Marcin Bukat <>
2014-02-28application(ypr0): Fix mount option selected by the current codepage.Thomas Martitz1-16/+16
A missing comma messed the lookup table up :'( Be aware that the kernel on the ypr0 doesn't support many codepages in which case its default (iso8859) will be used. Change-Id: Iaa4a4b8338fb047d29f6a4e2a80eba5c296d27ce
2014-02-26application: fix opendir() for "/" directory.Thomas Martitz1-1/+1
"/" couldn't be opened. This regression was introduced by 731072d. Trailing slash should not be stripped for the root directory. Change-Id: Idd2d9b1f33e7be789bcf432e586e6715eb4152f4
2014-02-25application: Remove trailing slashes from the input in opendir().Thomas Martitz1-4/+8
This is needed for readdir() and dir_get_info() to work properly because they depend on hash/path matching. Change-Id: Ibd23def10eebabd76cdddac2739a5274159e88a9
2014-02-24application: Speed up dir_get_info() further.Thomas Martitz1-18/+23
It's quite rare that it is called for a symlink to a directory. But it only needs a second syscall to stat() if that happened. Therefore speed up the common case by avoiding an unecessary second syscall. Change-Id: I911105f76631ebccc7696a1540e9cf069a706000
2014-02-24hosted/multidrive: Speed up readdir()/get_dir_info().Thomas Martitz1-14/+35
The two functions need to check whether they are called for a specific path to implement the virtual mount point for the external storage. This is statistically rare and a hit on the common case. Therefore speed up the common case by performing integer comparision first, and only expensive string construction and comparision if that succeeds. Change-Id: I3c41fe073e1f4f8eb62d2b8556a36937c9cb8290
2014-02-23samsungypr0: Support or mounting the microsdThomas Martitz1-23/+94
A thread polls the appropriate GPIO pin for sd card presence and mounts using the mount system call. Change-Id: I31ab41c4120f4af64eb6998b7e7b6f9051585efb
2014-02-23RaaA: Move directory related stuff from filesystem-unix.c into rbpaths.c.Thomas Martitz2-53/+122
Part of this change is to align sdlapp builds to other application targets in that the sim_* wrappers are not used anymore (except for sim_read/write). Path mangling is now done in rbpaths.c as well. Change-Id: I9726da73b50a83d9e1a1840288de16ec01ea029d
2014-02-23codepages: Translate to linux codepage names for use on APPLICATION.Thomas Martitz1-0/+29
The iocharset mount option names the codepages slightly differently and must be translated properly. Change-Id: I147a256e3453136282244201c27225a30cdfdca0
2014-02-05Samsung YP-R1 target portLorenzo Miori1-2/+2
This is the basic port to the new target Samsung YP-R1, which runs on a similar platform as YP-R0. Port is usable, although there are still some optimizations that have to be done. Change-Id: If83a8e386369e413581753780c159026d9e41f04
2014-01-16buflib: Add crc field protecting buflib cookie integrityMarcin Bukat1-2/+2
This should catch the case of buffer misuse which results in corrupted cookie of next allocation. The check is performed on move_block() so it may be a bit late. There is buflib_check_valid() provided which checks the integrity of all cookies for given context. On DEBUG build with --sdl-thread this check is carried out for core_ctx on every context switch to catch problems earlier. Change-Id: I999d4576084592394e3dbd3bdf0f32935ff5f601 Reviewed-on: Reviewed-by: Thomas Martitz <>
2013-11-20Introduce volume_{present,removable} and fix invalid calls in apps/Amaury Pouly1-0/+16
The code was trying to probe for volume presence by calling drive layer with volume index. It is a miracle it get unnoticed so far. Introduce proper volume probing using the vol->drive map in the disk layer. Change-Id: I463a5bcc8170f007cad049536094207d2ba3c6fc Reviewed-on: Reviewed-by: Amaury Pouly <>
2013-08-17Cleanup MV/MD macros a little.Michael Sevakis4-13/+13
When using variadic macros there's no need for IF_MD2/IF_MV2 to deal with function parameters. IF_MD/IF_MV are enough. Throw in IF_MD_DRV/ID_MV_VOL that return the parameter if MD/MV, or 0 if not. Change-Id: I7605e6039f3be19cb47110c84dcb3c5516f2c3eb
2013-06-27Move load_firmware() to separate fileMarcin Bukat2-0/+178
The idea is to share loading code between bootloaders and rolo(). Change-Id: I1656ed91946d7a05cb7c9fa7a16793c3c862a5cd Reviewed-on: Reviewed-by: Marcin Bukat <>
2013-01-15fix yellow on simulator + multivolumeAmaury Pouly1-0/+2
Change-Id: Idc6d0e2e8fb06c2df4cac13ad7253b0b8628c308
2012-07-31Fix database tool.Thomas Martitz1-1/+1
It was also broken functionally, probably since a while.So restore the functionality. Run it on the dap, the tcd files will be placed into .rockbox folder. Change-Id: Id7a6ce4389dfaf99799258902be80d630af0601c
2012-05-19Add support for cp1252 (Western European) codepage.Dominik Riebeling1-3/+6
In Europe Windows defaults to its own codepage cp1252 (also known as "WinLatin" or "Windows-1252"). cp1252 adds some characters to ISO-8859-1. Some mp3 tagging software on Windows uses cp1252 instead of ISO-8859-1. This violates the ID3 specification, which requires tags to be ISO-8859-1 or Unicode. However, similar violations are made for other codepages and supported by Rockbox using the "Default Codepage" setting. Add support for cp1252 to enable people using such broken tools to override the correct decoding to get their tags displayed properly. Change-Id: I9f2ec478afe2503e99ee8e6609416c92b0f453e0 Reviewed-on: Reviewed-by: Jens Arnold <> Tested-by: Jens Arnold <>
2012-04-12Calculate day-of-week after reading time from RTC. Should fix FS#11814Bertrik Sikken1-0/+1
Change-Id: I31dc0b0db5272d16ae55790252e3963e1a91d5bb
2012-03-04Add RKW firmware file format loaderMarcin Bukat1-0/+111
Change-Id: I5283fdcdb8d263fd9375a6d29396f82650aeb686
2012-03-03Disable some more sim_ and app_ redirection for __PCTOOL__.Frank Gevaerts1-2/+2
This makes checkwps build again for apps Change-Id: I6fcd299076bd201053012d09e208a0845c2145e2
2012-02-10checkwps: Fix and some RaaA/ypr0 versions.Thomas Martitz1-2/+2
Change-Id: I5889743e94ed568c8f7dcc50de0b03b8421969f7
2012-01-22Move optimized ffs to firmware/asm, using the new automatic-asm-picking ↵Thomas Martitz1-56/+0
infrastructure. Change-Id: I5e7bdc8be7de50ef604c16078857fff1b84650dc
2012-01-22Move optimized memcpy and friends and strlen to firmware/asm,Thomas Martitz1-78/+0
using the new automatic-asm-picking infrastructure.
2012-01-21android/ypr0: Merge fs-*.c to generic filesystem-unix.c.Thomas Martitz1-9/+5
Change-Id: I52e2c29346baf0d282243880477cd149311ce3d1
2011-12-25rbpaths: Add new special dir HOME_DIR for RaaA.Thomas Martitz1-38/+30
HOME_DIR is intended for not-so-advanced files which shall be user visible, and thus not in /.rockbox. Therefore HOME_DIR is translated to $HOME on RaaA, /sdcard on android, the internal memory on ypr0 and "/" on native targets. ROCKBOX_DIR ("/.rockbox") already existed as special and is translated to whatever the real rockbox dir is on the target (e.g. /sdcard/rockbox on android), but it's not suitable for some files we generate (e.g. battery-bench.txt). git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-24Initial commit of the Samsung YP-R0 port.Thomas Martitz1-0/+34
This port is a hybrid native/RaaA port. It runs on a embedded linux system, but is the only application. It therefore can implement lots of stuff that native targets also implement, while leveraging the underlying linux kernel. The port is quite advanced. User interface, audio playback, plugins work mostly fine. Missing is e.g. power mangement and USB (see SamsungYPR0 wiki page). Included in utils/ypr0tools are scripts and programs required to generate a patched firmware. The patched firmware has the rootfs modified to load Rockbox. It includes a early/safe USB mode. This port needs a new toolchain, one that includes glibc headers and libraries. can generate it, but e.g. codesourcey and distro packages may also work. Most of the initial effort is done by Lorenzo Miori and others (on ABI), including reverse engineering and patching of the original firmware, initial drivers, and more. Big thanks to you. Flyspray: FS#12348 Author: Lorenzo Miori, myself Merry christmas to ypr0 owners! :) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-19disk: fix sector multiplier init, also remove a test which has became obsoleteAmaury Pouly1-3/+2
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-16Remove USB time sync code when there's no RTC.Boris Gjenero1-0/+2
Without an RTC, Rockbox doesn't keep time. In that situation, USB time sync previously did nothing but reported success. After this change, the USB time sync request won't be recognized on those targets. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Remove conditional added around set_day_of_week in r31301.Boris Gjenero1-2/+0
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Add conditionals around functions that are only needed when RTC is present.Boris Gjenero1-0/+4
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Really fix redAmaury Pouly1-0/+2
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Fix redAmaury Pouly1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Add support for for per-drive logical sector size. This allows targets to ↵Amaury Pouly1-3/+13
have a different logical sector size for the internal storage and the sd card, like on the fuze+ for example. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-05Try $RBROOT before $HOME when looking for the sdl apps rockbox root dirJonathan Gordon1-2/+8
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-04Compile fix for mingw-w64Rafaël Carré1-0/+4
Don't build str(n)casecmp as functions if they are already defined by preprocessor git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-11-19Update some missed pointers when moving the dircache allocationFred Bauer1-12/+14
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-11-17Simulate usb plugging on the sim better using sim_tasks.Thomas Martitz1-2/+0
Now all threads need to ack the connection like on real target, dircache is unloaded and playback stops accordingly. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-10-28Fix FS#12325 - screen corruption on early usb.Thomas Martitz1-5/+13
When booting with USB inserted, the dircache build can get interrupted by the usb connection, in which case the dircache buffer is freed. Due to a bug the re-creation of dircache used the old freed buffer and overwrite new allocs (causing screen corruption). Set allocated_size to 0 to make it not take the code path that assumes an existing buffer, and bring that and freeing together in the code. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-10-21fix sign errorFred Bauer1-4/+4
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-10-02revert r30566 and r30567 to fix FS#12294 (superfloppy not mounting)Robert Kukla1-2/+13
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-09-17Also remove the fat_partition_types array.Torne Wuff1-10/+0
If we aren't going to check for the partition type, we don't need the array of known FAT partition types. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-09-17Allow any partition type, not just known FAT types.Torne Wuff1-3/+2
Instead of only mounting partitions with a FAT partition type, try any partition that isn't type 0 (unallocated) or 5 (extended). This makes it easier to reformat SDXC cards which have the exFAT partition type, and also brings us in line with pretty much every other OS at this point. Anything with a valid-looking FAT superblock will get mounted. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-08-30Dircache: Allow dircache to be enabled without reboot.Thomas Martitz1-30/+66
Also add two dircache function, one of which does what dircache_disable() did previously as this now also frees the dircache buffer. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-08-30GSoC/Buflib: Enable compaction in buflib.Thomas Martitz1-29/+85
This enables the ability to allocate (and free) memory dynamically without fragmentation, through compaction. This means allocations can move and fragmentation be reduced. Most changes are preparing Rockbox for this, which many times means adding a move callback which can temporarily disable movement when the corresponding code is in a critical section. For now, the audio buffer allocation has a central role, because it's the one having allocated most. This buffer is able to shrink itself, for which it needs to stop playback for a very short moment. For this, audio_buffer_available() returns the size of the audio buffer which can possibly be used by other allocations because the audio buffer can shrink. lastfm scrobbling and timestretch can now be toggled at runtime without requiring a reboot. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657