path: root/firmware/target/mips/ingenic_jz47xx/ata-sd-jz4740.c
AgeCommit message (Collapse)AuthorFilesLines
2020-08-25jz4740: SD clock sequencing changes.Solomon Peachy1-17/+13
* Don't stop clock before switching speeds * Don't stop clock prior to transactions * Stop clock at the end of transactions Will result in slightly better performance and some power saving when we're not actively using the SD peripheral. Change-Id: I1c82476cad97137b1469900645ecf7bb0887119a
2020-08-25jz4740: Fix potential deadlock in SD init code.Solomon Peachy1-7/+8
There's a code path that calls sd_init_device() while we hold sd_mtx, but sd_init_device() tries to obtain the mutex while doing its work. Change-Id: I882c595e9e7cd2224b1db0d413925668628476e9
2018-10-09mips: jz4740: JZ4740 does not have a MSC clock source select.Solomon Peachy1-1/+1
Change-Id: Ic2af37d92bcb8b6b35684f113eb8e392fc2eb609
2018-09-20jz74x0: MSC clock needs to be divided from PLL clock.Solomon Peachy1-1/+3
Change-Id: I0cf2f0d55e0859f896afef289e833935d7c5a599
2018-09-20jz4760: Greatly enhance debug code and silence some compilation warnings.Solomon Peachy1-2/+2
Change-Id: I1746d67c818ad099edea83e6242ffd5c79be0000
2018-07-28Add cleaned-up xDuoo X3 supportSolomon Peachy1-1/+1
Cleaned up, rebased, and forward-ported from the xvortex fork. (original credit to Change-Id: Ibcc023a0271ea81e901450a88317708c2683236d Signed-off-by: Solomon Peachy <>
2017-10-26Fix a few missed things in 16454efc (and hopefully clear the red).Michael Sevakis1-4/+0
Change-Id: I2ce88e4c41e6e08efbfbdf261122318dfb0f8b0f
2017-10-26Unify storage threads into oneMichael Sevakis1-72/+24
* Editing a bunch of drivers' thread routines in order to implement a new feature is tedious. * No matter the number of storage drivers, they share one thread. No extra threads needed for CONFIG_STORAGE_MULTI. * Each has an event callback called by the storage thread. * A default callback is provided to fake sleeping in order to trigger idle callbacks. It could also do other default processing. Changes to it will be part of driver code without editing each one. * Drivers may sleep and wake as they please as long as they give a low pulse on their storage bit to ask to go into sleep mode. Idle callback is called on its behalf and driver immediately put into sleep mode. * Drivers may indicate they are to continue receiving events in USB mode, otherwise they receve nothing until disconnect (they do receive SYS_USB_DISCONNECTED no matter what). * Rework a few things to keep the callback implementation sane and maintainable. ata.c was dreadful with all those bools; make it a state machine and easier to follow. Remove last_user_activity; it has no purpose that isn't served by keeping the disk active through last_disk_activity instead. * Even-out stack sizes partly because of a lack of a decent place to define them by driver or SoC or whatever; it doesn't seem too critical to do that anyway. Many are simply too large while at least one isn't really adequate. They may be individually overridden if necessary (figure out where). The thread uses the greatest size demanded. Newer file code is much more frugal with stack space. I barely see use crack 50% after idle callbacks (usually mid-40s). Card insert/eject doesn't demand much. * No forcing of idle callbacks. If it isn't necessary for one or more non-disk storage types, it really isn't any more necessary for disk storage. Besides, it makes the whole thing easier to implement. Change-Id: Id30c284d82a8af66e47f2cfe104c52cbd8aa7215
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis1-18/+11
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested: Michael Sevakis <>
2013-08-17Cleanup MV/MD macros a little.Michael Sevakis1-2/+2
When using variadic macros there's no need for IF_MD2/IF_MV2 to deal with function parameters. IF_MD/IF_MV are enough. Throw in IF_MD_DRV/ID_MV_VOL that return the parameter if MD/MV, or 0 if not. Change-Id: I7605e6039f3be19cb47110c84dcb3c5516f2c3eb
2011-03-02Merge functionality of wakeups and semaphores-- fewer APIs and object types. ↵Michael Sevakis1-6/+6
semaphore_wait takes a timeout now so codecs and plugins have to be made incompatible. Don't make semaphores for targets not using them. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-01-18Try to get some control over #ifdef hell in usb.c by refactoring and inline ↵Michael Sevakis1-3/+0
function use. SYS_USB_DISCONNECTED_ACK hasn't been doing anything useful for the USB thread; remove it. USB thread simply ignores that value. Observe only valid usb_state transitions. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-08-12Introduce NORETURN_ATTR wrapper for __attribute__((noreturn)), using this ↵Thomas Martitz1-1/+2
and a bit further cleanup in main gets rid of a warning when compiling for android. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-06-06Remove card_enable_monitoring() and use a mutex instead. The ↵Frank Gevaerts1-8/+0
card_enable_monitoring() method actually didn't eliminate the possible race conditions it was meant to fix. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-06-05remane hotswap.* to sdmmc.*. The contents have nothing at all to do with ↵Frank Gevaerts1-1/+1
hotswapping things git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-05-21ata: do some threading-related corrections (some sync related where it ↵Michael Sevakis1-1/+1
matters). Make sure 'sleeping' is 'false' before the powerup sequence (throws-off powermgmt and it *is* about to woken again and powermgmt will need to compensate). Avoid looking at mutex flag directly; there's no tangible benefit I can discern and changes to the kernel that alter the meaning shouldn't be able to break anything. For that, in the jz sd driver, have sd_disk_is_active just return 'false' like all the other SD drivers do. If it *must* return this, it should implement it's own method but it seems to not matter. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-01-03Onda VX747/VX777: only enable SD clock when transferring dataMaurus Cuelenaere1-8/+19
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-11-26Define sd_drive_nr also when HAVE_HOTSWAP is defined (fix red).Maurus Cuelenaere1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-11-26 - Split off strip_volume() to a separate fileMaurus Cuelenaere1-0/+2
- fix some yellows git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-11-26Merge branch 'hotswap'Maurus Cuelenaere1-102/+233
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-11-26Remove unused card_detect(), and make card_detect_target() static inline in ↵Thomas Martitz1-1/+1
each sd driver. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-20Make sd_present() and mmc_present() look only at the actual presence of a ↵Frank Gevaerts1-2/+2
card, not at initialisation state git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-17Commit FS#9545, storage cleanup and multi-driver supportFrank Gevaerts1-0/+35
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-03Ingenic Jz4740: remove some unneeded stuff and simplify SD driver (also ↵Maurus Cuelenaere1-460/+63
thanks to Rafaël Carré) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01Move sd_get_info() into common sd codeRafaël Carré1-18/+0
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01 * Move some more stuff to the general SD driverMaurus Cuelenaere1-55/+36
* Ingenic SD driver: cleanup DMA part a bit (not working yet) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01Ingenic jz4740 SD driver: remove custom list of SD commandsRafaël Carré1-425/+362
Replace most references to MMC/mmc with SD/sd Remove MMC failover code since MMC cards aren't supported git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01add firmware/driver/sd.c which contains common code between SD driversRafaël Carré1-11/+14
ingenic SD driver needs more cleanup so it still doesn't use the common code correct a comment in hotswap.c: card_extract_bits assume most significant word of register first (so, use this order) fix debug menu which used MMC specific commands / bits positions in csd/cid move the default block size of 512 into sd.h move the mantissa & exponent table into a single file (sd.c) to reduce binsize. we don't need to export it anymore anyway TODO : ingenic cleanup (will happen soon so building sd.c is not conditional) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01card_extract_bits() take the start bit argument as defined in public SanDisk ↵Rafaël Carré1-5/+5
specifications for SD and MMC, i.e. bit 0 is the lsb git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01Ingenic Jz4740 SD driver: remove some unneeded stuff + fill the OCR field in ↵Maurus Cuelenaere1-9/+4
card_get_info_target() git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01Ingenic Jz4740 SD driver: fix SD clock init (fixes problems with SDHC cards)Maurus Cuelenaere1-10/+11
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-07-01Merge tCardInfo struct (MMC) and tSDCardInfo struct (SD)Rafaël Carré1-8/+4
Put specific members under #ifdef (CONFIG_STORAGE & STORAGE_xx) (2 members for SD and 1 for MMC) Fix a typo: tsac doesn't exist and must be read taac Move card_get_info functions declaration inside hotswap.h to remove mutual inclusion of ata_mmc.h and hotswap.h Move static const data structures from SD drivers into sd.h (sd_exponent and sd_mantissa) Fix sd_command prototypes in SD drivers (card registers are unsigned long) Fix speed calculation in Sansa AMS driver (PP SD driver needs to be checked) Move ata-sd-target.h to sd-pp-target.h to reflect the PP specifity. Now it only contains declaration of microsd_int() Remove unused ata-sd-target.h for injenic TODO: - check if CSD register bits are extracted correctly in PP driver - correctly define read_timeout and write_timeout unit for MMC & SD, and use timeouts in Sansa AMS driver git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-04-08Fix yellowMaurus Cuelenaere1-0/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-04-08Add LED indication to Jz4740 SD driverMaurus Cuelenaere1-0/+8
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-03-09 * Unify Onda VX747 and VX747+ config filesMaurus Cuelenaere1-0/+10
* Conditionalise (void)drive; in NAND & SD drivers git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-02-13Onda VX747:Maurus Cuelenaere1-108/+783
* Add preliminary keymap * Split up generic MIPS stuff from Ingenic specific * Make apps/ compilable * Add SD driver * Fix RTC driver * Add debug screen * Other cleanups/rewrites/fixes git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-01-27Onda VX747:Maurus Cuelenaere1-11/+5
* Implement lcd_flip() * Add support for multiple banks in NAND driver * Add basic I²C driver (untested) * Get audio back working * Add power driver * Other minor fixes and cleanups git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2009-01-21Onda VX747:Maurus Cuelenaere1-15/+21
* Get USB working (it isn't good at writing support though) * Clean up NAND & SD a bit * Other comments/fixes Ingenic Jz4740/MIPS: * Split MMU from system git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-11-21Commit some USB and ATA rework/refactoring (+ USB GPIO detection).Maurus Cuelenaere1-28/+16
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2008-11-05Onda VX747:Maurus Cuelenaere1-0/+1168
* Commit (premature) SD, USB & audio drivers * Fix ramdisk.c mistake * Add battery readout git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657