path: root/firmware/usbstack
AgeCommit message (Collapse)AuthorFilesLines
2018-07-30Workaround for usb_storage_init_connection() panicCástor Muñoz1-0/+1
For s5l8701, s5l8702 and as3525v2 targets. The crash occurs when USB is inserted or extracted while the playlist is being loaded or updated (it could take a few seconds for huge playlists), at this point all buflib memory is allocated and not freed before usb_starage_init_connection() is executed. This workaround mitigates this panic by using static memory for USB buffers, so this memory cannot be used for other tasks, in addition the problem still persist when playlist load is 'paused' by USB insertion and then updated after USB extraction. Change-Id: Iff1db5a949361fd543e0b494924d1f2906c84b5e
2017-03-12Do some housekeeping with fat.h and SECTOR_SIZEMichael Sevakis1-5/+1
Many includes of fat.h are pointless. Some includes are just for SECTOR_SIZE. Add a file 'firmware/include/fs_defines.h' for that and to define tuneable values that were scattered amongst various headers. Remove some local definitions of SECTOR_SIZE since they have to be in agreement with the rest of the fs code anyway. (We'll see what's in fact pointless in a moment ;) Change-Id: I9ba183bf58bd87f5c45eba7bd675c7e2c1c18ed5
2016-08-04usb_serial: fix send buffer alignmentCástor Muñoz1-16/+11
Change-Id: Ib2635c905462cd34befa3ca61e5d55c869686b48
2016-08-02Introduce new USB driver for Synopsys DesignWare USB OTG core.Cástor Muñoz1-0/+11
Based on g#844 and g#949, it is intended as a replacement for the current s3c6400x USB driver. The DesignWare USB OTG core is integrated into many SoC's, however HW core version and capabilities (mainly DMA mode, Tx FIFO mode, FIFO size and number of available IN/OUT endpoins) may differ: CPU targets HW ver DMA NPTX FIFO FIFO sz #IN/OUT -------- ------------- ------ --- --------- ------- ------- as3525v2 sansaclipplus 2.60a Yes Dedicated 0x535 4/4 sansaclipv2 sansaclipzip sansafuzev2 s5l8701 ipodnano2g 2.20a Yes Shared 0x500 4/5 s5l8702 ipod6g 2.60a Yes Dedicated 0x820 7/7 ipodnano3g s5l8720 ipodnano4g ? ? ? ? ? Functionality supported by this driver: - Device mode, compatible with USB 1.1/2.0 hosts. - Shared FIFO (USB_DW_SHARED_FIFO) or dedicated FIFOs. - No DMA (USB_DW_ARCH_SLAVE) or internal DMA mode. - Concurrent transfers: control, bulk (usb_storage, usb_serial) and interrupt (usb_hid). Actually this driver is not used by any CPU, it will be enabled for each individual CPU/target in next patches. Change-Id: I74a1e836d18927a31f6977d71115fb442477dd5f
2015-02-16Revert "usb_storage: make it a bit more correct"Amaury Pouly1-1/+0
Clearly this was a stupid commit, no idea why I did that. This reverts commit 074e911859a0d3464fde9b701b3cff712c5826e0.
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis1-4/+1
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested: Michael Sevakis <>
2014-02-10Coding style fix for bde5394Marcin Bukat1-3/+4
Change-Id: I6e9ba6a2570915191cf5b66f58ed9ddb1959b6cc
2014-02-09Return a valid USB string descriptor for index 0xEE.Frank Gevaerts1-0/+7
Windows will try to retrieve such a descriptor on first connect. If the device returns STALL or a regular string descriptor (i.e. not one that follows the Microsoft OS Descriptor spec), things will continue normally. Unfortunately some of our low-level USB drivers have issues with STALL so any other valid descriptor is the next best solution. Change-Id: I59eb09eea157e4e14bec0197a898be378a5559f2 Reviewed-on: Reviewed-by: Frank Gevaerts <> Tested: Frank Gevaerts <>
2014-01-11Don't use core_alloc_maximum() in usb_storage.Frank Gevaerts1-6/+5
usb_storage needs a fairly reasonable amount of memory. Allocating what we need and no more allows other (future) USB drivers to get something too, and is much cleaner in general. Change-Id: Iec9573c0f251f02400f92d92727cbf2969785de0
2014-01-05Make sure usb class driver disconnect() functions are called properly.Frank Gevaerts1-8/+20
disconnect() needs to be called exactly once per call to init_connection(). In case of bus resets, disconnect() was not called, which led to leaking alloc_maximum() allocated buflib handles, which led to buflib running out of memory to allocate. Change-Id: I03025da578dc54e48b6de6bd3e3f40feae7220a6
2014-01-05Check that core_alloc_maximum() returned something useful, and panic if notFrank Gevaerts1-0/+5
Change-Id: I7ae40db0f81d1d51742501936b13b387f94a25e5
2013-12-23playback,talk: Share audiobuffer via core_alloc_maximum().Thomas Martitz1-5/+12
This fixes the radioart crash that was the result of buffering.c working on a freed buffer at the same time as buflib (radioart uses buffering.c for the images). With this change the buffer is owned by buflib exclusively so this cannot happen. As a result, audio_get_buffer() doesn't exist anymore. Callers should call core_alloc_maximum() directly. This buffer needs to be protected as usual against movement if necessary (previously it was not protected at all which cased the radioart crash), To get most of it they can adjust the willingness of the talk engine to give its buffer away (at the expense of disabling voice interface) with the new talk_buffer_set_policy() function. Change-Id: I52123012208d04967876a304451d634e2bef3a33
2013-08-17Cleanup MV/MD macros a little.Michael Sevakis1-4/+4
When using variadic macros there's no need for IF_MD2/IF_MV2 to deal with function parameters. IF_MD/IF_MV are enough. Throw in IF_MD_DRV/ID_MV_VOL that return the parameter if MD/MV, or 0 if not. Change-Id: I7605e6039f3be19cb47110c84dcb3c5516f2c3eb
2013-08-12Fix response length calculation for SCSI_REPORT_LUNSBertrik Sikken1-1/+2
Change-Id: I1167851bae20d9275eb2f441ce9dc73c8b2f09b1 Reviewed-on: Reviewed-by: Frank Gevaerts <> Reviewed-by: Bertrik Sikken <> Tested-by: Bertrik Sikken <>
2013-07-24usb stack: add more verbose debug logf()sMarcin Bukat2-2/+7
Change-Id: I087aefd2854978813c7e4ed7ef7da400f3692e39
2013-07-24usb_storage: make it a bit more correctAmaury Pouly1-0/+1
Add stall when unknown SCSI command is hit Change-Id: Icbeea905cd262ab296fb34470e54c665b8bab488
2013-07-24usb_core: rework handling of clear featureAmaury Pouly1-3/+13
Change-Id: Icb1e973aa5fd8520eff0796aa8164e0a988d9107
2013-06-24imx233: fix ocotop/debug and usb-core for stmp3600Amaury Pouly1-1/+2
Currently we don't know where the serial number is stored on the stmp3600. It is probably using the laser fuses but this needs to be investigated Change-Id: I1ac25e38b8f65635abb68788ceb65df0a740dabd
2013-06-16imx233: rewrite ocotp using new register headersAmaury Pouly1-1/+1
Change-Id: I3c622119a1e296ec6b3f35f27e81b5118ab7f6cc
2013-05-17FS#12854 - ipod-time-sync sets wrong dayrbutil/mkamsboot/mkamsboot.cBoris Gjenero1-1/+1
Change-Id: I8ac7561119e51774b9aee377e7373a7e830a5780
2012-12-07usb: add support for hardware handled SET ADDR/CONFIGAmaury Pouly1-17/+53
Some USB controllers like the one of the Rockchip 27xx handle some requests in pure hardware. This is especially a problem for two of them: - SET ADDR which is used by our core to track the DEFAULT/ADDRESS state and is required for the drivers to work properly - SET CONFIG which is used by our core to initialise the drivers by calling init_connection() In these cases we need a way to notify the core that such requests happened. We do this by exporting two functions which directly notify the core about these requests and perform the necessary init steps required without doing the actual USB transfers. Special care is needed because these functions could be called from an interrupt handler. For this reason we still use the usb_queue and introduce new IDs so that they are processed in order and safely. No functional change is intended, both in the usbstack and on targets without such quirks. Change-Id: Ie42feffd4584e88bf37cff018b627f333dca1140
2012-05-31Fill USB serial number descriptor on imx233 targets.Amaury Pouly1-0/+27
Compute a serial number using the ocotp OPS bits like the OF. Also add a comment about the first character of serial number being a indicator of the enabled interfaces. Change-Id: I9b90aed4e3b803f12fec003c9bc8ee8a046f4e42
2012-05-07fix a mistake of 803408f18 spotted by n1sRafaël Carré1-1/+1
When the source string terminates (with a 0) we pad the rest of the destination with spaces.
2012-05-07missing constRafaël Carré1-1/+1
2012-05-07simplify yearday_to_daymonth()Rafaël Carré1-20/+9
2012-05-07simplify copy_paddedRafaël Carré1-11/+7
2012-01-04Reorganise USB initialisation to not depend on a specific enumeration ↵Frank Gevaerts1-5/+0
sequence, by Bartosz Fabianowski, with minor tweaks by Michael Sevakis (FS#12497) FreeBSD apparently sends a SET_ADDRESS first, which confused our code. This patch fixes that, and also simplifies the connection handling a bit. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-31usb-target.h: removeRafaël Carré1-3/+0
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-31usb_core: Fix typo in commentMichael Sparmann1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-31The AMSv1 driver limitation that disallows 64K transfers is a USB core ↵Frank Gevaerts1-2/+2
limitation, not a CPU limitation, so use the appropriate defines to test for it git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-29usb PACK_DATA: use a static inline to enable type checkingRafaël Carré5-16/+16
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-29usb_hid: fix r31457Rafaël Carré1-4/+4
descriptor_hid_get() updates its parameter so we need to take its address the update is hidden inside PACK_DATA macro Fix HID on the Fuze+ Reported by jlbiasini git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-28USB HID: cosmetics / simplificationsRafaël Carré1-113/+68
Declare loop variables inside for() ala C99 Remove useless casts Remove one level of pointer indirection in descriptor_hid_get() Simplify a few switch() Align case on the same level than switch git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-17Commit to certain names for cache coherency APIs and discard the aliases.Michael Sevakis1-1/+1
Wouldn't surprise me a bit to get some non-green. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-16Remove USB time sync code when there's no RTC.Boris Gjenero1-0/+17
Without an RTC, Rockbox doesn't keep time. In that situation, USB time sync previously did nothing but reported success. After this change, the USB time sync request won't be recognized on those targets. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Oops, fixed the wrong lineAmaury Pouly1-2/+2
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Remove two useless variable and hopefully finally fix redAmaury Pouly1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-15Add support for for per-drive logical sector size. This allows targets to ↵Amaury Pouly1-1/+1
have a different logical sector size for the internal storage and the sd card, like on the fuze+ for example. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-12-14FS#12378 : Remove various unused code, and comment out some unused code and ↵Boris Gjenero1-18/+0
data for reference or future use. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-10-21Use array index 'i' only -after- bounds checkThomas Jarosch1-2/+2
Reported by cppcheck git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-09-09Add "USB Hide Internal Drive" option for multidrive devices with software usb.Frank Gevaerts1-10/+15
This option allows accessing the card slot from "dumb" USB hosts like some car audio systems that do not handle multi-LUN devices. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-05-08Fix tabs in .c and .h files in firmware/ Bertrik Sikken1-4/+4
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-02-27iPod Classic CE-ATA Support (Part 2 of 4: Remove on-stack sector buffers, ↵Michael Sparmann1-2/+5
and replace them with a single statically allocated sector buffer that's arbitrated amongst users) git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-01-17Add a higher level USB detection that prevents fraudulent bus resets from ↵Michael Sevakis1-0/+5
causing USB mode to be entered. Enable for SA9200 only at this time. Also, for SA9200, use the bus power GPIO rather than the 'connector inserted' GPIO to detect the cable. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-01-15Bootloader USB mode for PP502x. Enable only on GoGear SA9200 for the time ↵Michael Sevakis1-2/+2
being. Add HAVE_BOOTLOADER_USB_MODE to config if BOOTLOADER is defined to enable it. Clean up some kernel stuff a little to support it. Mess up a bunch of other stuff (hopefully not too badly). git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2011-01-05Gigabeat S: Make it a removable mass-storage device. Windows will assign a ↵Michael Sevakis1-36/+23
drive to only the main data partition by default. To access the bootloader partition instead, press 'Vol -' while it connects (in bootloader and firmware). Hopefully doesn't break anything for anyone. git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-12-04Handle disk errors properly in USB storage driver. Fixes FS#10873Frank Gevaerts1-10/+14
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-10-02Fix outdated commentFrank Gevaerts1-1/+1
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-09-20usb: remove unused variable and correctly stall on unhandled control requestsAmaury Pouly1-2/+8
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657
2010-09-06Fix set_serial_descriptor() for targets with as3543Rafaël Carré1-4/+4
git-svn-id: svn:// a1c6a512-1295-4272-9138-f99709370657