path: root/lib
AgeCommit message (Collapse)AuthorFilesLines
2013-05-19Opus: avoid allocating space for comment packetsNils Wallménius1-0/+6
Fixes playback of files with large embedded album art. Change-Id: I94d336e3da968a93047dd00a5fa65e4c3423a7da
2013-05-18Fix opus craches with large embedded album artNils Wallménius4-44/+42
Use the tlsf malloc and friends instead of the silly codec_malloc to get actually working free and saner realloc that doesn't leak memory. Makes files with moderately sized embedded AA play on targets with large enough codec buffers and files with too large AA are now skipped rather than crashing. Fixes crash when playing example file in FS#12842. Change-Id: I06562955c4d9a95bd90f55738214fba462092b71
2013-05-16Introduce new hermite polynomial resampler.Michael Sevakis3-260/+543
Uses the Catmull-Rom case of Hermite cubic splines. Vastly improves the quality and accuracy of audio resampling with a rather minor additional overhead compared to the previous linear implementation. ARM and Coldfire assembly implementations included. Change-Id: Ic45d84bc66c5b312ef373198297a952167a4be26 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested-by: Michael Sevakis <>
2013-05-07Rename all the "lin_resample..." stuff to simply "resample_...".Michael Sevakis4-45/+42
Change-Id: I79f44f0dcc1b23b33a5040795220713660a1d18a
2013-05-05Purge the usage of DSP_SWITCH_FREQUENCY.Michael Sevakis26-27/+26
DSP_SWITCH_FREQUENCY has been deprecated and the same enumerated value as DSP_SET_FREQUENCY since major DSP revisions were committed. This task should have been performed much earlier but, oh well, do it now. Change-Id: I3f30d651b894136a07c7e17f78fc16a7d98631ff
2013-05-04Revert "Don't set CORE_GCSECTIONS in fixedpoint.make."Dominik Riebeling1-0/+1
While it made the mini2g not crash during startup anymore further tests showed that other mini2g devices still exhibit the crash, or end up with a "No partition found" error; furthermore the device tested first still crashes on USB disconnect. Therefore the change doesn't really help with the problem, and at the expense of increasing binary size for all other targets there is no point in keeping it for now. This reverts commit 850491a043a9341ef31ffb8c02eedd2ae7b2c53e.
2013-05-04Fix missed optimization opportunity in dsp_process.Michael Sevakis1-3/+3
Input type can only change once per call because the DSP parameters are only copied at the start and input is always taken from the src buffer which means sample input format switching can be once per call instead of once per loop. Change-Id: Ifa3521753428fb0e6997e4934f24a3b915628cc7
2013-05-04Cleanup and simplify latest DSP code incarnation.Michael Sevakis15-540/+513
Some things can just be a bit simpler in handling the list of stages and some things, especially format change handling, can be simplified for each stage implementation. Format changes are sent through the configure() callback. Hide some internal details and variables from processing stages and let the core deal with it. Do some miscellaneous cleanup and keep things a bit better factored. Change-Id: I19dd8ce1d0b792ba914d426013088a49a52ecb7e
2013-04-28Don't set CORE_GCSECTIONS in fixedpoint.make.Dominik Riebeling1-1/+0
fixedpoint.make is not a subdir Makefile but a lib Makefile. Setting CORE_GCSECTIONS in it will affect the final link and make it always use --gc-sections (for SWCODEC Rockbox), since libfixedpoint is always needed (bootloader and HWCODEC don't use libfixedpoint). Fixes FS#12857. Change-Id: Ib30bd03cbcea9c339a73daf7b673868aa3cc7a88
2013-04-26Properly seek to next id3v2 frame for unsynced tags.Dominik Riebeling1-3/+10
When seeking to the next id3v2 frame we need to consider if the tag has the unsync flag set. Not doing so will likely make parsing end up in the middle of the current frame if the frame size exceeds the upper limit set during read. The latter usually happens for album art frames. Fixes FS#12849. Change-Id: Ic92853eef4374508d84df347bcc66b6661d5037d
2013-04-25Properly implement volume in warble. dB cut only.Michael Sevakis2-9/+36
Change-Id: I34b77287ba0b1a0002db3d52e893a52c50593362
2013-04-25Add $(SHARED_CFLAGS) to fixedpoint.make to quash amd64 errors in 95e23de.Michael Sevakis1-1/+1
Thanks to Frank Gevaerts. Change-Id: I6ca1d0258bfc70950d0ad5c2975d2bd88060b8a3
2013-04-26Make fixepoint.c as a shared library (libfixedpoint.a).Michael Sevakis10-32/+623
Change-Id: Icc10d6e85f890c432f191233a4d64e09f00be43d Reviewed-on: Reviewed-by: Michael Sevakis <> Tested-by: Michael Sevakis <>
2013-04-15Straighten out the mad twisted state of sound.c and related areas.Michael Sevakis3-44/+57
This is going right in since it's long overdue. If anything is goofed, drop me a line or just tweak it yourself if you know what's wrong. :-) Make HW/SW codec interface more uniform when emulating HW functionality on SWCODEC for functions such as "audiohw_set_pitch". The firmware-to- DSP plumbing is in firmware/drivers/audiohw-swcodec.c. "sound_XXX" APIs are all in sound.c with none in DSP code any longer. Reduce number of settings definitions needed by each codec by providing defaults for common ones like balance, channels and SW tone controls. Remove need for separate SIM code and tables and add virtual codec header for hosted targets. Change-Id: I3f23702bca054fc9bda40f49824ce681bb7f777b
2013-04-11Implement universal in-PCM-driver software volume control.Michael Sevakis2-21/+0
Implements double-buffered volume, balance and prescaling control in the main PCM driver when HAVE_SW_VOLUME_CONTROL is defined ensuring that all PCM is volume controlled and level changes are low in latency. Supports -73 to +6 dB using a 15-bit factor so that no large-integer math is needed. Low-level hardware drivers do not have to implement it themselves but parameters can be changed (currently defined in pcm-internal.h) to work best with a particular SoC or to provide different volume ranges. Volume and prescale calls should be made in the codec driver. It should appear as a normal hardware interface. PCM volume calls expect .1 dB units. Change-Id: Idf6316a64ef4fb8abcede10707e1e6c6d01d57db Reviewed-on: Reviewed-by: Michael Sevakis <> Tested-by: Michael Sevakis <>
2013-04-10Move fixedpoint.h to be accessible in /firmware.Michael Sevakis1-26/+3
Will need it soon enough. Combine the contents of all the various fixedpoint.h files. Not moving fixedpoint.c for now since I'm not sure where it should be and it causes some dependency issues. Change-Id: Ideacbca2ca78f9158c2b114b113c274f68e908d5
2013-03-06VGM Codec: Improve time and fade behavior. Tweak minor misc.Michael Sevakis2-20/+40
Prevents cutoff of tracks, especially short ones: * Extend looped tracks by fade length to fade at start of loop repeat. * No fade occurs for non-repeating track only having an intro. * Uses id3.tail_trim field to store fade duration. Use libGME built-in elapsed time reporting instead of custom calculation: * libGME already reports in milliseconds. * Don't advance time counter when Repeat == One. It just runs the progress over the length limit. Fix a comment about sample rate and set the reported bitrate to be accurate for 44.1 kHz stereo. Change-Id: I3ede22bda0f9a941a3fef751f4d678eb0027344c
2013-02-27more error handling for checkwpsJonathan Gordon1-0/+10
Change-Id: I03055d045c0a8e0e63e17b290cc71c54a8dc3634
2013-02-26checkwps: show a helpful error if the parser callback errors outJonathan Gordon3-1/+11
Change-Id: Ie3e35292ba8d74f0ff3d1bb3483a5e83aae0e6b6
2013-02-23Build libtlsf for all systemsFrank Gevaerts1-2/+0
libtlsf used not to be built for HWCODEC, but now that the gif viewer uses libtlsf instead of building its own copy, libtlsf is needed everywhere. Change-Id: I730719c6a20e749adb8597056d2049b7758620e4
2013-02-18Fix FSB#12826 - Mini-sound burp between track skips [with WMA].Michael Sevakis1-18/+22
Flush decoder state and frame out buffer upon a forced stop to prevent a short burst of stale audio from the previously decoding track from playing when skipping from one WMA track to another. Change-Id: I24c910c5dbd83caed2510db68d9e39a474332a79 Reviewed-on: Reviewed-by: Michael Sevakis <> Tested-by: Michael Sevakis <>
2013-02-09EQ settings: Rework the settings to clean up the config file.Jonathan Gordon24-694/+231
Instead of 3 cfg lines per eq band there is now a single line for each: <config name>: <cutoff/center freq>, <q>, <gain> In addition, the config value names make a bit more sense. The old settings are still readable but config.cfg and any new settings files will be written with the new config values. (The old settings will be removed completly sometime after the next stable release). Also a slight rework of the advanced EQ menu UI Change-Id: I9008658d36ded442a5f2f825916df42a3934cbef Reviewed-on: Reviewed-by: Jonathan Gordon <>
2013-02-08Fix Theme Editor build.Dominik Riebeling1-1/+1
The skin_parser now needs __PCTOOL__ set to build libskin_parser.a properly for use with the Theme Editor. Change-Id: I48a518fa296cc8ec5d0e3022baaedd796afe7c5f
2013-01-2910 Band EQ w/PresetsHayden Pearce30-134/+809
- A 10 Band EQ for Rockbox w/ presets adapted from VLC - frequency stepping at 32, 64, 125, 250, 500 1K, 2K, 4K, 8K, 16K Change-Id: I85ad84d70a534edfc66c6ad9af8a76f022a02ec7 Reviewed-on: Reviewed-by: Jonathan Gordon <>
2013-01-24Deprecate the EXTRA_LIBS variable.Björn Stenberg3-4/+2
Instead specify explicit library dependencies for codecs and plugins.
2013-01-21ARMv5 optimized complex multiply function for libopus.Michael Giacomelli1-1/+25
Speeds up decoding of 128k opus files by 1.2MHz on AMSv2. Rounding error is 1 bit due to KissFFT using a 15 bit shift instead of a 16 bit shift. Also, change an LDMIA in the armv4 code to LDM as the pointer should not increment. Change-Id: I626a207c6a056a1984e33cfe89415c35d0caed93 Reviewed-on: Reviewed-by: Michael Giacomelli <> Tested-by: Michael Giacomelli <>
2012-12-28Fix FS#12794 - new EQ code does not compile for the Nokia N8x0Michael Sevakis1-11/+11
The old GCC version currently required (sbox-arm-linux-gcc 3.4.4 release) apparently has trouble with function pointers used as static array initializers when using indexed initializers + ranges (ie. [A ... B] = fn). Change-Id: I494c2b607e4d93a9893264749d0ac257fb54ce3b
2012-12-099 segment bitmap drawing:Jonathan Gordon2-0/+2
Use %x9(id) to draw an image in the whole current viewport using the 9 segment drawer (which draws the corners as normal and *tiles* the middle segments to the needed width/height). Future work is to make it scale instead of tile Change-Id: Ic3ed1cad93f96091694801eb442e0da5a2401203
2012-11-22Add support for 16 bit 'half float' format PCM.Michael Giacomelli1-1/+28
I'm not 100% sure that the rounding of denormals is correct. As compared to foobar2000, some samples are off by +1 LSB. However, since I can't output 24 bit PCM easily with rockbox, I'm not sure if this is due to a bug or just how rockbox rounds. In practice I don't think it matters so I'm just going to commit this for now. Change-Id: Ic0792fcb172e4369a5512d202121c2b918b36079
2012-10-25flac: use 64 bit math to calculate the elapsed timeNils Wallménius1-2/+2
avoids overflows for very long files Change-Id: Idb1e9a411bd9007cfddbbd2d3dcf127645fa9a7c
2012-10-18libgme: fix badly written cpp conditions spotted by gcc 4.6.3Marcin Bukat2-2/+2
Change-Id: Ia3fba4ba2c46a202c48f3a9b7db0cba9f75b6a50
2012-10-17opus: only put the mdct function in iram for cf,Nils Wallménius1-1/+6
doesn't make any speed diff on pp Change-Id: Ia6484e2a2bbf72d33a583470918c0fa267fd9b97
2012-10-16opus: don't rely on stride being 1<<shiftNils Wallménius1-4/+5
Change-Id: I2d64fb20b2526d912eb665df0df4e87459676a92
2012-10-16opus: use two pointers for mdct pre and post rotationAndree Buschmann1-7/+12
avoids complicated index calculations in the loops. saves 0.3MHz decoding a 64kbps test file on h300 (cf) and 0.2MHz on c200 (pp) Change-Id: I1918912d9a4502f89980c6bb270ec2ef10a07010 Signed-off-by: Nils Wallménius <>
2012-10-16opus: put hot code in iramNils Wallménius2-2/+2
Saves 1.1MHz decoding a 64kbps test file on h300 (cf) and 0.2MHz on c200 (pp) Change-Id: If9ed03f2e3787ee497eababda4013fbb5d395946
2012-10-14Improve seeking in opus, tested on Sansa; not testedFrederik M.J. Vestre1-7/+10
on a target with a disk. Change-Id: I37c875c9cd014eb61fe5232dab0f4b8f15f057dd Reviewed-on: Tested-by: Thiago Okada <> Reviewed-by: Frederik Vestre <> Tested-by: Frederik Vestre <>
2012-10-10opus: arm asm for C_MULCAndree Buschmann1-0/+22
speeds up decoding of a 64kbps test_file by 1.5MHz on c200 (pp) and 1.9MHz on fuzev1 (amsv1) Change-Id: I1db460b634eba608c3e00541d96fc93d5a05710b Signed-off-by: Nils Wallménius <>
2012-10-10opus: cf asm for C_MULCNils Wallménius1-0/+21
saves 2.7MHz decoding a 64kbps test file on h300 Change-Id: Id63791f79b44ed398ce5d341a5f5212d9a30282e
2012-10-07opus: replace copy loops with calls to memcpyAndree Buschmann1-12/+10
speeds up decoding of a 64kbps test file by 0.5Hz on h300 (cf) 0.9MHz on c200 (pp) and 0.2MHz on fuzev1 (amsv1) Change-Id: Ib537c2393fa6dca0b61e4e9f80eef5e688c2c2bd Signed-off-by: Nils Wallménius <>
2012-10-07opus: speed up mdct overlap add and copyingAndree Buschmann1-6/+10
Unroll overlap add loop by four and use memcpy for copying instead of loops. Change-Id: I17114626a395d5972130251d892f851bc86e3a6a Signed-off-by: Nils Wallménius <>
2012-10-06opus: cf inline asm for MULT32_32_Q31Nils Wallménius1-1/+13
speeds up decoding of a 64kbps test file by 2MHz on h300 Change-Id: I437d05278fe1c495715cf0e3477f9960d1df9d3a
2012-10-06opus: full precision MULT32_32_Q31 (32*32=64>>31) multiplicationAndree Buschmann1-2/+16
Replace complicated macro doing three 16*16 muls and add an inline asm implementation for arm, speeds up decoding a 64kbps test file by 0.5MHz on c200 (pp) and gives slightly better precision. Change-Id: I6fc5b83c210f01bffdc38aec54cc5a8b646d8169 Signed-off-by: Nils Wallménius <>
2012-10-06opus: slight speedup of deemphasisAndree Buschmann1-3/+8
Hoist load of coefficients out of the loop. Speeds up decoding of a 64kbps test file by 0.6MHz on h300 (cf) 0.2MHz on c200 (pp) and 0.1MHz on fuzev1 (amsv1) Signed-off-by: Nils Wallménius <> Change-Id: I4be0059fc2a77748575f5fc9378f7f348d64f1c4
2012-10-06opus: speed up comb_filterAndree Buschmann1-32/+58
Skip expensive multiply-accumulate loop when gains are 0 and just copy using memcpy if soure and destination are not the same Speeds up decoding of a 64kbps test file by 6MHz on h300 (cf) 7MHz on c200 (pp) and 6MHz on fuzev1 (amsv1) Change-Id: Ibbc9ddfd45a9ac661467b1327b8c67761924fb8b Signed-off-by: Nils Wallménius <>
2012-10-04opus: put arrays frequently used by pulse decoding on the stackNils Wallménius2-7/+13
speeds up decoding of a 64kbps test file by 14MHz on h300 (cf) and 1MHz on c200 (pp) Change-Id: I852cb66808676ea51109423f5b70cfc8782dd109
2012-10-01opus: speed up arm asm MULT16_32_Q15Nils Wallménius1-1/+1
Reorder operands to take advantage of the early termination of multiplications. Saves 2.5MHz decoding a 64kbps opus test file on c200 (pp). Change-Id: I470266dc870ab183ece3b23426d41e2a64342a71
2012-10-01opus: allocate mdct f2 buffer in iramAndree Buschmann1-5/+17
Speeds up decoding of 64kbps test file by 6.3MHz on h300 (cf) and 1.2MHz on c200 (pp). Signed-off-by: Nils Wallménius <> Change-Id: I08c2c332153abcbef9447c81986777fd2fcc73fe
2012-10-01opus: allocate buffers for X and freq in iramAndree Buschmann1-2/+15
speeds up decoding of 64kbps test file by 19MHz on h300 (cf) and 2.5MHz on c200 (pp) Change-Id: Idacd2f8962c20c518055d586daeec6b932b7ded2 Signed-off-by: Nils Wallménius <>
2012-09-29Support technically invalid image/jpg mimetype in tags.Frank Gevaerts2-0/+11
Although the mimetype for jpeg is clearly image/jpeg, many tagging applications seem to use image/jpg, so we'll support that too. Change-Id: Icb9063fd5a9d8aea169eaa7f74ac52b72603d148 Reviewed-on: Reviewed-by: Michael Giacomelli <> Reviewed-by: Thomas Martitz <>
2012-09-29opus: statically allocate decoder state in iramAndree Buschmann1-2/+10
Speeds up decoding of a 64kbps test file 26MHz on H300 (cf) and 2MHz on c200 (pp) Change-Id: I2fb4fe6c0a29321087e02fbd17fd1b1eb84e7b57 Signed-off-by: Nils Wallménius <>