path: root/rbutil/rbutilqt
AgeCommit message (Collapse)AuthorFilesLines
2012-04-26MI4 bootloader: check for copy result.Dominik Riebeling1-2/+15
As for BootloaderInstallFile check if copying the bootloader file to the player did actually work or if an already present file caused the copy operation to fail. Change-Id: I2e889610b4cb9f57f73cffc473c6230be0d11e24
2012-04-26Check for bootloader file on device before copying.Dominik Riebeling1-3/+16
QFile::copy() doesn't overwrite an already existing file. This can lead to bootloader installation trying to place a new file on the player but failing to do the actual copy if the file already exists. Since overwriting an already existing file might be unexpected by the user error out in this case and notify the user. Change-Id: I5ffaf2f1344271ea2bad9e3232234826552385ec
2012-04-26Add missing basque and english-us languages.Dominik Riebeling1-0/+2
Change-Id: I99767adb9231b25092bee976921a42a8e309599b
2012-04-26Voicefile: remove < and > from voice strings before speaking.Dominik Riebeling1-0/+1
Some language files have the < and > characters the original string (like "<All tracks>") has included in the voice strings. These characters cause the generated wave file to not contain any samples with SAPI, causing an error when Rockbox Utility tries to encode the file. Since those characters don't make much sense in the voice string remove them prior to speaking. Currently affected languages are basque, chinese-simp, and russian, for which this fixes voicefile creation. Change-Id: Iac7ccd7921ccfb5ddc33645239a1f8f7e639e5aa
2012-04-25Add codecs to librbcodec.Sean Bartell2-2/+2
Change-Id: Id7f4717d51ed02d67cb9f9cb3c0ada4a81843f97 Reviewed-on: Reviewed-by: Nils Wallménius <> Tested-by: Nils Wallménius <>
2012-04-24Refresh mountpoint from UI before checking for existence.Dominik Riebeling1-0/+3
Fixes "invalid mountpoint" errors that could happen if the preselected mountpoint was never changed and no previous configuration available. Change-Id: Ief5f1b7a0b24267a03028f5d402e8763a5a3fc70
2012-04-10Check for existing firmware file on H100 / H300.Dominik Riebeling1-2/+14
Show an error if copying the firmware file to the player failed. Also, check if there is already a firmware file present on the player. If so abort and tell the user about it, since QFile::copy() doesn't overwrite existing files and the user might not expect the file to get overwritten. Change-Id: Ie63963289965900a4ab519ddf128246f89d81c6c
2012-04-06libmp3lame encoder: don't retrieve settings for each run.Dominik Riebeling2-4/+11
Retrieve the encoder settings only when creating the object or when saving. Avoids unnecessary overhead by accessing the settings object on each encoder call, which also clutters the system trace log. Change-Id: If64e5d1d5ac8f1d4b0afd1bc4851e455fc7e64c2
2012-04-06Drop empty voice strings when building list of strings.Dominik Riebeling1-1/+7
Instead of skipping empty voice strings when trying to voice the list of strings drop them immediately when building the list of strings. Change-Id: Ib2627fb4b5061916cf04d67b6b78f457122ed2cd
2012-04-02Remove espeak from TTS list on Windows.Dominik Riebeling1-0/+2
On Windows espeak installs itself as command line program as well as as SAPI voice. Using the SAPI voice is simpler, so there is no need to keep the command line option for it. Change-Id: I44fbd806572d5c14b976aa5d58a91935f04c6338
2012-03-28Fix HTML manual download link (FS#12620).Dominik Riebeling1-2/+2
Change-Id: I1bccf62b7770ad7a73ffc1578cbdf5034951c216
2012-03-28Prefix compareversion test files.Dominik Riebeling2-3/+3
Change-Id: Ic67b4a1519456cbb2d85078a80ac605eb65f8020
2012-03-12Enable MPIO HD200 and HD300 installation.Dominik Riebeling1-2/+0
HD300 has been promoted to stable. The state of a port is retrieved from the download server anyway, so there is no reason to keep the HD200 disabled. Change-Id: Ic28c663c8999558dda5b10f4fa584e2f6732264a
2012-03-12Fix false positive in version detection.Dominik Riebeling2-1/+2
Some git revisions are falsely detected as release version. Extend test and fix the wrong regexp. Corrects font download trying to get the wrong file for some current builds. Change-Id: Ia779896c927385ec0d7ba68ee3d953f3c6e4494c
2012-03-12Test: check retrieved version string as well.Dominik Riebeling1-0/+2
As originally intended check if the retrieved version string is correct instead of ignoring it. Change-Id: If4dad224e999a90607dee3eb723400c12f5b7362
2012-03-06Bump version to 1.2.13.rbutil_1.2.13Dominik Riebeling2-2/+2
Change-Id: Ib4efdef98db92824f798f830f8c8c1b094dc4f02
2012-03-06Rockbox Utility: add "revision" information back.Dominik Riebeling2-3/+3
Add a revision-like information and make replace it with the git hash. Change-Id: Ic88ad0b2af255e76a7129a6a5cf52663b868fd32
2012-02-29Fix mismatching C++ new[] / delete callsThomas Jarosch1-9/+9
cppcheck report: [rbutil/rbutilqt/base/encoderlame.cpp:273]: (error) Mismatching allocation and deallocation: mp3buf [rbutil/rbutilqt/base/encoderlame.cpp:282]: (error) Mismatching allocation and deallocation: mp3buf [rbutil/rbutilqt/base/encoderlame.cpp:289]: (error) Mismatching allocation and deallocation: mp3buf [rbutil/rbutilqt/base/encoderlame.cpp:274]: (error) Mismatching allocation and deallocation: wavbuf [rbutil/rbutilqt/base/encoderlame.cpp:283]: (error) Mismatching allocation and deallocation: wavbuf [rbutil/rbutilqt/base/encoderlame.cpp:290]: (error) Mismatching allocation and deallocation: wavbuf [rbutil/rbutilqt/base/encoderlame.cpp:184]: (error) Mismatching allocation and deallocation: buf Change-Id: I9fd54b6e02817eb900ec6e24d967da6d4beaeb27
2012-02-26Rockbox Utility: update french translationJean-Louis Biasini1-26/+28
- change some strings that were not really nice - update empty strings Change-Id: Iab816bdbcd09bc254320c50d5eab424648b9a832 Reviewed-on: Reviewed-by: Dominik Riebeling <>
2012-02-23Rockbox Utility: update german translation.Dominik Riebeling1-35/+35
Change-Id: I6f514c79f23ea8aed341dd46c6f332aab57a1b0d
2012-02-23lupdate all translations and drop obsolete ones.Dominik Riebeling16-8543/+11595
Change-Id: I799c45018926e7a0138481b51258f73cbc17dd5d
2012-02-22Fix post installation hint for h100 / h300 players.Dominik Riebeling1-1/+1
Change-Id: I7af8883253281c85fef52001b291fcd942772e3d
2012-02-22Remove duplicate entry from postinstall hint.Dominik Riebeling1-4/+3
The Fuze+ has its own "disconnect player" message, so don't show the generic one here. Change-Id: Ibecac46d2434cb2c2b0369ff87649093252594ef
2012-02-22Don't poll SAPI script output.Dominik Riebeling1-5/+2
Wait for the process to signal new data available instead of polling its output. Fixes synchronisation issues with sapi_voice.vbs that were causing FS#12595. Change-Id: I86e844e837ed20f32005fdccf7ec9e8c1efbe983
2012-02-21Implement findProcess() on OS X.Dominik Riebeling1-1/+28
Change-Id: Iec5e91f1c8c08a58a19f79339d03247148347d45
2012-02-19Move Info tab content to a separate widget.Dominik Riebeling7-97/+195
Change-Id: I39a4e035372920f05f5fb3ab5bfc9459314997ad
2012-02-19Correct filename in manifest.Dominik Riebeling1-1/+1
Rockbox Utility binary has been renamed quite a while ago, make sure the manifest for Windows matches. Change-Id: If420075dc798ff3ec9c66e36f57d91af4e7d3b48
2012-02-19Fix RockboxInfo() not handling git hashes correctly.Dominik Riebeling3-32/+38
With the transition to git the assumption of the version starting with "r" isn't true anymore for non-release builds. This caused the wrong strings to be used when constructing various download URLs. Remove the test binary which was never intended to be added and fix some warnings in the test implementation. Change-Id: I879fdff201cb85f3c89cca73ab6a0514edb5a2df
2012-02-19Initial unit test of RockboxInfo class.Dominik Riebeling3-0/+178
This tests the original (svn revision number based) functionality. Change-Id: I69a121d751d2358c1e7594032f8f8193af59e103
2012-02-19Put test objects into test specific subfolder.Dominik Riebeling1-4/+4
Change-Id: Ib574524cfa61c2dde5b7d5522e88fbe9dd814996
2012-02-19Allow overriding filename for rockbox-info.txt.Dominik Riebeling2-4/+4
This allows testing the class by using temporary files without the need of constructing a special path. Change-Id: Id5ccd37f05219f246b9bf9f8a26ec81342654f89
2012-02-19Remove "r" prefix for version information.Dominik Riebeling17-65/+65
Since we don't have revision numbers anymore remove the "r" prefix when showing the version information to the user. Change-Id: I1e36b11a23301dda9fe67bb284489510c65567d8
2012-02-17Update rbutil russian translationСемён Жуковский1-95/+95
FS#12565 Change-Id: I1a7ec6c47f2ad0b5d6d72f3254d9627f9810687a Signed-off-by: Rafaël Carré <>
2012-02-14Move manual tab contents to separate widget.Dominik Riebeling8-190/+317
Create a new widget which holds the contents of the manual tab and its logic. Unify its display / download code. Fixes FS#12587, which was caused by duplicated code. Change-Id: I5721d2a95ebeaf80481c1fd149eda22cf1328501
2012-02-14Make configuration check reusable.Dominik Riebeling2-19/+19
Instead of passing a parameter to decide if a dialog box should be shown pass a pointer to the parent widget and make it static. This allows calling it from outside while keeping the possibility to not show a warning. Change-Id: I72fa53a7e8a83d527c22b698dfa434c24100ac29
2012-02-06Don't try to save settings if none available.Dominik Riebeling1-5/+6
Fixes a crash when leaving the encoder settings dialog with the Ok button but the dynamically loaded library missing, in which case no settings will be available. Change-Id: I889a0bbcde6bed2df658b5df57341edf6802daad
2012-02-05Update version to 1.2.12, OS X specific file.Dominik Riebeling1-1/+1
Change-Id: I08cd0939bfc7a7d3650ef0918524fb7d986172a9
2012-02-05Bump version to 1.2.12.Dominik Riebeling1-3/+4
Remove svn information from the version string as well, since we don't have this information anymore. Change-Id: I0055e6cd9e5e6cb1aaf678d91db183f4bc2117fe
2012-01-29Use relative paths to quazip includes.Dominik Riebeling3-7/+7
Shorten the include list a bit by using relative paths. Change-Id: I91fa7b292179c9f8cd0c257ef9b8d26bca34963b
2012-01-29findExecutable(): cleanup log output a bit.Dominik Riebeling1-2/+3
Change-Id: I217bddc91ff9ea43a5cfc018818f5a19b1555dd9
2012-01-29Centralize settings for executable based TTS systems.Dominik Riebeling2-13/+19
The configuration values for executable based TTS systems is stored in member variables. Instead of reading them multiple times provide a function for that and move searching the executable to the loading function. Previously the executable was only searched in the path when opening the TTS configuration. Having this in the loading function removes that unnecessary step in case the TTS is in the path (and doesn't require additional configuration). Change-Id: I06799b55545dcb719ee3c916795b20e01c248a15
2012-01-29Separate default quality setting for encoders.Dominik Riebeling3-24/+28
Instead of having a global quality setting for the encoder make the encoder provide its default value by itself. Fixes the libmp3lame encoder using an unsuitable value since the range differs greatly between the encoders. Centralize reading the configuration values for rbspeex. The values are stored in member variables, so it's not necessary to read them multiple times. Change-Id: Ia26cb1fc3bb4f927d13212fe7883bdfe2571a711
2012-01-29libmp3lame: add quality and volume settings.Dominik Riebeling2-8/+27
Change-Id: I220526f071dadc69791e5bf6d23cfce2bf9ba045
2012-01-22Check running processes at startup.Dominik Riebeling3-0/+58
Retrieve the processes running at startup and compare with a list of potentially problematic ones. Right now this is Itunes which is known to be able to cause problems when trying to install the bootloader on an Ipod. No user notification yet. This adds the implementation for Windows. Change-Id: I5ce8a85da52e0ed8f523b5ae6fb5d8f14f6a14c9
2012-01-17Fix a typo.Dominik Riebeling1-1/+1
Change-Id: I32a0d202385f025e0f450f7ba2fba5b6334d8f39
2012-01-17Fix unused-but-set warnings in helper functions.Dominik Riebeling1-25/+29
Instead of storing the return value and ignoring it use it directly to check if an error occured. Addresses FS#12542. Change-Id: I447afa006366acfd1851d5b13cae5f1561050283
2012-01-17TTS: check if created wav file exists.Dominik Riebeling2-1/+10
Instead of simply assuming the wav file that is supposed to be created by the TTS engine check if the file actually exists and return an error if not. Change-Id: I9e4a85a061b44b48931614602683b1dfe7dfce67
2012-01-15Add alternate firmware filenames for e200v2.Dominik Riebeling1-1/+1
Depending on the firmware version the filename is different, so it's necessary to look for all the possible filenames when searching the file inside the zip. The player happily accepts any of the filenames, so (as before) the first one is used. Additional firmware filenames might be necessary for other players as well. Change-Id: If78444a8d9b7fe167ce0be1d58407038a4f9052b
2012-01-15Support reading OF files from zip.Dominik Riebeling5-16/+84
Several devices require the original firmware to be able installing the bootloader. Most vendors distribute the firmware file in zip format. Extend reading the original firmware file to support reading the file from the zip directly instead of requiring the user to separately extract it. Change-Id: Ic4e89053456d8f7d6adc294f6657aceddbc354ba
2012-01-15Fix wavtrim on voicefile creation.Dominik Riebeling2-4/+11
Pass the threshold value for wavtrim to the TalkGenerator object instead of using the default value. Makes wavtrim to be actually used. Furthermore, check the result of the wavtrim call and respect its return value.