summaryrefslogtreecommitdiffstats
path: root/tools/checkwps/checkwps.c
AgeCommit message (Collapse)AuthorFilesLines
2020-10-26FIX RED Framebuffer_viewport_rewriteWilliam Wilgus1-0/+7
Change-Id: I716929fbee48bef68d7383efb944f9d491fdfe4d
2020-07-24[4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice.Solomon Peachy1-7/+1
Note: I left behind lcd_bitmap in features.txt, because removing it would require considerable work in the manual and the translations. Change-Id: Ia8ca7761f610d9332a0d22a7d189775fb15ec88a
2017-01-16Fix path handling snafu for CheckWPS toolMichael Sevakis1-1/+0
Somehow it got hooked to simulator file functions when it should be (and was) using raw OS functions. Credit: Frank Gevaerts Change-Id: Iac02fed1067830a432183632a047e00dfd03d3c2
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis1-2/+5
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: http://gerrit.rockbox.org/566 Reviewed-by: Michael Sevakis <jethead71@rockbox.org> Tested: Michael Sevakis <jethead71@rockbox.org>
2013-02-12fix checkwpsJonathan Gordon1-1/+2
Change-Id: Ie3bdfe18db6f8279f3575b253519fe4820649898
2012-09-24checkwps: Do not error out on rwps for non-remote targets.Thomas Martitz1-3/+9
This breaks themes on the theme site (that ship an rwps for remote targets) for non-remote targets. As rockbox just ignores the rwps checkwps now does the same. Change-Id: Id8c7833f0bd88d239dce87711456b94c93480a51
2012-07-31checkwps: harden filename extension checking.Thomas Martitz1-6/+18
Change-Id: I91aaacaaff621cfbeef9572df60b339a00475aa9
2012-07-31checkwps: Simplify expression.Thomas Martitz1-3/+2
Change-Id: I4d5cf82aa753074f81f25ae3d89a97ee607376e5
2011-11-21fix checkwpsJonathan Gordon1-0/+3
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31040 a1c6a512-1295-4272-9138-f99709370657
2011-11-15Use buflib for all skin engine allocations.Jonathan Gordon1-6/+5
Massive thanks to Michael Chicoine and other testers for finding the early bugs. This removes all skin memory limitations git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30991 a1c6a512-1295-4272-9138-f99709370657
2011-11-10try again, this time without compile errorsJonathan Gordon1-1/+3
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30951 a1c6a512-1295-4272-9138-f99709370657
2011-11-10Fix checkwpsJonathan Gordon1-0/+3
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30950 a1c6a512-1295-4272-9138-f99709370657
2011-10-17Fix checkwps reds and non-touchscreen warnings.Thomas Martitz1-0/+6
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30774 a1c6a512-1295-4272-9138-f99709370657
2011-09-24Fix the build errorsJonathan Gordon1-5/+4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30590 a1c6a512-1295-4272-9138-f99709370657
2010-10-18checkwps: properly zero the wps struct to avoid interesting issuesFrank Gevaerts1-1/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28308 a1c6a512-1295-4272-9138-f99709370657
2010-08-03make -vvv display the parse tree in checkwps. Fix a potential bug in the ↵Jonathan Gordon1-0/+2
parser where recursive tags (the playlist viewier) would share params with its parant which meant bad things git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27677 a1c6a512-1295-4272-9138-f99709370657
2010-07-29FS#11470 - new skin code, finally svn uses the new parser from the theme ↵Jonathan Gordon1-2/+13
editor. This means that a skin that passes the editor WILL pass svn and checkwps (unless the target runs out of skin buffer or something. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27613 a1c6a512-1295-4272-9138-f99709370657
2010-05-16make checkwps accept .rfms files as remote skinsJonathan Gordon1-1/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26082 a1c6a512-1295-4272-9138-f99709370657
2010-05-12FS#10853 - Skin support in the radio screen! Check CustomWPS for the new tagsJonathan Gordon1-0/+7
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25964 a1c6a512-1295-4272-9138-f99709370657
2010-05-03Move read_line() further down so that it can be used in checkwps and remove ↵Thomas Martitz1-30/+0
checkwps' copy if it. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25793 a1c6a512-1295-4272-9138-f99709370657
2010-02-24some minor changes to checkwps, shouldn't change anythingJonathan Gordon1-1/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24874 a1c6a512-1295-4272-9138-f99709370657
2010-02-17Make checkwps compile again for the player. If we had proper multifont on ↵Frank Gevaerts1-0/+2
charcell this would never have happened git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24735 a1c6a512-1295-4272-9138-f99709370657
2010-02-17Initialuse user font table for checkwps. This is normally done from the ↵Frank Gevaerts1-0/+1
settings code, which isn't run in this case git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24734 a1c6a512-1295-4272-9138-f99709370657
2010-02-14FS#10984 - multifont! 2 major additions:Jonathan Gordon1-0/+16
1) seperate UI font for the remote and main displays 2) allow individual skins to load additional fonts for use in the skin (Uo to 7 extra in this first version) see CustomWPS for info on how to load a font in the skins. Code should always use FONT_UI+screen_number to get the correct user font git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24644 a1c6a512-1295-4272-9138-f99709370657
2010-01-29fix redsJonathan Gordon1-2/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24367 a1c6a512-1295-4272-9138-f99709370657
2010-01-27fix red... lets branchJonathan Gordon1-2/+7
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24341 a1c6a512-1295-4272-9138-f99709370657
2009-11-19CheckWPS: set screen to SCREEN_MAIN when not a r{sb,wp}s.Maurus Cuelenaere1-0/+2
This fixes the potential bug of mislabeling an {sb,wp}s as remote while it's not. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23668 a1c6a512-1295-4272-9138-f99709370657
2009-11-19make checkwps able to check .rsbs files.Dominik Wenger1-1/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23667 a1c6a512-1295-4272-9138-f99709370657
2009-11-04Forgot to remove wps_data.remove_wps in checkwps too.Thomas Martitz1-8/+0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23514 a1c6a512-1295-4272-9138-f99709370657
2009-11-04Reorder a bit in viewport.c so that we don't need stubs for checkwps.Thomas Martitz1-18/+0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23511 a1c6a512-1295-4272-9138-f99709370657
2009-11-04Fix checkwps. Reimplement viewport_set_fullscreen() and ↵Jonathan Gordon1-7/+24
viewport_set_defaults() to always return the "full display". This doesn't change anything about the skin so is fine. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23510 a1c6a512-1295-4272-9138-f99709370657
2009-11-01Move find_viewport() and find_image() to skin_parser.c where the reset of ↵Thomas Martitz1-76/+0
the linked-list handling sits. That enables removing duplicated code from checkwps. Also remove a few stubs in favor having the restart playback mechanism on albumart change #ifdef __PCTOOL__ git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23465 a1c6a512-1295-4272-9138-f99709370657
2009-11-01haloween night is when red monsters are vanquished right? or is that green ↵Jonathan Gordon1-1/+0
monsters? git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23456 a1c6a512-1295-4272-9138-f99709370657
2009-10-20wps_screen is still needed for the HAVE_REMOTE_LCD caseFrank Gevaerts1-0/+3
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23292 a1c6a512-1295-4272-9138-f99709370657
2009-10-20compile checkwps with -Wall, to avoid accidentally breaking it again when a ↵Frank Gevaerts1-1/+2
function prototype changes git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23291 a1c6a512-1295-4272-9138-f99709370657
2009-10-20fix checkwpsMichael Chicoine1-1/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23290 a1c6a512-1295-4272-9138-f99709370657
2009-10-16Fix Player, checkwps and database toolsThomas Martitz1-0/+12
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23215 a1c6a512-1295-4272-9138-f99709370657
2009-09-13Get rid of some of the code duplication from checkwps, it still duplicates a ↵Thomas Martitz1-119/+1
lot though. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22695 a1c6a512-1295-4272-9138-f99709370657
2009-09-11Fix checkwps compilation for the PlayerFrank Gevaerts1-0/+4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22680 a1c6a512-1295-4272-9138-f99709370657
2009-09-04fix checkwpsJonathan Gordon1-16/+0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22619 a1c6a512-1295-4272-9138-f99709370657
2009-08-21Don't add #ifdef's without looking them up...Maurus Cuelenaere1-1/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22455 a1c6a512-1295-4272-9138-f99709370657
2009-08-21Checkwps: give wps_screen an initial valueMaurus Cuelenaere1-1/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22454 a1c6a512-1295-4272-9138-f99709370657
2009-08-21Fix building checkwps on targets without a remoteMaurus Cuelenaere1-0/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22453 a1c6a512-1295-4272-9138-f99709370657
2009-08-21Fix checkwps for remote screensMaurus Cuelenaere1-4/+18
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22452 a1c6a512-1295-4272-9138-f99709370657
2009-08-21Fix/hack checkwps + add Onda VX747/VX777 targetsMaurus Cuelenaere1-25/+203
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22451 a1c6a512-1295-4272-9138-f99709370657
2009-02-27Newer glibc has letoh16 and friends, so use them if availableFrank Gevaerts1-0/+7
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20128 a1c6a512-1295-4272-9138-f99709370657
2009-01-29Get checkwps working againMaurus Cuelenaere1-2/+50
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19880 a1c6a512-1295-4272-9138-f99709370657
2008-07-30Commit FS#9012 thanks to Thomas MartitzMaurus Cuelenaere1-6/+18
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18153 a1c6a512-1295-4272-9138-f99709370657
2008-07-06fix checkwps againJonathan Gordon1-1/+11
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17958 a1c6a512-1295-4272-9138-f99709370657
2008-07-06get checkwps building again (FS#9150) - still doesnt compile on d2 and mr500 ↵Jonathan Gordon1-14/+35
though git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17957 a1c6a512-1295-4272-9138-f99709370657