summaryrefslogtreecommitdiffstats
path: root/uisimulator/common
AgeCommit message (Collapse)AuthorFilesLines
2014-08-30Get the last errors I hope!Michael Sevakis1-0/+22
Change-Id: Ia285b95480cc9ac6494b745d80892c4b1b912341
2014-08-30Rewrite filesystem code (WIP)Michael Sevakis9-740/+1120
This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: http://gerrit.rockbox.org/566 Reviewed-by: Michael Sevakis <jethead71@rockbox.org> Tested: Michael Sevakis <jethead71@rockbox.org>
2014-02-23Fix redsThomas Martitz1-0/+2
Change-Id: Ib2036d0786bd6fa39c5dadeeed83d74c7bd5c273
2014-02-23simulator: Fully simulate external storage.Thomas Martitz1-13/+59
The external storage will be created during make install, as simext folder in the build directory. Upon pressing the e key the sim will mount (virtually ) this into the root directory. It can be accessed in the same way as an sd/mmc card on real targets. This requires quite some path trickery in io.c. Change-Id: I2fa9070a3146101ec5655b5b4115ca349d1d4bf4
2014-02-23RaaA: Move directory related stuff from filesystem-unix.c into rbpaths.c.Thomas Martitz1-38/+44
Part of this change is to align sdlapp builds to other application targets in that the sim_* wrappers are not used anymore (except for sim_read/write). Path mangling is now done in rbpaths.c as well. Change-Id: I9726da73b50a83d9e1a1840288de16ec01ea029d
2014-02-23simulator: Simulate external storage for HAVE_MULTIDRIVE.Thomas Martitz3-7/+59
The virtual external storage can be inserted/extracted with the e key. This has little effect because there is no way to access the storage (yet, a later commit will change this). Except on ondio where the mmc needs to be extracted before entering USB (like on real target). Change-Id: I523402832f3b4ae71e0603b281aba4fb8592a897
2014-02-23storage: Add STORAGE_HOSTFSThomas Martitz1-0/+7
CONFIG_STORAGE & STORAGE_HOSTFS allows to use parts of the storage_* API to be compiled for application targets without compiling storage.c or performing actually raw storage access. This is primarily to enable application targets to implement HAVE_MULTIVOMULE/HAVE_HOTSWAP (in a later commit). SIMULATOR uses the same mechanism without explicitely defining STORAGE_HOSTFS (how to add a bit to an existing preprocessor token?). Change-Id: Ib3f8ee0d5231e2ed21ff00842d51e32bc4fc7292
2013-09-05fix redAmaury Pouly1-2/+2
Change-Id: Ibca5879553a87e77014f850308d9b54cc339d474
2013-09-05touch devices: Disable touch on softlock.Jean-Louis Biasini1-0/+14
Target that have a touchpad/touchscreen should disable it while being locked (In order to avoid LCD to drain battery power due to "key locked" constant reporting messages. If they a have a keylock button this was already handled at driver level. If not (e.g. fuze+), they will have to implement a switch at driver level that action.c can operate on softlock. This patch does the following for any target having a touchpad or a touchscreen and no HAS_BUTTON_HOLD (ie any softlock target) 1) it implements the code to call button_enable_touch(bool en) in action.c. 2) button_enable_touch is implemented in button.c and call either touchpad_enable or touchscreen_enable 3) those two function are implemented respectively in touchscreen.c and a new touchpad.c file. They provide a generic way to silents touch's device and call a function at driver level where target specific code can be implemented if possible/needed (for power saving for instance). Those function name are touchpad_enable_device and touchscreen_enable_device 4) we implement an empty function at driver level of targets that need it to have them still being able to compiled. Change-Id: I9ead78a25bd33466a8533f5b9f259b395cb5ce49 Reviewed-on: http://gerrit.rockbox.org/569 Reviewed-by: Thomas Martitz <kugel@rockbox.org> Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
2013-08-17Cleanup MV/MD macros a little.Michael Sevakis2-4/+4
When using variadic macros there's no need for IF_MD2/IF_MV2 to deal with function parameters. IF_MD/IF_MV are enough. Throw in IF_MD_DRV/ID_MV_VOL that return the parameter if MD/MV, or 0 if not. Change-Id: I7605e6039f3be19cb47110c84dcb3c5516f2c3eb
2013-04-15Keep fixing 0c7b787 stuffMichael Sevakis1-5/+0
Change-Id: I0678d3307fbcad32156f9f4e0f8b90eed5a20d92
2012-07-31Fix database tool.Thomas Martitz1-1/+1
It was also broken functionally, probably since a while.So restore the functionality. Run it on the dap, the tcd files will be placed into .rockbox folder. Change-Id: Id7a6ce4389dfaf99799258902be80d630af0601c
2012-07-18Fix warnings and errors in sdl builds.Thomas Martitz1-0/+1
Change-Id: Ia8fb00739fb2083d57257d0a3b08cbab9e5a18ff
2012-07-18Call call_storage_idle_notifys() to make storage idle callbacks work inThomas Martitz1-0/+2
the sim. Change-Id: I40cdf0fd8881a6041b116a687602e231097ba732
2012-06-23Fix a bug introduced in 91b52a1, broken icons in the Archos Player simulator.Szymon Dziok1-1/+1
Change-Id: I2c4ef0828a9e44084f35b82ea71e430d0c14ecfb
2012-06-18Remove #ifdef USB_FULL_INIT from sim_tasks.c to make usb_wait_for_disconnect ↵Bertrik Sikken1-3/+0
work Change-Id: I5976da266c60501820a359be8e3e40a3edb738c7
2012-05-26load_code: Get rid of win32 specific code in favor SDL_LoadFunction & ↵Thomas Martitz1-6/+58
friends APIs. Refactor native/hosted implementation seperation while at it (no wrappers starting with _ anymore). Change-Id: If68ae89700443bb3be483c1cace3d6739409560a
2012-03-04Tweak paramters of mp3_play_data and callback.Michael Sevakis1-3/+4
Use generic void * and size_t and make mp3_play_data and its callback agree on types. Use mp3_play_callback_t instead of prototyping right in the function call (so it's not so messy to look at). Change doesn't appear to require plugin API version increment. Change-Id: Idcab2740ee316a2beb6e0a87b8f4934d9d6b3dd8
2012-03-03Fix __PCTOOL__ dependencies on SIMULATORFrank Gevaerts1-1/+1
* filesize() is not POSIX, so it doesn't need stubbing or redirecting * make the various directory functions use the sim_ versions for PCTOOL * PCTOOL needs generic byteswap functions * fix the database makefile to not use -DSIMULATOR anymore Change-Id: Ic6abc4f662830b85626c751a472fa4a03e844871
2012-02-19Fix warn_unused_result warning.Dominik Riebeling1-2/+8
A warning triggered by attribute warn_unused_result cannot be suppressed by casting the result to void. Properly check the return value and pass it to the caller. Fix the check for the number of bytes written. The return value of fread is the number of items written, not the number of bytes. Change-Id: I8c60e23ac549e22fd3f7dd5c51c5a8e6fc517cb1
2012-01-25Fix power_input_status in sim where target has a battery switch.Michael Sevakis1-1/+7
Change-Id: Ic00410a5b143d71928dc67c47d94d317b8ecadcd
2012-01-22Fix another uninitialized var warning.Thomas Martitz1-3/+3
Change-Id: I27d06003d5e9218a940057af1b5c5c1557e7653c
2012-01-22Another attempt at fixing storage_*_warnings. Correct return values also.Thomas Martitz1-3/+6
Change-Id: Ie04da59739f2ce31d5b777157b1214c921aa5615
2012-01-22Attempt to fix remaining warnings.Thomas Martitz1-2/+2
Change-Id: I6c5b5b24db9f52272fc8765942ddcfff0eb3a8ab
2012-01-22Fix one more warning.Thomas Martitz1-1/+1
Change-Id: I194f686173acabffed2c41467a4b280b0b7a8e6f
2012-01-21Hosted: Merge debugf() implementations. Cleanup debug.h.Thomas Martitz1-40/+0
Fixes debug build for ypr0. Change-Id: I9c0eff651dcf268a3fafed1a71fcc47f3e323d36
2012-01-08Simulator: Emulate a period of external power after charging.Nick Peskett1-29/+55
Also a bit of optimisation of battery_status_update(). FS#12506 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31635 a1c6a512-1295-4272-9138-f99709370657
2012-01-07move _remote_backlight_* to common headerRafaël Carré1-6/+0
remove unused REMOTE_INIT_LCD / REMOTE_DEINIT_LCD git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31607 a1c6a512-1295-4272-9138-f99709370657
2012-01-05Fix charger emulation in the simulator.Nick Peskett1-7/+7
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31586 a1c6a512-1295-4272-9138-f99709370657
2012-01-04Fix reds by implementing a few more stubs, and undefining HAVE_STORAGE_FLUSH ↵Thomas Martitz2-6/+25
in the sim. Also slight change on how to measure seconds. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31550 a1c6a512-1295-4272-9138-f99709370657
2012-01-03Rework powermgmt to enable code re-use on appliation and sims.Thomas Martitz4-71/+26
* Introduce CONFIG_BATTERY_MEASURE define, to allow targets (application) to break powermgmt.c's assumption about the ability to read battery voltage. There's now additionally percentage (android) and remaining time measure (maemo). No measure at all also works (sdl app). If voltage can't be measured, then battery_level() is king and it'll be used for power_history and runtime estimation. * Implement target's API in the simulator, i.e. _battery_voltage(), so it doesn't need to implement it's own powermgmt.c and other stubs. Now the sim behaves much more like a native target, although it still changes the simulated battery voltage quickly, * Other changes include include renaming battery_adc_voltage() to _battery_voltage(), for consistency with the new target functions and making some of the apps code aware that voltage and runtime estimation is not always available. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31548 a1c6a512-1295-4272-9138-f99709370657
2011-11-17stubs.c is only needed on SIMULATOR builds.Thomas Martitz1-1/+1
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31025 a1c6a512-1295-4272-9138-f99709370657
2011-11-17Remove sim_tasks from the sdl application build.Thomas Martitz1-1/+1
This unfortunately removes the screendump feature, but usually there are better desktop apps for that. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31011 a1c6a512-1295-4272-9138-f99709370657
2011-11-17Simulate usb plugging on the sim better using sim_tasks.Thomas Martitz2-0/+97
Now all threads need to ack the connection like on real target, dircache is unloaded and playback stops accordingly. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31009 a1c6a512-1295-4272-9138-f99709370657
2011-10-30Fix simulator brightness calculation in case MIN_BRIGHTNESS_SETTING != 1Bertrik Sikken1-1/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30870 a1c6a512-1295-4272-9138-f99709370657
2011-10-04r30706 was not the right fix - thanks to amiconn for catching the errorMichael Chicoine1-3/+3
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30707 a1c6a512-1295-4272-9138-f99709370657
2011-10-03Fix w32 cross-compiled sim showing 0KB for disk size and disk freeMichael Chicoine1-2/+2
in System -> Rockbox Info git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30706 a1c6a512-1295-4272-9138-f99709370657
2011-09-03Fix warning, 'read_next:' is only used when EOVERFLOW is defined.Andree Buschmann1-0/+2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30414 a1c6a512-1295-4272-9138-f99709370657
2011-06-20Dircache: Don't expose struct dircache_entry and pointers into the cache, ↵Thomas Martitz1-4/+3
use IDs instead. Only integer IDs are exposed from dircache with this. This way the cache is isolated from other modules. This is needed for my buflib gsoc project. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30038 a1c6a512-1295-4272-9138-f99709370657
2011-06-12Work around missing EOVERFLOW define on cygwin/mingw.Thomas Jarosch1-0/+2
According to the mighty google, stat() will just return an incorrect file size for files > 2 GB on cygwin. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29995 a1c6a512-1295-4272-9138-f99709370657
2011-06-10RaaA / sim: Don't abort directory read if we encounter files larger than 2 ↵Thomas Jarosch1-1/+15
GB in a directory git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29992 a1c6a512-1295-4272-9138-f99709370657
2011-04-16Fix regression in r29715: files listed multiple times in uisimulatorMichael Hohmuth1-2/+4
Fixes FS#12066. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29717 a1c6a512-1295-4272-9138-f99709370657
2011-04-15Better dircache handling in simulatorMichael Hohmuth1-3/+16
Actually add files to the dircache (as well as removing them) and remove them only when they were found on disk. This matches the native behavior and prevents the dircache from becoming uninitialized when a previously created or nonexisting file is being removed. This typically would happen during a database update. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29715 a1c6a512-1295-4272-9138-f99709370657
2011-03-08RaaA: Add RTC supportThomas Jarosch1-18/+0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29544 a1c6a512-1295-4272-9138-f99709370657
2011-03-08Bring idle poweroff to RaaA and the simThomas Jarosch1-9/+0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29543 a1c6a512-1295-4272-9138-f99709370657
2011-03-01Expose sys_poweroff() and cancel_shutdown() to RaaA. Hopefully fixes android ↵Thomas Jarosch1-4/+0
build git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29485 a1c6a512-1295-4272-9138-f99709370657
2011-02-28Move sleep timer code outside of PLATFORM_NATIVE ifdef so RaaA can access itThomas Jarosch1-11/+0
Also remove redundant RaaA stubs for it. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29467 a1c6a512-1295-4272-9138-f99709370657
2011-02-28Hopefully get shutdown/exit handling on SDL/maemo right.Thomas Martitz1-10/+0
Make shutdown_hw() not return as it's supposed to, ensure sim_do_exit() is called from main thread and move sim_kernel_shutdown() into it to simplify things. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29455 a1c6a512-1295-4272-9138-f99709370657
2011-02-18Implement cooperative threads on hosted platforms using C code.Thomas Martitz1-2/+5
This replaces SDL threads with real cooperative threads, which are less cpu intensive and allow priority scheduling. The backend for context switching is dependant on the host (sigaltstack/longjmp on Unix, Fibers on Windows). configure has options to force or disallow SDL threads. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29327 a1c6a512-1295-4272-9138-f99709370657
2011-02-15Fix the shutdown sequence for maemo, SDL and simulator buildsThomas Jarosch1-0/+6
Do proper shutdown in RaaA builds like writeout of last.FM scrobbler file and other neat things. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29309 a1c6a512-1295-4272-9138-f99709370657