From 66690ca98709773c2591d6090d9c0274bb723c37 Mon Sep 17 00:00:00 2001
From: Amaury Pouly <amaury.pouly@gmail.com>
Date: Tue, 30 Dec 2014 17:36:59 +0100
Subject: Get rid of USE_ROCKBOX_USB

Except for unfinished or experimental ports, it isthe case that
USE_ROCKBOX_USB and HAVE_USBSTACK are both defined or both undefined.
Furthermore, it is a leftover of some early developments on the USB stack and
doesn't make sense anymore.

Change-Id: Ic87a865b6bb4c7c9a8d45d1f0bb0f2fb536b8cad
Reviewed-on: http://gerrit.rockbox.org/1091
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
---
 apps/features.txt                            |  2 +-
 firmware/drivers/ata.c                       |  2 +-
 firmware/export/config.h                     |  2 --
 firmware/export/config/cowond2.h             |  1 -
 firmware/export/config/creativezen.h         |  1 -
 firmware/export/config/creativezenmozaic.h   |  1 -
 firmware/export/config/creativezenv.h        |  1 -
 firmware/export/config/creativezenxfi.h      |  1 -
 firmware/export/config/creativezenxfi2.h     |  1 -
 firmware/export/config/creativezenxfi3.h     |  1 -
 firmware/export/config/creativezenxfistyle.h |  1 -
 firmware/export/config/creativezv.h          |  1 -
 firmware/export/config/gigabeats.h           |  1 -
 firmware/export/config/gogearhdd1630.h       |  1 -
 firmware/export/config/gogearhdd6330.h       |  1 -
 firmware/export/config/gogearsa9200.h        |  1 -
 firmware/export/config/hifietma8.h           |  1 -
 firmware/export/config/hifietma8c.h          |  1 -
 firmware/export/config/hifietma9.h           |  1 -
 firmware/export/config/hifietma9c.h          |  1 -
 firmware/export/config/hifimanhm60x.h        |  1 -
 firmware/export/config/hifimanhm801.h        |  1 -
 firmware/export/config/ihifi760.h            |  1 -
 firmware/export/config/ihifi960.h            |  1 -
 firmware/export/config/ipod4g.h              |  1 -
 firmware/export/config/ipod6g.h              |  1 -
 firmware/export/config/ipodcolor.h           |  1 -
 firmware/export/config/ipodmini1g.h          |  1 -
 firmware/export/config/ipodmini2g.h          |  1 -
 firmware/export/config/ipodnano1g.h          |  1 -
 firmware/export/config/ipodnano2g.h          |  1 -
 firmware/export/config/ipodvideo.h           |  1 -
 firmware/export/config/iriverh10.h           |  1 -
 firmware/export/config/iriverh10_5gb.h       |  1 -
 firmware/export/config/mrobe100.h            |  1 -
 firmware/export/config/mrobe500.h            |  1 -
 firmware/export/config/ondavx747.h           |  1 -
 firmware/export/config/ondavx767.h           |  1 -
 firmware/export/config/ondavx777.h           |  1 -
 firmware/export/config/rk27generic.h         |  1 -
 firmware/export/config/samsungyh820.h        |  1 -
 firmware/export/config/samsungyh920.h        |  1 -
 firmware/export/config/samsungyh925.h        |  1 -
 firmware/export/config/samsungyps3.h         |  1 -
 firmware/export/config/samsungypz5.h         |  1 -
 firmware/export/config/sansac200.h           |  1 -
 firmware/export/config/sansac200v2.h         |  1 -
 firmware/export/config/sansaclip.h           |  1 -
 firmware/export/config/sansaclipplus.h       |  1 -
 firmware/export/config/sansaclipv2.h         |  1 -
 firmware/export/config/sansaclipzip.h        |  1 -
 firmware/export/config/sansae200.h           |  1 -
 firmware/export/config/sansae200v2.h         |  1 -
 firmware/export/config/sansafuze.h           |  1 -
 firmware/export/config/sansafuzeplus.h       |  1 -
 firmware/export/config/sansafuzev2.h         |  1 -
 firmware/export/config/sansam200v4.h         |  1 -
 firmware/export/config/sansaview.h           |  1 -
 firmware/export/config/sim.h                 |  1 -
 firmware/export/config/sonynwze360.h         |  1 -
 firmware/export/config/sonynwze370.h         |  1 -
 firmware/export/config/vibe500.h             |  1 -
 firmware/export/config/zenvisionm30gb.h      |  1 -
 firmware/export/config/zenvisionm60gb.h      |  1 -
 firmware/target/arm/as3525/usb-as3525.c      |  2 +-
 firmware/usb.c                               | 19 ++++---------------
 66 files changed, 7 insertions(+), 81 deletions(-)

diff --git a/apps/features.txt b/apps/features.txt
index d9ca1a3ece..997727dbd9 100644
--- a/apps/features.txt
+++ b/apps/features.txt
@@ -258,7 +258,7 @@ scrollwheel
 usb_power
 #endif
 
-#if defined(HAVE_USBSTACK) && defined(USE_ROCKBOX_USB)
+#if defined(HAVE_USBSTACK)
 usbstack
 #endif
 
diff --git a/firmware/drivers/ata.c b/firmware/drivers/ata.c
index 355ff37900..b98567e8bf 100644
--- a/firmware/drivers/ata.c
+++ b/firmware/drivers/ata.c
@@ -79,7 +79,7 @@
 static unsigned int ata_thread_id = 0;
 #endif
 
-#if defined(HAVE_USBSTACK) && defined(USE_ROCKBOX_USB)
+#if defined(HAVE_USBSTACK)
 #define ALLOW_USB_SPINDOWN
 #endif
 
diff --git a/firmware/export/config.h b/firmware/export/config.h
index bf95dc4c09..1f57734231 100644
--- a/firmware/export/config.h
+++ b/firmware/export/config.h
@@ -1178,9 +1178,7 @@ Lyre prototype 1 */
 #if (CONFIG_PLATFORM & PLATFORM_NATIVE)
 #ifdef USB_HAS_BULK
 //#define USB_ENABLE_SERIAL
-#ifdef USE_ROCKBOX_USB
 #define USB_ENABLE_STORAGE
-#endif /* USE_ROCKBOX_USB */
 #endif /* USB_HAS_BULK */
 
 #ifdef USB_HAS_INTERRUPT
diff --git a/firmware/export/config/cowond2.h b/firmware/export/config/cowond2.h
index 1d9961b2ae..d4623381fc 100644
--- a/firmware/export/config/cowond2.h
+++ b/firmware/export/config/cowond2.h
@@ -9,7 +9,6 @@
 
 #if 0
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0e21
 #define USB_PRODUCT_ID 0x0800
 #endif
diff --git a/firmware/export/config/creativezen.h b/firmware/export/config/creativezen.h
index ab9506772a..3667142791 100644
--- a/firmware/export/config/creativezen.h
+++ b/firmware/export/config/creativezen.h
@@ -180,7 +180,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x4162
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezenmozaic.h b/firmware/export/config/creativezenmozaic.h
index 664459bf89..3a95d0388a 100644
--- a/firmware/export/config/creativezenmozaic.h
+++ b/firmware/export/config/creativezenmozaic.h
@@ -180,7 +180,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x4133
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezenv.h b/firmware/export/config/creativezenv.h
index 03dc261b85..3e9be8ba29 100644
--- a/firmware/export/config/creativezenv.h
+++ b/firmware/export/config/creativezenv.h
@@ -177,7 +177,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x4133
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezenxfi.h b/firmware/export/config/creativezenxfi.h
index db68617c78..35bd1efdfb 100644
--- a/firmware/export/config/creativezenxfi.h
+++ b/firmware/export/config/creativezenxfi.h
@@ -187,7 +187,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x4162
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezenxfi2.h b/firmware/export/config/creativezenxfi2.h
index cc38aae123..5b275b1de8 100644
--- a/firmware/export/config/creativezenxfi2.h
+++ b/firmware/export/config/creativezenxfi2.h
@@ -189,7 +189,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x2020
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezenxfi3.h b/firmware/export/config/creativezenxfi3.h
index 1a5fa25ae5..9adf593a99 100644
--- a/firmware/export/config/creativezenxfi3.h
+++ b/firmware/export/config/creativezenxfi3.h
@@ -193,7 +193,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x2020
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezenxfistyle.h b/firmware/export/config/creativezenxfistyle.h
index 7b8415c8c8..b7d3d61d85 100644
--- a/firmware/export/config/creativezenxfistyle.h
+++ b/firmware/export/config/creativezenxfistyle.h
@@ -183,7 +183,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e
 #define USB_PRODUCT_ID 0x200a
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/creativezv.h b/firmware/export/config/creativezv.h
index b96bfcce77..ce812d38c9 100644
--- a/firmware/export/config/creativezv.h
+++ b/firmware/export/config/creativezv.h
@@ -163,7 +163,6 @@
 
 #define CONFIG_USBOTG USBOTG_ISP1583
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e 
 #define USB_PRODUCT_ID 0x4133
 #define USB_NUM_ENDPOINTS 7
diff --git a/firmware/export/config/gigabeats.h b/firmware/export/config/gigabeats.h
index 6657134f9d..b20a6934a7 100644
--- a/firmware/export/config/gigabeats.h
+++ b/firmware/export/config/gigabeats.h
@@ -217,7 +217,6 @@
 #define CONFIG_USBOTG USBOTG_ARC
 
 /* enable these for the usb stack */
-#define USE_ROCKBOX_USB
 #define HAVE_USBSTACK
 /* usb stack and driver settings */
 #define USB_PORTSCX_PHY_TYPE PORTSCX_PTS_ULPI
diff --git a/firmware/export/config/gogearhdd1630.h b/firmware/export/config/gogearhdd1630.h
index e1e0af0566..3898c3f4fd 100644
--- a/firmware/export/config/gogearhdd1630.h
+++ b/firmware/export/config/gogearhdd1630.h
@@ -192,7 +192,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0471
 #define USB_PRODUCT_ID 0x014C
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/gogearhdd6330.h b/firmware/export/config/gogearhdd6330.h
index fde8364ded..b250de86be 100644
--- a/firmware/export/config/gogearhdd6330.h
+++ b/firmware/export/config/gogearhdd6330.h
@@ -194,7 +194,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0471
 #define USB_PRODUCT_ID 0x014B
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/gogearsa9200.h b/firmware/export/config/gogearsa9200.h
index 90d5ad6938..04dcf8abc4 100644
--- a/firmware/export/config/gogearsa9200.h
+++ b/firmware/export/config/gogearsa9200.h
@@ -173,7 +173,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0471
 #define USB_PRODUCT_ID 0x014f
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/hifietma8.h b/firmware/export/config/hifietma8.h
index f5cf8cfac3..53aee996c8 100644
--- a/firmware/export/config/hifietma8.h
+++ b/firmware/export/config/hifietma8.h
@@ -115,7 +115,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/hifietma8c.h b/firmware/export/config/hifietma8c.h
index 897716b3c8..bc49701165 100644
--- a/firmware/export/config/hifietma8c.h
+++ b/firmware/export/config/hifietma8c.h
@@ -115,7 +115,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/hifietma9.h b/firmware/export/config/hifietma9.h
index 5df1a5fac4..81eedb3421 100644
--- a/firmware/export/config/hifietma9.h
+++ b/firmware/export/config/hifietma9.h
@@ -115,7 +115,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/hifietma9c.h b/firmware/export/config/hifietma9c.h
index 43f20de0c8..21106c7e50 100644
--- a/firmware/export/config/hifietma9c.h
+++ b/firmware/export/config/hifietma9c.h
@@ -115,7 +115,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/hifimanhm60x.h b/firmware/export/config/hifimanhm60x.h
index dbd7478338..433b2c4beb 100644
--- a/firmware/export/config/hifimanhm60x.h
+++ b/firmware/export/config/hifimanhm60x.h
@@ -149,7 +149,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/hifimanhm801.h b/firmware/export/config/hifimanhm801.h
index b1c1550183..9b4feea083 100644
--- a/firmware/export/config/hifimanhm801.h
+++ b/firmware/export/config/hifimanhm801.h
@@ -137,7 +137,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/ihifi760.h b/firmware/export/config/ihifi760.h
index f31d64cac9..e618c1bf56 100644
--- a/firmware/export/config/ihifi760.h
+++ b/firmware/export/config/ihifi760.h
@@ -149,7 +149,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/ihifi960.h b/firmware/export/config/ihifi960.h
index 06dcc8681e..d39ef82f98 100644
--- a/firmware/export/config/ihifi960.h
+++ b/firmware/export/config/ihifi960.h
@@ -149,7 +149,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/ipod4g.h b/firmware/export/config/ipod4g.h
index 39890cbb19..dc83a594fc 100644
--- a/firmware/export/config/ipod4g.h
+++ b/firmware/export/config/ipod4g.h
@@ -202,7 +202,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x05ac
 #define USB_PRODUCT_ID 0x1203
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/ipod6g.h b/firmware/export/config/ipod6g.h
index 5590c96be1..d38f604f9f 100644
--- a/firmware/export/config/ipod6g.h
+++ b/firmware/export/config/ipod6g.h
@@ -243,7 +243,6 @@
 #define USB_VENDOR_ID 0x05AC
 #define USB_PRODUCT_ID 0x1261
 #define USB_NUM_ENDPOINTS 6
-#define USE_ROCKBOX_USB
 #define USB_DEVBSS_ATTR __attribute__((aligned(16)))
 
 /* Define this if you can switch on/off the accessory power supply */
diff --git a/firmware/export/config/ipodcolor.h b/firmware/export/config/ipodcolor.h
index 960adf97d6..9f34a7955b 100644
--- a/firmware/export/config/ipodcolor.h
+++ b/firmware/export/config/ipodcolor.h
@@ -189,7 +189,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x05ac
 #define USB_PRODUCT_ID 0x1204
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/ipodmini1g.h b/firmware/export/config/ipodmini1g.h
index 147812124a..71dfe16c04 100644
--- a/firmware/export/config/ipodmini1g.h
+++ b/firmware/export/config/ipodmini1g.h
@@ -201,7 +201,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x05ac
 #define USB_PRODUCT_ID 0x1205
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/ipodmini2g.h b/firmware/export/config/ipodmini2g.h
index 60959d64e8..a2b199afee 100644
--- a/firmware/export/config/ipodmini2g.h
+++ b/firmware/export/config/ipodmini2g.h
@@ -202,7 +202,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x05ac
 #define USB_PRODUCT_ID 0x1205
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/ipodnano1g.h b/firmware/export/config/ipodnano1g.h
index 2a3bf4bb7a..acdfff3c15 100644
--- a/firmware/export/config/ipodnano1g.h
+++ b/firmware/export/config/ipodnano1g.h
@@ -189,7 +189,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x05ac
 #define USB_PRODUCT_ID 0x120a
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/ipodnano2g.h b/firmware/export/config/ipodnano2g.h
index 2c7db2a095..5ad41a16c1 100644
--- a/firmware/export/config/ipodnano2g.h
+++ b/firmware/export/config/ipodnano2g.h
@@ -227,7 +227,6 @@
 #define USB_VENDOR_ID 0x05AC
 #define USB_PRODUCT_ID 0x1260
 #define USB_NUM_ENDPOINTS 6
-#define USE_ROCKBOX_USB
 #define USB_DEVBSS_ATTR __attribute__((aligned(16)))
 
 /* Define this if you can switch on/off the accessory power supply */
diff --git a/firmware/export/config/ipodvideo.h b/firmware/export/config/ipodvideo.h
index 8a6e53dc16..2f28182731 100644
--- a/firmware/export/config/ipodvideo.h
+++ b/firmware/export/config/ipodvideo.h
@@ -208,7 +208,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x05ac
 #define USB_PRODUCT_ID 0x1209
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/iriverh10.h b/firmware/export/config/iriverh10.h
index a5d0bf5d47..efa0c993a1 100644
--- a/firmware/export/config/iriverh10.h
+++ b/firmware/export/config/iriverh10.h
@@ -173,7 +173,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0B70
 #define USB_PRODUCT_ID 0x00BA
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/iriverh10_5gb.h b/firmware/export/config/iriverh10_5gb.h
index 9d52c8b317..4d3c3f28b0 100644
--- a/firmware/export/config/iriverh10_5gb.h
+++ b/firmware/export/config/iriverh10_5gb.h
@@ -160,7 +160,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0B70
 #define USB_PRODUCT_ID 0x00BA
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/mrobe100.h b/firmware/export/config/mrobe100.h
index c020bbc700..5b6a489550 100644
--- a/firmware/export/config/mrobe100.h
+++ b/firmware/export/config/mrobe100.h
@@ -178,7 +178,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x07B4
 #define USB_PRODUCT_ID 0x0280
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/mrobe500.h b/firmware/export/config/mrobe500.h
index c2738f94c5..32b4f7c99d 100644
--- a/firmware/export/config/mrobe500.h
+++ b/firmware/export/config/mrobe500.h
@@ -211,7 +211,6 @@
 
 /* enable these for the usb stack */
 #define CONFIG_USBOTG       USBOTG_M66591
-#define USE_ROCKBOX_USB
 
 #define HAVE_USBSTACK
 //#define HAVE_USB_POWER
diff --git a/firmware/export/config/ondavx747.h b/firmware/export/config/ondavx747.h
index 8499c15ce9..d02845808f 100644
--- a/firmware/export/config/ondavx747.h
+++ b/firmware/export/config/ondavx747.h
@@ -207,7 +207,6 @@ No access to the NAND yet..
 
 #define CONFIG_USBOTG     USBOTG_JZ4740
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 /* Connect by events, not by tick polling */
 #define USB_STATUS_BY_EVENT
 
diff --git a/firmware/export/config/ondavx767.h b/firmware/export/config/ondavx767.h
index 7499873537..77fce1d1a4 100644
--- a/firmware/export/config/ondavx767.h
+++ b/firmware/export/config/ondavx767.h
@@ -163,7 +163,6 @@
 
 #define CONFIG_USBOTG   USBOTG_JZ4740
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID   0x07C4
 #define USB_PRODUCT_ID  0xA4A5
 
diff --git a/firmware/export/config/ondavx777.h b/firmware/export/config/ondavx777.h
index a254b0177c..404d193d4a 100644
--- a/firmware/export/config/ondavx777.h
+++ b/firmware/export/config/ondavx777.h
@@ -194,7 +194,6 @@ No access to the NAND yet..
 
 #define CONFIG_USBOTG     USBOTG_JZ4740
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 /* Connect by events, not by tick polling */
 #define USB_STATUS_BY_EVENT
 #define USB_VENDOR_ID     0x07C4
diff --git a/firmware/export/config/rk27generic.h b/firmware/export/config/rk27generic.h
index 4d5f1b6c5c..786ac283e2 100644
--- a/firmware/export/config/rk27generic.h
+++ b/firmware/export/config/rk27generic.h
@@ -157,7 +157,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x071b
 #define USB_PRODUCT_ID 0x3202
 #define HAVE_BOOTLOADER_USB_MODE
diff --git a/firmware/export/config/samsungyh820.h b/firmware/export/config/samsungyh820.h
index fef914e445..52ed821370 100644
--- a/firmware/export/config/samsungyh820.h
+++ b/firmware/export/config/samsungyh820.h
@@ -165,7 +165,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID   0x04e8
 #define USB_PRODUCT_ID  0x5023
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/samsungyh920.h b/firmware/export/config/samsungyh920.h
index a05ee94ddd..27f1ca76a3 100644
--- a/firmware/export/config/samsungyh920.h
+++ b/firmware/export/config/samsungyh920.h
@@ -181,7 +181,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID   0x04e8
 #define USB_PRODUCT_ID  0x5022
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/samsungyh925.h b/firmware/export/config/samsungyh925.h
index 4816117fb3..e6c2133034 100644
--- a/firmware/export/config/samsungyh925.h
+++ b/firmware/export/config/samsungyh925.h
@@ -172,7 +172,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID   0x04e8
 #define USB_PRODUCT_ID  0x5024
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/samsungyps3.h b/firmware/export/config/samsungyps3.h
index ddfe176020..3843a3c08d 100644
--- a/firmware/export/config/samsungyps3.h
+++ b/firmware/export/config/samsungyps3.h
@@ -149,7 +149,6 @@
 
 /* USB */
 //#define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x04E8
 #define USB_PRODUCT_ID 0x5090
 
diff --git a/firmware/export/config/samsungypz5.h b/firmware/export/config/samsungypz5.h
index b1f382e042..0580fbbe0b 100644
--- a/firmware/export/config/samsungypz5.h
+++ b/firmware/export/config/samsungypz5.h
@@ -184,7 +184,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x04e8
 #define USB_PRODUCT_ID 0x5041
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansac200.h b/firmware/export/config/sansac200.h
index c3fd2d05e0..4e8ea55002 100644
--- a/firmware/export/config/sansac200.h
+++ b/firmware/export/config/sansac200.h
@@ -189,7 +189,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7451
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansac200v2.h b/firmware/export/config/sansac200v2.h
index 2d611240f2..9e9c8b835f 100644
--- a/firmware/export/config/sansac200v2.h
+++ b/firmware/export/config/sansac200v2.h
@@ -184,7 +184,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 //#define USB_ENABLE_SERIAL
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7452
diff --git a/firmware/export/config/sansaclip.h b/firmware/export/config/sansaclip.h
index 6070a6efaa..54500402d7 100644
--- a/firmware/export/config/sansaclip.h
+++ b/firmware/export/config/sansaclip.h
@@ -179,7 +179,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7433
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansaclipplus.h b/firmware/export/config/sansaclipplus.h
index 0bdf82dce4..dc9ad90b5b 100644
--- a/firmware/export/config/sansaclipplus.h
+++ b/firmware/export/config/sansaclipplus.h
@@ -186,7 +186,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x74d1
 
diff --git a/firmware/export/config/sansaclipv2.h b/firmware/export/config/sansaclipv2.h
index a8ccebcf7a..a61d5ba18c 100644
--- a/firmware/export/config/sansaclipv2.h
+++ b/firmware/export/config/sansaclipv2.h
@@ -182,7 +182,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7435
 
diff --git a/firmware/export/config/sansaclipzip.h b/firmware/export/config/sansaclipzip.h
index eaf51d961b..50147b9714 100644
--- a/firmware/export/config/sansaclipzip.h
+++ b/firmware/export/config/sansaclipzip.h
@@ -185,7 +185,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x74e5
 
diff --git a/firmware/export/config/sansae200.h b/firmware/export/config/sansae200.h
index 296416a91e..db3ccb1c1c 100644
--- a/firmware/export/config/sansae200.h
+++ b/firmware/export/config/sansae200.h
@@ -189,7 +189,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7421
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansae200v2.h b/firmware/export/config/sansae200v2.h
index c703439e7f..23bee8c98a 100644
--- a/firmware/export/config/sansae200v2.h
+++ b/firmware/export/config/sansae200v2.h
@@ -201,7 +201,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7423
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansafuze.h b/firmware/export/config/sansafuze.h
index c03106e4c3..b2cdf061dd 100644
--- a/firmware/export/config/sansafuze.h
+++ b/firmware/export/config/sansafuze.h
@@ -202,7 +202,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x74c1
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansafuzeplus.h b/firmware/export/config/sansafuzeplus.h
index 270060d594..73ac5b9d32 100644
--- a/firmware/export/config/sansafuzeplus.h
+++ b/firmware/export/config/sansafuzeplus.h
@@ -185,7 +185,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x74e1
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansafuzev2.h b/firmware/export/config/sansafuzev2.h
index beb18d92c7..a0197bfb41 100644
--- a/firmware/export/config/sansafuzev2.h
+++ b/firmware/export/config/sansafuzev2.h
@@ -203,7 +203,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x74c3   /* MSC = 0x74c3, MTP = 0x74c2 */
 
diff --git a/firmware/export/config/sansam200v4.h b/firmware/export/config/sansam200v4.h
index f6b2ebc006..99e84e65e0 100644
--- a/firmware/export/config/sansam200v4.h
+++ b/firmware/export/config/sansam200v4.h
@@ -145,7 +145,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x7431
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sansaview.h b/firmware/export/config/sansaview.h
index 140407453b..21083da7cb 100644
--- a/firmware/export/config/sansaview.h
+++ b/firmware/export/config/sansaview.h
@@ -171,7 +171,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0781
 #define USB_PRODUCT_ID 0x74b1
 
diff --git a/firmware/export/config/sim.h b/firmware/export/config/sim.h
index 2f819b733e..2dd6a929d3 100644
--- a/firmware/export/config/sim.h
+++ b/firmware/export/config/sim.h
@@ -51,7 +51,6 @@
 #undef USB_HANDLED_BY_OF
 
 #undef HAVE_USBSTACK
-#undef USE_ROCKBOX_USB
 #undef USB_VENDOR_ID
 #undef USB_PRODUCT_ID
 #undef USB_NUM_ENDPOINTS
diff --git a/firmware/export/config/sonynwze360.h b/firmware/export/config/sonynwze360.h
index 685391d5f9..5f5b1cd597 100644
--- a/firmware/export/config/sonynwze360.h
+++ b/firmware/export/config/sonynwze360.h
@@ -167,7 +167,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x054c
 #define USB_PRODUCT_ID 0x059b
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/sonynwze370.h b/firmware/export/config/sonynwze370.h
index 053d103f2e..b4c4f16b13 100644
--- a/firmware/export/config/sonynwze370.h
+++ b/firmware/export/config/sonynwze370.h
@@ -164,7 +164,6 @@
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
 //#define USB_HANDLED_BY_OF
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x054c
 #define USB_PRODUCT_ID 0x068a
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/vibe500.h b/firmware/export/config/vibe500.h
index 96b5321e66..8e61726434 100644
--- a/firmware/export/config/vibe500.h
+++ b/firmware/export/config/vibe500.h
@@ -175,7 +175,6 @@
 
 /* enable these for the experimental usb stack */
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x0409
 #define USB_PRODUCT_ID 0x8038
 #define HAVE_USB_HID_MOUSE
diff --git a/firmware/export/config/zenvisionm30gb.h b/firmware/export/config/zenvisionm30gb.h
index 73d852433b..6ce2876551 100644
--- a/firmware/export/config/zenvisionm30gb.h
+++ b/firmware/export/config/zenvisionm30gb.h
@@ -164,7 +164,6 @@
 
 #define CONFIG_USBOTG USBOTG_ISP1583
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e 
 #define USB_PRODUCT_ID 0x4133
 #define USB_NUM_ENDPOINTS 7
diff --git a/firmware/export/config/zenvisionm60gb.h b/firmware/export/config/zenvisionm60gb.h
index d1bd91154b..5510e9a338 100644
--- a/firmware/export/config/zenvisionm60gb.h
+++ b/firmware/export/config/zenvisionm60gb.h
@@ -164,7 +164,6 @@
 /* #define CONFIG_USBOTG    USBOTG_ISP1761 */
 #define CONFIG_USBOTG USBOTG_ISP1583
 #define HAVE_USBSTACK
-#define USE_ROCKBOX_USB
 #define USB_VENDOR_ID 0x041e 
 #define USB_PRODUCT_ID 0x4133
 #define USB_NUM_ENDPOINTS 7
diff --git a/firmware/target/arm/as3525/usb-as3525.c b/firmware/target/arm/as3525/usb-as3525.c
index 99ae66dc15..d9fb1fdfec 100644
--- a/firmware/target/arm/as3525/usb-as3525.c
+++ b/firmware/target/arm/as3525/usb-as3525.c
@@ -32,7 +32,7 @@ static int usb_status = USB_EXTRACTED;
 
 void usb_enable(bool on)
 {
-#if defined(HAVE_USBSTACK) && defined(USE_ROCKBOX_USB)
+#if defined(HAVE_USBSTACK)
     if (on)
         usb_core_init();
     else
diff --git a/firmware/usb.c b/firmware/usb.c
index a7b19eb065..fc89df709c 100644
--- a/firmware/usb.c
+++ b/firmware/usb.c
@@ -48,10 +48,10 @@
      (defined(HAVE_USBSTACK) && defined(HAVE_BOOTLOADER_USB_MODE)) || \
      (defined(HAVE_USBSTACK) && (defined(CREATIVE_ZVx))) || \
      (defined(HAVE_USBSTACK) && (defined(OLYMPUS_MROBE_500))) || \
-     (defined(HAVE_USBSTACK) && defined(USE_ROCKBOX_USB) && CONFIG_USBOTG == USBOTG_S3C6400X) || \
+     (defined(HAVE_USBSTACK) && CONFIG_USBOTG == USBOTG_S3C6400X) || \
      defined(CPU_TCC77X) || defined(CPU_TCC780X) || \
      (CONFIG_USBOTG == USBOTG_JZ4740) || \
-     (defined(USE_ROCKBOX_USB) && CONFIG_USBOTG == USBOTG_AS3525)
+     (defined(HAVE_USBSTACK) && CONFIG_USBOTG == USBOTG_AS3525)
 #define USB_FULL_INIT
 #endif
 
@@ -88,8 +88,7 @@ static long usb_last_broadcast_tick = 0;
 static bool usb_charging_only = false;
 #endif
 
-#if defined(USB_FIREWIRE_HANDLING) \
-    || (defined(HAVE_USBSTACK) && !defined(USE_ROCKBOX_USB))
+#if defined(USB_FIREWIRE_HANDLING)
 static void try_reboot(void)
 {
 #ifdef HAVE_DISK_STORAGE
@@ -111,7 +110,7 @@ static void try_reboot(void)
 
     system_reboot(); /* Reboot */
 }
-#endif /* USB_FIRWIRE_HANDLING || (HAVE_USBSTACK && !USE_ROCKBOX_USB) */
+#endif /* USB_FIRWIRE_HANDLING */
 
 /* Screen dump */
 #ifdef HAVE_LCD_BITMAP
@@ -232,7 +231,6 @@ static inline bool usb_configure_drivers(int for_state)
     return false;
 }
 
-#ifdef USE_ROCKBOX_USB
 static inline void usb_slave_mode(bool on)
 {
     int rc;
@@ -259,15 +257,6 @@ static inline void usb_slave_mode(bool on)
         cancel_cpu_boost();
     }
 }
-#else /* !USE_ROCKBOX_USB */
-static inline void usb_slave_mode(bool on)
-{
-    /* Until we have native mass-storage mode, we want to reboot on USB host
-     * connect */
-    if(on)
-        try_reboot();
-}
-#endif /* USE_ROCKBOX_USB */
 
 void usb_signal_transfer_completion(
     struct usb_transfer_completion_event_data* event_data)
-- 
cgit