From 57d6db6ff597c692e3d35a4ddffc86189268f8f6 Mon Sep 17 00:00:00 2001 From: Amaury Pouly Date: Thu, 18 Sep 2014 13:01:35 +0200 Subject: qeditor: fix UI to update register/analyser view on each tree/list click Change-Id: Idaceb7ffaf33c2184a43353dd9d7dee20ac807a9 Reviewed-on: http://gerrit.rockbox.org/972 Reviewed-by: Amaury Pouly --- utils/regtools/qeditor/regtab.cpp | 22 +++++----------------- utils/regtools/qeditor/regtab.h | 2 -- 2 files changed, 5 insertions(+), 19 deletions(-) (limited to 'utils/regtools/qeditor') diff --git a/utils/regtools/qeditor/regtab.cpp b/utils/regtools/qeditor/regtab.cpp index 9292248c61..132308e8ff 100644 --- a/utils/regtools/qeditor/regtab.cpp +++ b/utils/regtools/qeditor/regtab.cpp @@ -143,12 +143,12 @@ RegTab::RegTab(Backend *backend, QWidget *parent) connect(m_soc_selector, SIGNAL(currentIndexChanged(int)), this, SLOT(OnSocChanged(int))); connect(m_backend, SIGNAL(OnSocListChanged()), this, SLOT(OnSocListChanged())); - connect(m_reg_tree, SIGNAL(currentItemChanged(QTreeWidgetItem*, QTreeWidgetItem*)), - this, SLOT(OnRegItemChanged(QTreeWidgetItem*, QTreeWidgetItem*))); + connect(m_reg_tree, SIGNAL(itemClicked(QTreeWidgetItem*, int)), + this, SLOT(OnRegItemClicked(QTreeWidgetItem*, int))); connect(m_data_soc_label, SIGNAL(linkActivated(const QString&)), this, SLOT(OnDataSocActivated(const QString&))); - connect(m_analysers_list, SIGNAL(currentItemChanged(QListWidgetItem *, QListWidgetItem *)), - this, SLOT(OnAnalyserChanged(QListWidgetItem *, QListWidgetItem *))); + connect(m_analysers_list, SIGNAL(itemClicked(QListWidgetItem *)), + this, SLOT(OnAnalyserClicked(QListWidgetItem *))); connect(m_backend_selector, SIGNAL(OnSelect(IoBackend *)), this, SLOT(OnBackendSelect(IoBackend *))); connect(m_readonly_check, SIGNAL(clicked(bool)), this, SLOT(OnReadOnlyClicked(bool))); @@ -209,13 +209,7 @@ void RegTab::SetReadOnlyIndicator() void RegTab::OnDataChanged() { - OnRegItemChanged(m_reg_tree->currentItem(), m_reg_tree->currentItem()); -} - -void RegTab::OnRegItemChanged(QTreeWidgetItem *current, QTreeWidgetItem *previous) -{ - Q_UNUSED(previous); - OnRegItemClicked(current, 0); + OnRegItemClicked(m_reg_tree->currentItem(), 0); } void RegTab::OnRegItemClicked(QTreeWidgetItem *current, int col) @@ -240,12 +234,6 @@ void RegTab::OnRegItemClicked(QTreeWidgetItem *current, int col) } } -void RegTab::OnAnalyserChanged(QListWidgetItem *current, QListWidgetItem *previous) -{ - Q_UNUSED(previous); - OnAnalyserClicked(current); -} - void RegTab::OnAnalyserClicked(QListWidgetItem *current) { if(current == 0) diff --git a/utils/regtools/qeditor/regtab.h b/utils/regtools/qeditor/regtab.h index 781deff41c..f48b72e683 100644 --- a/utils/regtools/qeditor/regtab.h +++ b/utils/regtools/qeditor/regtab.h @@ -79,12 +79,10 @@ private slots: void SetReadOnlyIndicator(); void OnSocChanged(int index); void OnSocListChanged(); - void OnRegItemChanged(QTreeWidgetItem *current, QTreeWidgetItem *previous); void OnRegItemClicked(QTreeWidgetItem *clicked, int col); void OnBackendSelect(IoBackend *backend); void OnDataChanged(); void OnDataSocActivated(const QString&); - void OnAnalyserChanged(QListWidgetItem *current, QListWidgetItem *previous); void OnAnalyserClicked(QListWidgetItem *clicked); void OnReadOnlyClicked(bool); void OnDumpRegs(bool); -- cgit v1.2.3